From: troy.kisky@boundarydevices.com (Troy Kisky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id
Date: Tue, 1 Mar 2016 15:43:01 -0700 [thread overview]
Message-ID: <56D61AF5.5030507@boundarydevices.com> (raw)
In-Reply-To: <CAHrpEqQdBqUwfrHL=dHGszEeU-pRo9mmOyuTy6aaw3QMBdkqUg@mail.gmail.com>
On 3/1/2016 3:26 PM, Zhi Li wrote:
> On Tue, Mar 1, 2016 at 3:51 PM, Troy Kisky
> <troy.kisky@boundarydevices.com> wrote:
>> True, but fec_txq/fec_rxq is called in a loop.
>
> netdev_priv(ndev) is that pointer move.
> dev + ALIGN(sizeof(struct net_device), NETDEV_ALIGN)
>
> Modem compiler can handle it greatly.
>
> You can't get any valuable performance gain by that.
>
> The main time of CPU is call dma_map_xxx.
>
> best regards
> Frank Li
>
Ok, I'll revert that part.
WARNING: multiple messages have this Message-ID (diff)
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Zhi Li <lznuaa@gmail.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Duan Fugang-B38611 <B38611@freescale.com>,
Fabio Estevam <fabio.estevam@freescale.com>,
Lucas Stach <l.stach@pengutronix.de>,
Andrew Lunn <andrew@lunn.ch>, Philippe Reynes <tremyfr@gmail.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Laci Tele <laci@boundarydevices.com>,
Shawn Guo <shawnguo@kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Joshua Clayton <stillcompiling@gmail.com>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue instead of queue_id
Date: Tue, 1 Mar 2016 15:43:01 -0700 [thread overview]
Message-ID: <56D61AF5.5030507@boundarydevices.com> (raw)
In-Reply-To: <CAHrpEqQdBqUwfrHL=dHGszEeU-pRo9mmOyuTy6aaw3QMBdkqUg@mail.gmail.com>
On 3/1/2016 3:26 PM, Zhi Li wrote:
> On Tue, Mar 1, 2016 at 3:51 PM, Troy Kisky
> <troy.kisky@boundarydevices.com> wrote:
>> True, but fec_txq/fec_rxq is called in a loop.
>
> netdev_priv(ndev) is that pointer move.
> dev + ALIGN(sizeof(struct net_device), NETDEV_ALIGN)
>
> Modem compiler can handle it greatly.
>
> You can't get any valuable performance gain by that.
>
> The main time of CPU is call dma_map_xxx.
>
> best regards
> Frank Li
>
Ok, I'll revert that part.
next prev parent reply other threads:[~2016-03-01 22:43 UTC|newest]
Thread overview: 106+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 0:36 [PATCH net-next V2 00/16] net: fec: cleanup and fixes Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 01/16] net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-03-02 14:57 ` Fugang Duan
2016-03-02 14:57 ` Fugang Duan
2016-02-25 0:36 ` [PATCH net-next V2 02/16] net: fec: pass rxq to fec_enet_rx_queue instead of queue_id Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-03-01 21:05 ` Zhi Li
2016-03-01 21:05 ` Zhi Li
2016-03-02 15:01 ` Fugang Duan
2016-03-02 15:01 ` Fugang Duan
2016-02-25 0:36 ` [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue " Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-03-01 21:06 ` Zhi Li
2016-03-01 21:06 ` Zhi Li
2016-03-01 21:51 ` Troy Kisky
2016-03-01 21:51 ` Troy Kisky
2016-03-01 22:26 ` Zhi Li
2016-03-01 22:26 ` Zhi Li
2016-03-01 22:43 ` Troy Kisky [this message]
2016-03-01 22:43 ` Troy Kisky
2016-03-02 15:16 ` Fugang Duan
2016-03-02 15:16 ` Fugang Duan
2016-03-02 16:13 ` Troy Kisky
2016-03-02 16:13 ` Troy Kisky
2016-03-04 7:41 ` Fugang Duan
2016-03-04 7:41 ` Fugang Duan
2016-03-04 16:23 ` Troy Kisky
2016-03-04 16:23 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 04/16] net: fec: reduce interrupts Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-03-02 15:13 ` Fugang Duan
2016-03-02 15:13 ` Fugang Duan
2016-03-02 16:12 ` Troy Kisky
2016-03-02 16:12 ` Troy Kisky
2016-03-02 16:44 ` Zhi Li
2016-03-02 16:44 ` Zhi Li
2016-03-02 16:47 ` Zhi Li
2016-03-02 16:47 ` Zhi Li
2016-03-02 22:32 ` Troy Kisky
2016-03-02 22:32 ` Troy Kisky
2016-03-02 22:52 ` Zhi Li
2016-03-02 22:52 ` Zhi Li
2016-03-04 8:58 ` Fugang Duan
2016-03-04 8:58 ` Fugang Duan
2016-02-25 0:36 ` [PATCH net-next V2 05/16] net: fec: split off napi routine with 3 queues Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 06/16] net: fec: don't clear all rx queue bits when just one is being checked Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-03-04 9:11 ` Fugang Duan
2016-03-04 9:11 ` Fugang Duan
2016-03-04 16:18 ` Troy Kisky
2016-03-04 16:18 ` Troy Kisky
2016-03-04 16:38 ` Russell King - ARM Linux
2016-03-04 16:38 ` Russell King - ARM Linux
2016-03-04 17:28 ` Troy Kisky
2016-03-04 17:28 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 07/16] net: fec: set cbd_sc without relying on previous value Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-03-04 9:29 ` Fugang Duan
2016-03-04 9:29 ` Fugang Duan
2016-03-04 16:08 ` Troy Kisky
2016-03-04 16:08 ` Troy Kisky
2016-03-05 23:55 ` Fugang Duan
2016-03-05 23:55 ` Fugang Duan
2016-02-25 0:36 ` [PATCH net-next V2 08/16] net: fec: eliminate calls to fec_enet_get_prevdesc Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-03-04 9:33 ` Fugang Duan
2016-03-04 9:33 ` Fugang Duan
2016-03-04 16:05 ` Troy Kisky
2016-03-04 16:05 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 09/16] net: fec: move restart test for efficiency Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 10/16] net: fec: clear cbd_sc after transmission to help with debugging Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 11/16] net: fec: dump all tx queues in fec_dump Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 12/16] net: fec: detect tx int lost Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 13/16] net: fec: print more debug info in fec_timeout Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-03-04 10:06 ` Fugang Duan
2016-03-04 10:06 ` Fugang Duan
2016-03-04 16:05 ` Troy Kisky
2016-03-04 16:05 ` Troy Kisky
2016-03-04 17:35 ` Joe Perches
2016-03-04 17:35 ` Joe Perches
2016-03-04 19:06 ` Troy Kisky
2016-03-04 19:06 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 14/16] net: fec: create subroutine reset_tx_queue Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 15/16] net: fec: call dma_unmap_single on mapped tx buffers at restart Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-02-25 0:36 ` [PATCH net-next V2 16/16] net: fec: don't set cbd_bufaddr unless no mapping error Troy Kisky
2016-02-25 0:36 ` Troy Kisky
2016-02-25 2:52 ` [PATCH net-next V2 00/16] net: fec: cleanup and fixes Joshua Clayton
2016-02-25 2:52 ` Joshua Clayton
2016-02-25 16:05 ` Troy Kisky
2016-02-25 16:05 ` Troy Kisky
2016-02-25 16:49 ` Joshua Clayton
2016-02-25 16:49 ` Joshua Clayton
2016-02-25 8:39 ` Holger Schurig
2016-02-25 8:39 ` Holger Schurig
2016-02-25 15:57 ` Troy Kisky
2016-02-25 15:57 ` Troy Kisky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D61AF5.5030507@boundarydevices.com \
--to=troy.kisky@boundarydevices.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.