All of lore.kernel.org
 help / color / mirror / Atom feed
From: troy.kisky@boundarydevices.com (Troy Kisky)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next V2 08/16] net: fec: eliminate calls to fec_enet_get_prevdesc
Date: Fri, 4 Mar 2016 09:05:42 -0700	[thread overview]
Message-ID: <56D9B256.7040408@boundarydevices.com> (raw)
In-Reply-To: <VI1PR0401MB18556C9393B8629330062B8EFFBE0@VI1PR0401MB1855.eurprd04.prod.outlook.com>

On 3/4/2016 2:33 AM, Fugang Duan wrote:
> From: Troy Kisky <troy.kisky@boundarydevices.com> Sent: Thursday, February 25, 2016 8:37 AM
>> To: netdev at vger.kernel.org; davem at davemloft.net; b38611 at freescale.com
>> Cc: fabio.estevam at freescale.com; l.stach at pengutronix.de; andrew at lunn.ch;
>> tremyfr at gmail.com; linux at arm.linux.org.uk; linux-arm-
>> kernel at lists.infradead.org; laci at boundarydevices.com; shawnguo at kernel.org;
>> johannes at sipsolutions.net; stillcompiling at gmail.com;
>> sergei.shtylyov at cogentembedded.com; arnd at arndb.de; Troy Kisky
>> <troy.kisky@boundarydevices.com>
>> Subject: [PATCH net-next V2 08/16] net: fec: eliminate calls to
>> fec_enet_get_prevdesc
>>
>> This shrinks the code a little.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>> ---
>>  drivers/net/ethernet/freescale/fec_main.c | 37 +++++++++----------------------
>>  1 file changed, 11 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/freescale/fec_main.c
>> b/drivers/net/ethernet/freescale/fec_main.c
>> index 6ceb5f9..b5ed287 100644
>> --- a/drivers/net/ethernet/freescale/fec_main.c
>> +++ b/drivers/net/ethernet/freescale/fec_main.c
>> @@ -758,6 +758,7 @@ static void fec_enet_bd_init(struct net_device *dev)
>>  	struct bufdesc *bdp;
>>  	unsigned int i;
>>  	unsigned int q;
>> +	unsigned status;
> 
> Should be unsigned int status;
> 


Fine



Thanks

WARNING: multiple messages have this Message-ID (diff)
From: Troy Kisky <troy.kisky@boundarydevices.com>
To: Fugang Duan <fugang.duan@nxp.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"b38611@freescale.com" <b38611@freescale.com>
Cc: "fabio.estevam@freescale.com" <fabio.estevam@freescale.com>,
	"l.stach@pengutronix.de" <l.stach@pengutronix.de>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	"tremyfr@gmail.com" <tremyfr@gmail.com>,
	"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"laci@boundarydevices.com" <laci@boundarydevices.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"johannes@sipsolutions.net" <johannes@sipsolutions.net>,
	"stillcompiling@gmail.com" <stillcompiling@gmail.com>,
	"sergei.shtylyov@cogentembedded.com"
	<sergei.shtylyov@cogentembedded.com>,
	"arnd@arndb.de" <arnd@arndb.de>
Subject: Re: [PATCH net-next V2 08/16] net: fec: eliminate calls to fec_enet_get_prevdesc
Date: Fri, 4 Mar 2016 09:05:42 -0700	[thread overview]
Message-ID: <56D9B256.7040408@boundarydevices.com> (raw)
In-Reply-To: <VI1PR0401MB18556C9393B8629330062B8EFFBE0@VI1PR0401MB1855.eurprd04.prod.outlook.com>

On 3/4/2016 2:33 AM, Fugang Duan wrote:
> From: Troy Kisky <troy.kisky@boundarydevices.com> Sent: Thursday, February 25, 2016 8:37 AM
>> To: netdev@vger.kernel.org; davem@davemloft.net; b38611@freescale.com
>> Cc: fabio.estevam@freescale.com; l.stach@pengutronix.de; andrew@lunn.ch;
>> tremyfr@gmail.com; linux@arm.linux.org.uk; linux-arm-
>> kernel@lists.infradead.org; laci@boundarydevices.com; shawnguo@kernel.org;
>> johannes@sipsolutions.net; stillcompiling@gmail.com;
>> sergei.shtylyov@cogentembedded.com; arnd@arndb.de; Troy Kisky
>> <troy.kisky@boundarydevices.com>
>> Subject: [PATCH net-next V2 08/16] net: fec: eliminate calls to
>> fec_enet_get_prevdesc
>>
>> This shrinks the code a little.
>>
>> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
>> ---
>>  drivers/net/ethernet/freescale/fec_main.c | 37 +++++++++----------------------
>>  1 file changed, 11 insertions(+), 26 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/freescale/fec_main.c
>> b/drivers/net/ethernet/freescale/fec_main.c
>> index 6ceb5f9..b5ed287 100644
>> --- a/drivers/net/ethernet/freescale/fec_main.c
>> +++ b/drivers/net/ethernet/freescale/fec_main.c
>> @@ -758,6 +758,7 @@ static void fec_enet_bd_init(struct net_device *dev)
>>  	struct bufdesc *bdp;
>>  	unsigned int i;
>>  	unsigned int q;
>> +	unsigned status;
> 
> Should be unsigned int status;
> 


Fine



Thanks

  reply	other threads:[~2016-03-04 16:05 UTC|newest]

Thread overview: 106+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-25  0:36 [PATCH net-next V2 00/16] net: fec: cleanup and fixes Troy Kisky
2016-02-25  0:36 ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 01/16] net: fec: only check queue 0 if RXF_0/TXF_0 interrupt is set Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-03-02 14:57   ` Fugang Duan
2016-03-02 14:57     ` Fugang Duan
2016-02-25  0:36 ` [PATCH net-next V2 02/16] net: fec: pass rxq to fec_enet_rx_queue instead of queue_id Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-03-01 21:05   ` Zhi Li
2016-03-01 21:05     ` Zhi Li
2016-03-02 15:01   ` Fugang Duan
2016-03-02 15:01     ` Fugang Duan
2016-02-25  0:36 ` [PATCH net-next V2 03/16] net: fec: pass txq to fec_enet_tx_queue " Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-03-01 21:06   ` Zhi Li
2016-03-01 21:06     ` Zhi Li
2016-03-01 21:51     ` Troy Kisky
2016-03-01 21:51       ` Troy Kisky
2016-03-01 22:26       ` Zhi Li
2016-03-01 22:26         ` Zhi Li
2016-03-01 22:43         ` Troy Kisky
2016-03-01 22:43           ` Troy Kisky
2016-03-02 15:16   ` Fugang Duan
2016-03-02 15:16     ` Fugang Duan
2016-03-02 16:13     ` Troy Kisky
2016-03-02 16:13       ` Troy Kisky
2016-03-04  7:41       ` Fugang Duan
2016-03-04  7:41         ` Fugang Duan
2016-03-04 16:23         ` Troy Kisky
2016-03-04 16:23           ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 04/16] net: fec: reduce interrupts Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-03-02 15:13   ` Fugang Duan
2016-03-02 15:13     ` Fugang Duan
2016-03-02 16:12     ` Troy Kisky
2016-03-02 16:12       ` Troy Kisky
2016-03-02 16:44       ` Zhi Li
2016-03-02 16:44         ` Zhi Li
2016-03-02 16:47       ` Zhi Li
2016-03-02 16:47         ` Zhi Li
2016-03-02 22:32         ` Troy Kisky
2016-03-02 22:32           ` Troy Kisky
2016-03-02 22:52           ` Zhi Li
2016-03-02 22:52             ` Zhi Li
2016-03-04  8:58   ` Fugang Duan
2016-03-04  8:58     ` Fugang Duan
2016-02-25  0:36 ` [PATCH net-next V2 05/16] net: fec: split off napi routine with 3 queues Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 06/16] net: fec: don't clear all rx queue bits when just one is being checked Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-03-04  9:11   ` Fugang Duan
2016-03-04  9:11     ` Fugang Duan
2016-03-04 16:18     ` Troy Kisky
2016-03-04 16:18       ` Troy Kisky
2016-03-04 16:38       ` Russell King - ARM Linux
2016-03-04 16:38         ` Russell King - ARM Linux
2016-03-04 17:28         ` Troy Kisky
2016-03-04 17:28           ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 07/16] net: fec: set cbd_sc without relying on previous value Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-03-04  9:29   ` Fugang Duan
2016-03-04  9:29     ` Fugang Duan
2016-03-04 16:08     ` Troy Kisky
2016-03-04 16:08       ` Troy Kisky
2016-03-05 23:55       ` Fugang Duan
2016-03-05 23:55         ` Fugang Duan
2016-02-25  0:36 ` [PATCH net-next V2 08/16] net: fec: eliminate calls to fec_enet_get_prevdesc Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-03-04  9:33   ` Fugang Duan
2016-03-04  9:33     ` Fugang Duan
2016-03-04 16:05     ` Troy Kisky [this message]
2016-03-04 16:05       ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 09/16] net: fec: move restart test for efficiency Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 10/16] net: fec: clear cbd_sc after transmission to help with debugging Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 11/16] net: fec: dump all tx queues in fec_dump Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 12/16] net: fec: detect tx int lost Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 13/16] net: fec: print more debug info in fec_timeout Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-03-04 10:06   ` Fugang Duan
2016-03-04 10:06     ` Fugang Duan
2016-03-04 16:05     ` Troy Kisky
2016-03-04 16:05       ` Troy Kisky
2016-03-04 17:35       ` Joe Perches
2016-03-04 17:35         ` Joe Perches
2016-03-04 19:06         ` Troy Kisky
2016-03-04 19:06           ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 14/16] net: fec: create subroutine reset_tx_queue Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 15/16] net: fec: call dma_unmap_single on mapped tx buffers at restart Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-02-25  0:36 ` [PATCH net-next V2 16/16] net: fec: don't set cbd_bufaddr unless no mapping error Troy Kisky
2016-02-25  0:36   ` Troy Kisky
2016-02-25  2:52 ` [PATCH net-next V2 00/16] net: fec: cleanup and fixes Joshua Clayton
2016-02-25  2:52   ` Joshua Clayton
2016-02-25 16:05   ` Troy Kisky
2016-02-25 16:05     ` Troy Kisky
2016-02-25 16:49     ` Joshua Clayton
2016-02-25 16:49       ` Joshua Clayton
2016-02-25  8:39 ` Holger Schurig
2016-02-25  8:39   ` Holger Schurig
2016-02-25 15:57   ` Troy Kisky
2016-02-25 15:57     ` Troy Kisky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56D9B256.7040408@boundarydevices.com \
    --to=troy.kisky@boundarydevices.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.