From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
alexandre.belloni@free-electrons.com, a.zummo@towertech.it
Cc: cw00.choi@samsung.com, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, javier@osg.samsung.com,
rklein@nvidia.com
Subject: [rtc-linux] Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation
Date: Wed, 02 Mar 2016 12:45:52 +0900 [thread overview]
Message-ID: <56D661F0.9080805@samsung.com> (raw)
In-Reply-To: <56D64A25.5050700@nvidia.com>
On 02.03.2016 11:04, Laxman Dewangan wrote:
>
> On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote:
>> On 29.02.2016 21:58, Laxman Dewangan wrote:
>>> use macro REGMAP_IRQ_REG from regmap.h to initialise the
>>> regmap irq table for max77686.
>> Why? Any benefits?
>>
>>
> I think it is better coding to use macro for member initializations
> instead of doing it locally and it improves readability.
>
> I got the similar comment from Lee's in my MFD patches to use macro for
> such initialization and I agreed with him.
>
> As I was here on this driver, thought to use macro.
Sounds good, so this should be written in commit message.
BR,
Krzysztof
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Laxman Dewangan <ldewangan@nvidia.com>,
alexandre.belloni@free-electrons.com, a.zummo@towertech.it
Cc: cw00.choi@samsung.com, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org, javier@osg.samsung.com,
rklein@nvidia.com
Subject: Re: [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation
Date: Wed, 02 Mar 2016 12:45:52 +0900 [thread overview]
Message-ID: <56D661F0.9080805@samsung.com> (raw)
In-Reply-To: <56D64A25.5050700@nvidia.com>
On 02.03.2016 11:04, Laxman Dewangan wrote:
>
> On Wednesday 02 March 2016 06:30 AM, Krzysztof Kozlowski wrote:
>> On 29.02.2016 21:58, Laxman Dewangan wrote:
>>> use macro REGMAP_IRQ_REG from regmap.h to initialise the
>>> regmap irq table for max77686.
>> Why? Any benefits?
>>
>>
> I think it is better coding to use macro for member initializations
> instead of doing it locally and it improves readability.
>
> I got the similar comment from Lee's in my MFD patches to use macro for
> such initialization and I agreed with him.
>
> As I was here on this driver, thought to use macro.
Sounds good, so this should be written in commit message.
BR,
Krzysztof
next prev parent reply other threads:[~2016-03-02 3:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-29 12:58 [rtc-linux] [PATCH 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP Laxman Dewangan
2016-02-29 12:58 ` Laxman Dewangan
2016-02-29 12:58 ` [rtc-linux] [PATCH 2/2] rtc: max77686: Use REGMAP_IRQ_REG for regmap-rtc-irqs initialisation Laxman Dewangan
2016-02-29 12:58 ` Laxman Dewangan
2016-03-02 1:00 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-02 1:00 ` Krzysztof Kozlowski
2016-03-02 2:04 ` [rtc-linux] " Laxman Dewangan
2016-03-02 2:04 ` Laxman Dewangan
2016-03-02 3:45 ` Krzysztof Kozlowski [this message]
2016-03-02 3:45 ` Krzysztof Kozlowski
2016-03-02 0:58 ` [rtc-linux] Re: [PATCH 1/2] rtc: max77686: Add support for MAX20024/MAX77620 RTC IP Krzysztof Kozlowski
2016-03-02 0:58 ` Krzysztof Kozlowski
2016-03-02 2:15 ` [rtc-linux] " Laxman Dewangan
2016-03-02 2:15 ` Laxman Dewangan
2016-03-02 3:52 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-02 3:52 ` Krzysztof Kozlowski
2016-03-02 4:10 ` [rtc-linux] " Laxman Dewangan
2016-03-02 4:10 ` Laxman Dewangan
2016-03-02 4:28 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-02 4:28 ` Krzysztof Kozlowski
2016-03-02 6:01 ` [rtc-linux] " Laxman Dewangan
2016-03-02 6:01 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D661F0.9080805@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=cw00.choi@samsung.com \
--cc=javier@osg.samsung.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rklein@nvidia.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.