From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com,
thuth@redhat.com, dgibson@redhat.com
Subject: Re: [kvm-unit-tests PATCH] powerpc: Add tests for RTAS
Date: Thu, 03 Mar 2016 17:12:06 +0000 [thread overview]
Message-ID: <56D87066.1090205@redhat.com> (raw)
In-Reply-To: <20160303170912.GD2354@potion.brq.redhat.com>
On 03/03/2016 18:09, Radim Krčmář wrote:
>>>>> >>> > + /* compute epoch: substract DAYS(since_March(1-1-1970)) */
>>>>> >>> > + epoch = DAYS(year, month, day) - DAYS(1969, 11, 1);
> And this comment points out that the API is bad. :)
>
> (Btw. am I going overboard?)
Only because I've committed it already. ;)
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Radim Krčmář" <rkrcmar@redhat.com>
Cc: Laurent Vivier <lvivier@redhat.com>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, drjones@redhat.com,
thuth@redhat.com, dgibson@redhat.com
Subject: Re: [kvm-unit-tests PATCH] powerpc: Add tests for RTAS
Date: Thu, 3 Mar 2016 18:12:06 +0100 [thread overview]
Message-ID: <56D87066.1090205@redhat.com> (raw)
In-Reply-To: <20160303170912.GD2354@potion.brq.redhat.com>
On 03/03/2016 18:09, Radim Krčmář wrote:
>>>>> >>> > + /* compute epoch: substract DAYS(since_March(1-1-1970)) */
>>>>> >>> > + epoch = DAYS(year, month, day) - DAYS(1969, 11, 1);
> And this comment points out that the API is bad. :)
>
> (Btw. am I going overboard?)
Only because I've committed it already. ;)
Paolo
next prev parent reply other threads:[~2016-03-03 17:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 21:19 [kvm-unit-tests PATCH] powerpc: Add tests for sPAPR h-calls Thomas Huth
2016-02-25 21:19 ` Thomas Huth
2016-02-29 0:38 ` David Gibson
2016-02-29 0:38 ` David Gibson
2016-03-03 12:28 ` [kvm-unit-tests PATCH] powerpc: Add tests for RTAS Laurent Vivier
2016-03-03 12:28 ` Laurent Vivier
2016-03-03 12:45 ` Paolo Bonzini
2016-03-03 12:45 ` Paolo Bonzini
2016-03-03 13:02 ` Laurent Vivier
2016-03-03 13:02 ` Laurent Vivier
2016-03-03 16:03 ` Radim Krčmář
2016-03-03 16:03 ` Radim Krčmář
2016-03-03 16:29 ` Paolo Bonzini
2016-03-03 16:29 ` Paolo Bonzini
2016-03-03 17:09 ` Radim Krčmář
2016-03-03 17:09 ` Radim Krčmář
2016-03-03 17:12 ` Paolo Bonzini [this message]
2016-03-03 17:12 ` Paolo Bonzini
2016-03-03 17:17 ` Radim Krčmář
2016-03-03 17:17 ` Radim Krčmář
2016-03-03 16:54 ` Thomas Huth
2016-03-03 16:54 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D87066.1090205@redhat.com \
--to=pbonzini@redhat.com \
--cc=dgibson@redhat.com \
--cc=drjones@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=lvivier@redhat.com \
--cc=rkrcmar@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.