From: Mark yao <mark.yao@rock-chips.com>
To: John Keeping <john@metanate.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/rockchip: vop: fix crtc size in plane check
Date: Fri, 04 Mar 2016 09:04:57 +0800 [thread overview]
Message-ID: <56D8DF39.8020104@rock-chips.com> (raw)
In-Reply-To: <1456143779-16208-1-git-send-email-john@metanate.com>
On 2016年02月22日 20:22, John Keeping wrote:
> If the geometry of a crtc is changing in an atomic update then we much
I think "we much validate" should be "we must validate".:-)
> validate the plane size against the new state of the crtc and not the
> current size, otherwise if the crtc size is increasing the plane will be
> cropped at the previous size and will not fill the screen.
>
> Signed-off-by: John Keeping<john@metanate.com>
--
Ｍark Yao
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: vop: fix crtc size in plane check
Date: Fri, 04 Mar 2016 09:04:57 +0800 [thread overview]
Message-ID: <56D8DF39.8020104@rock-chips.com> (raw)
In-Reply-To: <1456143779-16208-1-git-send-email-john@metanate.com>
On 2016?02?22? 20:22, John Keeping wrote:
> If the geometry of a crtc is changing in an atomic update then we much
I think "we much validate" should be "we must validate".:-)
> validate the plane size against the new state of the crtc and not the
> current size, otherwise if the crtc size is increasing the plane will be
> cropped at the previous size and will not fill the screen.
>
> Signed-off-by: John Keeping<john@metanate.com>
--
?ark Yao
WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: John Keeping <john@metanate.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/rockchip: vop: fix crtc size in plane check
Date: Fri, 04 Mar 2016 09:04:57 +0800 [thread overview]
Message-ID: <56D8DF39.8020104@rock-chips.com> (raw)
In-Reply-To: <1456143779-16208-1-git-send-email-john@metanate.com>
On 2016年02月22日 20:22, John Keeping wrote:
> If the geometry of a crtc is changing in an atomic update then we much
I think "we much validate" should be "we must validate".:-)
> validate the plane size against the new state of the crtc and not the
> current size, otherwise if the crtc size is increasing the plane will be
> cropped at the previous size and will not fill the screen.
>
> Signed-off-by: John Keeping<john@metanate.com>
--
Ｍark Yao
next prev parent reply other threads:[~2016-03-04 1:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-22 12:22 [PATCH] drm/rockchip: vop: fix crtc size in plane check John Keeping
2016-02-22 12:22 ` John Keeping
2016-02-22 12:22 ` John Keeping
2016-03-04 1:04 ` Mark yao [this message]
2016-03-04 1:04 ` Mark yao
2016-03-04 1:04 ` Mark yao
2016-03-04 11:04 ` [PATCH v2] " John Keeping
2016-03-04 11:04 ` John Keeping
2016-03-04 11:04 ` John Keeping
2016-03-14 2:39 ` Mark yao
2016-03-14 2:39 ` Mark yao
2016-03-14 2:39 ` Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56D8DF39.8020104@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=john@metanate.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.