From: Clemens Ladisch <clemens@ladisch.de>
To: Steve Calfee <stevecalfee@gmail.com>,
"Felipe F. Tonello" <eu@felipetonello.com>
Cc: USB list <linux-usb@vger.kernel.org>,
Kernel development list <linux-kernel@vger.kernel.org>,
Felipe Balbi <balbi@kernel.org>,
Michal Nazarewicz <mina86@mina86.com>,
Robert Baldyga <r.baldyga@samsung.com>
Subject: Re: [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize
Date: Fri, 11 Mar 2016 09:44:30 +0100 [thread overview]
Message-ID: <56E2856E.2070306@ladisch.de> (raw)
In-Reply-To: <CAJJ6jxss_ugwktn+U6O7hEXuW2tCfspR=oz2LOj6fHCrAyN9Vw@mail.gmail.com>
Steve Calfee wrote:
> On Wed, Mar 9, 2016 at 11:39 AM, Felipe F. Tonello <eu@felipetonello.com> wrote:
>> [...]
>> This patch fixes this problem by setting the minimum usb_request's buffer size
>> for the OUT endpoint as its wMaxPacketSize.
>>
>> --- a/drivers/usb/gadget/function/f_midi.c
>> +++ b/drivers/usb/gadget/function/f_midi.c
>> @@ -366,7 +366,9 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
>> struct usb_request *req =
>> - midi_alloc_ep_req(midi->out_ep, midi->buflen);
>> + midi_alloc_ep_req(midi->out_ep,
>> + max_t(unsigned, midi->buflen,
>> + bulk_out_desc.wMaxPacketSize));
>
> Won't you get a buffer overrun if midi->buflen is less than wMaxPacketSize?
No. f_midi_handle_out_data() uses only the request buffer.
Regards,
Clemens
next prev parent reply other threads:[~2016-03-11 8:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 19:39 [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize Felipe F. Tonello
2016-03-09 22:43 ` Steve Calfee
2016-03-10 9:23 ` Felipe Ferreri Tonello
2016-03-11 8:44 ` Clemens Ladisch [this message]
2016-03-11 23:07 ` Michal Nazarewicz
2016-03-14 16:00 ` Felipe Ferreri Tonello
2016-03-15 9:48 ` Clemens Ladisch
2016-03-30 10:51 ` Felipe Balbi
2016-03-30 12:33 ` Michal Nazarewicz
2016-04-01 9:25 ` Felipe Ferreri Tonello
2016-04-01 10:22 ` Felipe Balbi
2016-04-01 14:52 ` Felipe Ferreri Tonello
2016-04-04 10:46 ` Felipe Balbi
2016-04-04 11:33 ` Felipe Ferreri Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E2856E.2070306@ladisch.de \
--to=clemens@ladisch.de \
--cc=balbi@kernel.org \
--cc=eu@felipetonello.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=r.baldyga@samsung.com \
--cc=stevecalfee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.