From: Felipe Ferreri Tonello <eu@felipetonello.com>
To: Michal Nazarewicz <mina86@mina86.com>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Robert Baldyga <r.baldyga@samsung.com>
Subject: Re: [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize
Date: Fri, 1 Apr 2016 10:25:36 +0100 [thread overview]
Message-ID: <56FE3E90.9020305@felipetonello.com> (raw)
In-Reply-To: <xa1tio042lih.fsf@mina86.com>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
Hi Balbi and Mina,
On 30/03/16 13:33, Michal Nazarewicz wrote:
> On Wed, Mar 30 2016, Felipe Balbi wrote:
>> a USB packet, right. that's correct. But a struct usb_request can
>> point to whatever size buffer it wants and UDC is required to split
>> that into wMaxPacketSize transfers.
>
> D’oh. Of course. Disregard all my comments on the patch (except for
> Ack).
>
I didn't really get it. Does that mean that if buflen is multiple of
wMaxPacketSize, the UDC driver should fit as many [DATA] packets into
one usb_request and call complete() or it will always call complete() on
each [DATA] packet, thus not requiring buflen at all?
Does that mean that we can still use buflen and this patch is still
valid? (besides the endianess issue that was addressed on v2)
--
Felipe
[-- Attachment #2: 0x92698E6A.asc --]
[-- Type: application/pgp-keys, Size: 7195 bytes --]
next prev parent reply other threads:[~2016-04-01 9:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 19:39 [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize Felipe F. Tonello
2016-03-09 22:43 ` Steve Calfee
2016-03-10 9:23 ` Felipe Ferreri Tonello
2016-03-11 8:44 ` Clemens Ladisch
2016-03-11 23:07 ` Michal Nazarewicz
2016-03-14 16:00 ` Felipe Ferreri Tonello
2016-03-15 9:48 ` Clemens Ladisch
2016-03-30 10:51 ` Felipe Balbi
2016-03-30 12:33 ` Michal Nazarewicz
2016-04-01 9:25 ` Felipe Ferreri Tonello [this message]
2016-04-01 10:22 ` Felipe Balbi
2016-04-01 14:52 ` Felipe Ferreri Tonello
2016-04-04 10:46 ` Felipe Balbi
2016-04-04 11:33 ` Felipe Ferreri Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE3E90.9020305@felipetonello.com \
--to=eu@felipetonello.com \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.