From: Clemens Ladisch <clemens@ladisch.de>
To: Felipe Ferreri Tonello <eu@felipetonello.com>,
Michal Nazarewicz <mina86@mina86.com>,
linux-usb@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
Robert Baldyga <r.baldyga@samsung.com>
Subject: Re: [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize
Date: Tue, 15 Mar 2016 10:48:34 +0100 [thread overview]
Message-ID: <56E7DA72.1090109@ladisch.de> (raw)
In-Reply-To: <56E6E00C.6070907@felipetonello.com>
Felipe Ferreri Tonello wrote:
> On 11/03/16 23:07, Michal Nazarewicz wrote:
>> I’m also wondering whether it would be beneficial to get rid of buflen
>> all together and use wMaxPacketSie for in endpoints as well? Is that
>> feasible?
>
> Yes, we could just remove the buflen parameter.
>
> The only scenario where I can see buflen been "useful" is if the user
> wants to have a smaller buffer size for the OUT endpoint. Should we
> support this case or not?
Splitting data into multiple packets would not make sense from
a performance perspective. The only possible reason would be to work
around a (theoretical) bug in some host software that does not handle
larger buffers, but there aren't that many host implementations, and I
am not aware of any with such a bug.
Regards,
Clemens
next prev parent reply other threads:[~2016-03-15 9:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 19:39 [PATCH] usb: gadget: f_midi: Fixed a bug when buflen was smaller than wMaxPacketSize Felipe F. Tonello
2016-03-09 22:43 ` Steve Calfee
2016-03-10 9:23 ` Felipe Ferreri Tonello
2016-03-11 8:44 ` Clemens Ladisch
2016-03-11 23:07 ` Michal Nazarewicz
2016-03-14 16:00 ` Felipe Ferreri Tonello
2016-03-15 9:48 ` Clemens Ladisch [this message]
2016-03-30 10:51 ` Felipe Balbi
2016-03-30 12:33 ` Michal Nazarewicz
2016-04-01 9:25 ` Felipe Ferreri Tonello
2016-04-01 10:22 ` Felipe Balbi
2016-04-01 14:52 ` Felipe Ferreri Tonello
2016-04-04 10:46 ` Felipe Balbi
2016-04-04 11:33 ` Felipe Ferreri Tonello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E7DA72.1090109@ladisch.de \
--to=clemens@ladisch.de \
--cc=balbi@kernel.org \
--cc=eu@felipetonello.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mina86@mina86.com \
--cc=r.baldyga@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.