From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
rutu.shah.26@gmail.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com,
jasowang@redhat.com, mark.cave-ayland@ilande.co.uk,
lcapitulino@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org,
agraf@suse.de, samuel.thibault@ens-lyon.org, balrogg@gmail.com,
alistair.francis@xilinx.com, qemu-arm@nongnu.org,
stefanha@redhat.com, cornelia.huck@de.ibm.com, jsnow@redhat.com,
rth@twiddle.net, kwolf@redhat.com, armbru@redhat.com,
blauwirbel@gmail.co, qemu-ppc@nongnu.org, imammedo@redhat.com
Subject: Re: [Qemu-arm] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
Date: Fri, 11 Mar 2016 13:12:25 +0100 [thread overview]
Message-ID: <56E2B629.7080405@de.ibm.com> (raw)
In-Reply-To: <56E2B4EA.4050305@redhat.com>
On 03/11/2016 01:07 PM, Paolo Bonzini wrote:
>
>
> On 11/03/2016 12:44, Christian Borntraeger wrote:
>>> - s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec();
>>>> + s->tick_offset_vmstate = s->tick_offset + delta / NANOSECONDS_PER_SECOND;
>> [...]
>>
>> While technically correct, I do not like these changes. The interfaces expect "ticks",
>> and the fact that this happens to be a nanosecond does not help regarding
>> readability.
>
> Actually, I think usage of "tick" in this file is just for historical
> reasons.
So in essence the patch is ok and we should try to get rid of the "tick" word in future
patches?
Christian
WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
rutu.shah.26@gmail.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com,
jasowang@redhat.com, mark.cave-ayland@ilande.co.uk,
lcapitulino@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org,
agraf@suse.de, samuel.thibault@ens-lyon.org, balrogg@gmail.com,
alistair.francis@xilinx.com, qemu-arm@nongnu.org,
stefanha@redhat.com, cornelia.huck@de.ibm.com, rth@twiddle.net,
kwolf@redhat.com, crosthwaite.peter@gmail.com, armbru@redhat.com,
blauwirbel@gmail.co, qemu-ppc@nongnu.org, imammedo@redhat.com
Subject: Re: [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
Date: Fri, 11 Mar 2016 13:12:25 +0100 [thread overview]
Message-ID: <56E2B629.7080405@de.ibm.com> (raw)
In-Reply-To: <56E2B4EA.4050305@redhat.com>
On 03/11/2016 01:07 PM, Paolo Bonzini wrote:
>
>
> On 11/03/2016 12:44, Christian Borntraeger wrote:
>>> - s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec();
>>>> + s->tick_offset_vmstate = s->tick_offset + delta / NANOSECONDS_PER_SECOND;
>> [...]
>>
>> While technically correct, I do not like these changes. The interfaces expect "ticks",
>> and the fact that this happens to be a nanosecond does not help regarding
>> readability.
>
> Actually, I think usage of "tick" in this file is just for historical
> reasons.
So in essence the patch is ok and we should try to get rid of the "tick" word in future
patches?
Christian
WARNING: multiple messages have this Message-ID (diff)
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Paolo Bonzini <pbonzini@redhat.com>,
rutu.shah.26@gmail.com, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, kvm@vger.kernel.org, mst@redhat.com,
jasowang@redhat.com, mark.cave-ayland@ilande.co.uk,
lcapitulino@redhat.com, kraxel@redhat.com, qemu-block@nongnu.org,
agraf@suse.de, samuel.thibault@ens-lyon.org,
alistair.francis@xilinx.com, qemu-arm@nongnu.org,
stefanha@redhat.com, cornelia.huck@de.ibm.com, jsnow@redhat.com,
rth@twiddle.net, kwolf@redhat.com, crosthwaite.peter@gmail.com,
armbru@redhat.com, blauwirbel@gmail.co, qemu-ppc@nongnu.org,
imammedo@redhat.com
Subject: Re: [Qemu-devel] [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com>
Date: Fri, 11 Mar 2016 13:12:25 +0100 [thread overview]
Message-ID: <56E2B629.7080405@de.ibm.com> (raw)
In-Reply-To: <56E2B4EA.4050305@redhat.com>
On 03/11/2016 01:07 PM, Paolo Bonzini wrote:
>
>
> On 11/03/2016 12:44, Christian Borntraeger wrote:
>>> - s->tick_offset_vmstate = s->tick_offset + delta / get_ticks_per_sec();
>>>> + s->tick_offset_vmstate = s->tick_offset + delta / NANOSECONDS_PER_SECOND;
>> [...]
>>
>> While technically correct, I do not like these changes. The interfaces expect "ticks",
>> and the fact that this happens to be a nanosecond does not help regarding
>> readability.
>
> Actually, I think usage of "tick" in this file is just for historical
> reasons.
So in essence the patch is ok and we should try to get rid of the "tick" word in future
patches?
Christian
next prev parent reply other threads:[~2016-03-11 12:12 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-10 19:30 [PATCH] Replacing (and removing) get_ticks_per_sec() function with NANOSECONDS_PER_SECOND Signed-off-by: Rutuja Shah <rutu.shah.26@gmail.com> rutu.shah.26
2016-03-10 19:30 ` [Qemu-devel] " rutu.shah.26
2016-03-10 21:10 ` [Qemu-arm] " Eric Blake
2016-03-10 21:10 ` Eric Blake
2016-03-10 21:10 ` Eric Blake
2016-03-11 6:57 ` rutuja shah
2016-03-11 6:57 ` rutuja shah
2016-03-11 6:57 ` rutuja shah
2016-03-11 11:01 ` Stefan Hajnoczi
2016-03-11 11:01 ` [Qemu-devel] " Stefan Hajnoczi
2016-03-11 11:01 ` Stefan Hajnoczi
2016-03-11 11:44 ` Christian Borntraeger
2016-03-11 11:44 ` [Qemu-devel] " Christian Borntraeger
2016-03-11 11:44 ` Christian Borntraeger
2016-03-11 12:07 ` Paolo Bonzini
2016-03-11 12:07 ` [Qemu-devel] " Paolo Bonzini
2016-03-11 12:12 ` Christian Borntraeger [this message]
2016-03-11 12:12 ` Christian Borntraeger
2016-03-11 12:12 ` Christian Borntraeger
2016-03-11 12:26 ` Paolo Bonzini
2016-03-11 12:26 ` [Qemu-devel] " Paolo Bonzini
2016-03-11 13:22 ` Christian Borntraeger
2016-03-11 13:22 ` [Qemu-devel] " Christian Borntraeger
2016-03-11 13:22 ` Christian Borntraeger
2016-03-12 16:20 ` [Qemu-arm] " rutuja shah
2016-03-12 16:20 ` [Qemu-devel] " rutuja shah
2016-03-12 16:20 ` rutuja shah
2016-03-15 10:08 ` [Qemu-ppc] " Laurent Vivier
2016-03-15 10:08 ` [Qemu-devel] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E2B629.7080405@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=alistair.francis@xilinx.com \
--cc=armbru@redhat.com \
--cc=balrogg@gmail.com \
--cc=blauwirbel@gmail.co \
--cc=cornelia.huck@de.ibm.com \
--cc=imammedo@redhat.com \
--cc=jasowang@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=rth@twiddle.net \
--cc=rutu.shah.26@gmail.com \
--cc=samuel.thibault@ens-lyon.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.