From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
To: Maarten Brock <m.brock@vanmierlo.com>, linux-serial@vger.kernel.org
Cc: Thomas Gleixner <tglx@linutronix.de>,
Josh Cartwright <joshc@ni.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-rt-users@vger.kernel.org,
Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling
Date: Mon, 14 Mar 2016 07:17:51 +0100 [thread overview]
Message-ID: <56E6578F.6000907@prevas.dk> (raw)
In-Reply-To: <20160313200558.06543fce@kerio.vanmierlo.com>
On 2016-03-13 20:05, Maarten Brock wrote:
> I also wonder why this driver doesn't use threaded interrupts, just like the
> MAX310x driver it is based upon.
>
> Maarten
Me too.. :-) But both I and Sebastian Andrzej Siewior have proposed a
PATCH for that but it was turned down.
>
>
>> This driver should use a threaded interrupt instead of trying to emulate it
>> via dis/enable_irq and a worker thread.
>>
>> Then you simply call c16is7xx_port_irq() right from the interrupt routine
>> and the core code deals with the interrupt mask/unmask automatically.
>>
>> Thanks,
>>
>> tglx
Remember not to top post :-) and use a proper mail client that uses
In-Reply-To...
/Sean
WARNING: multiple messages have this Message-ID (diff)
From: "Sean Nyekjær" <sean.nyekjaer@prevas.dk>
To: Maarten Brock <m.brock@vanmierlo.com>, <linux-serial@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Josh Cartwright <joshc@ni.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
<linux-rt-users@vger.kernel.org>,
Jon Ringle <jringle@gridpoint.com>
Subject: Re: [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling
Date: Mon, 14 Mar 2016 07:17:51 +0100 [thread overview]
Message-ID: <56E6578F.6000907@prevas.dk> (raw)
In-Reply-To: <20160313200558.06543fce@kerio.vanmierlo.com>
On 2016-03-13 20:05, Maarten Brock wrote:
> I also wonder why this driver doesn't use threaded interrupts, just like the
> MAX310x driver it is based upon.
>
> Maarten
Me too.. :-) But both I and Sebastian Andrzej Siewior have proposed a
PATCH for that but it was turned down.
>
>
>> This driver should use a threaded interrupt instead of trying to emulate it
>> via dis/enable_irq and a worker thread.
>>
>> Then you simply call c16is7xx_port_irq() right from the interrupt routine
>> and the core code deals with the interrupt mask/unmask automatically.
>>
>> Thanks,
>>
>> tglx
Remember not to top post :-) and use a proper mail client that uses
In-Reply-To...
/Sean
next prev parent reply other threads:[~2016-03-14 6:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-13 19:05 [PATCH] tty: serial: sc16is7xx: implemented our own oneshot-like handling Maarten Brock
2016-03-14 6:17 ` Sean Nyekjær [this message]
2016-03-14 6:17 ` Sean Nyekjær
-- strict thread matches above, loose matches on Subject: below --
2016-03-11 10:34 Sean Nyekjaer
2016-03-11 10:34 ` Sean Nyekjaer
2016-03-11 10:36 ` Sean Nyekjær
2016-03-11 10:36 ` Sean Nyekjær
2016-03-11 11:21 ` Sebastian Andrzej Siewior
2016-03-11 11:29 ` Sean Nyekjær
2016-03-11 11:29 ` Sean Nyekjær
2016-03-11 11:33 ` Sean Nyekjær
2016-03-11 11:33 ` Sean Nyekjær
2016-03-11 16:43 ` Greg Kroah-Hartman
2016-03-13 10:25 ` Thomas Gleixner
2016-03-14 6:21 ` Sean Nyekjær
2016-03-14 6:21 ` Sean Nyekjær
2016-03-14 8:48 ` Thomas Gleixner
2016-03-14 23:13 ` Jakub Kiciński
2016-03-14 23:13 ` Jakub Kiciński
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56E6578F.6000907@prevas.dk \
--to=sean.nyekjaer@prevas.dk \
--cc=gregkh@linuxfoundation.org \
--cc=joshc@ni.com \
--cc=jringle@gridpoint.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=m.brock@vanmierlo.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.