From: shankerd@codeaurora.org (Shanker Donthineni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] irqchip/gicv3-its: Don't allow devices whose ID is outside range
Date: Thu, 17 Mar 2016 12:14:18 -0500 [thread overview]
Message-ID: <56EAE5EA.2060300@codeaurora.org> (raw)
In-Reply-To: <56EACE85.4090603@arm.com>
Hi Marc,
Sorry, absolutely It was my mistake sending the same patch second time.
On 03/17/2016 10:34 AM, Marc Zyngier wrote:
> On 17/03/16 15:18, Shanker Donthineni wrote:
>> We are not checking whether the requested device identifier fits into
>> the device table memory or not. The function its_create_device()
>> assumes that enough memory has been allocated for whole DevID space
>> (reported by ITS_TYPER.Devbits) during the ITS probe() and continues
>> to initialize ITS hardware.
>>
>> This assumption is not perfect, sometimes we reduce memory size either
>> because of its size crossing MAX_ORDER-1 or BASERn max size limit. The
>> MAPD command fails if 'Device ID' is outside of device table range.
>>
>> Add a simple validation check to avoid MAPD failures since we are
>> not handling ITS command errors. This change also helps to return an
>> error -ENOMEM instead of success to caller.
>>
>> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> Is there any difference between this patch and the one you posted on
> March 10th?
>
> Thanks,
>
> M.
--
Shanker Donthineni
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: Shanker Donthineni <shankerd@codeaurora.org>
To: Marc Zyngier <marc.zyngier@arm.com>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Vikram Sethi <vikrams@codeaurora.org>,
Eric Auger <eric.auger@linaro.org>
Subject: Re: [PATCH v4] irqchip/gicv3-its: Don't allow devices whose ID is outside range
Date: Thu, 17 Mar 2016 12:14:18 -0500 [thread overview]
Message-ID: <56EAE5EA.2060300@codeaurora.org> (raw)
In-Reply-To: <56EACE85.4090603@arm.com>
Hi Marc,
Sorry, absolutely It was my mistake sending the same patch second time.
On 03/17/2016 10:34 AM, Marc Zyngier wrote:
> On 17/03/16 15:18, Shanker Donthineni wrote:
>> We are not checking whether the requested device identifier fits into
>> the device table memory or not. The function its_create_device()
>> assumes that enough memory has been allocated for whole DevID space
>> (reported by ITS_TYPER.Devbits) during the ITS probe() and continues
>> to initialize ITS hardware.
>>
>> This assumption is not perfect, sometimes we reduce memory size either
>> because of its size crossing MAX_ORDER-1 or BASERn max size limit. The
>> MAPD command fails if 'Device ID' is outside of device table range.
>>
>> Add a simple validation check to avoid MAPD failures since we are
>> not handling ITS command errors. This change also helps to return an
>> error -ENOMEM instead of success to caller.
>>
>> Signed-off-by: Shanker Donthineni <shankerd@codeaurora.org>
> Is there any difference between this patch and the one you posted on
> March 10th?
>
> Thanks,
>
> M.
--
Shanker Donthineni
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-03-17 17:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-17 15:18 [PATCH v4] irqchip/gicv3-its: Don't allow devices whose ID is outside range Shanker Donthineni
2016-03-17 15:18 ` Shanker Donthineni
2016-03-17 15:34 ` Marc Zyngier
2016-03-17 15:34 ` Marc Zyngier
2016-03-17 17:14 ` Shanker Donthineni [this message]
2016-03-17 17:14 ` Shanker Donthineni
-- strict thread matches above, loose matches on Subject: below --
2016-03-10 4:10 Shanker Donthineni
2016-03-10 4:10 ` Shanker Donthineni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56EAE5EA.2060300@codeaurora.org \
--to=shankerd@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.