[PATCH 1/2] gnome-bluetooth: inherit gobject-introspection class

[PATCH 1/2] gnome-bluetooth: inherit gobject-introspection class

[Alexander Kanavin]

This fixes introspection support.

Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
---
 meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb b/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb
index 77e9a15..b3058e8 100644
--- a/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb
+++ b/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb
@@ -11,7 +11,7 @@ SECTION = "x11/gnome"
 DEPENDS = "systemd gtk+3 libnotify libcanberra"
 DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}"
 
-inherit gnomebase gtk-icon-cache distro_features_check
+inherit gnomebase gtk-icon-cache distro_features_check gobject-introspection
 REQUIRED_DISTRO_FEATURES = "systemd"
 
 SRC_URI[archive.md5sum] = "75d09c924468ec0c687f9ab3acf7f113"
-- 
2.7.0

[PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev

[Alexander Kanavin]

Now we have an up to date standalone libudev (via eudev),
so systemd is no longer required.

Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
---
 meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb b/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb
index b3058e8..984dad5 100644
--- a/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb
+++ b/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb
@@ -6,13 +6,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
 
 SECTION = "x11/gnome"
 
-# systemd is needed because it has a necessary version of libudev
-# Effectively this means that systemd must be in DISTRO_FEATURES
-DEPENDS = "systemd gtk+3 libnotify libcanberra"
+DEPENDS = "udev gtk+3 libnotify libcanberra"
 DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}"
 
 inherit gnomebase gtk-icon-cache distro_features_check gobject-introspection
-REQUIRED_DISTRO_FEATURES = "systemd"
 
 SRC_URI[archive.md5sum] = "75d09c924468ec0c687f9ab3acf7f113"
 SRC_URI[archive.sha256sum] = "d8df073c331df0f97261869fb77ffcdbf4e3e4eaf460d3c3ed2b16e03d9c5398"
-- 
2.7.0

Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev

[Alexander Kanavin]

On 03/21/2016 04:50 PM, Martin Jansa wrote:

>>   inherit gnomebase gtk-icon-cache distro_features_check gobject-introspection
>
> So you can remove distro_features_check inherit as well, right?

Yeah, I guess. Feel free to amend.


Alex

Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 1836 bytes --]

On Mon, Mar 21, 2016 at 03:54:52PM +0200, Alexander Kanavin wrote:
> Now we have an up to date standalone libudev (via eudev),
> so systemd is no longer required.
> 
> Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
> ---
>  meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb b/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb
> index b3058e8..984dad5 100644
> --- a/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb
> +++ b/meta-gnome/recipes-gnome/gnome-bluetooth/gnome-bluetooth_3.18.2.bb
> @@ -6,13 +6,10 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=eb723b61539feef013de476e68b5c50a \
>  
>  SECTION = "x11/gnome"
>  
> -# systemd is needed because it has a necessary version of libudev
> -# Effectively this means that systemd must be in DISTRO_FEATURES
> -DEPENDS = "systemd gtk+3 libnotify libcanberra"
> +DEPENDS = "udev gtk+3 libnotify libcanberra"
>  DEPENDS += "${@bb.utils.contains('DISTRO_FEATURES','bluez5','bluez5','bluez4',d)}"
>  
>  inherit gnomebase gtk-icon-cache distro_features_check gobject-introspection

So you can remove distro_features_check inherit as well, right?

> -REQUIRED_DISTRO_FEATURES = "systemd"
>  
>  SRC_URI[archive.md5sum] = "75d09c924468ec0c687f9ab3acf7f113"
>  SRC_URI[archive.sha256sum] = "d8df073c331df0f97261869fb77ffcdbf4e3e4eaf460d3c3ed2b16e03d9c5398"
> -- 
> 2.7.0
> 
> -- 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev

[Paul Eggleton]

On Mon, 21 Mar 2016 16:45:02 Alexander Kanavin wrote:
> On 03/21/2016 04:50 PM, Martin Jansa wrote:
> >>   inherit gnomebase gtk-icon-cache distro_features_check
> >>   gobject-introspection> 
> >
> > So you can remove distro_features_check inherit as well, right?
> 
> Yeah, I guess. Feel free to amend.

The reviewer is asking you to do that, although perhaps not in so many words. 
Can you, please?

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev

[Martin Jansa]

[-- Attachment #1: Type: text/plain, Size: 666 bytes --]

On Tue, Mar 22, 2016 at 09:43:00AM +1300, Paul Eggleton wrote:
> On Mon, 21 Mar 2016 16:45:02 Alexander Kanavin wrote:
> > On 03/21/2016 04:50 PM, Martin Jansa wrote:
> > >>   inherit gnomebase gtk-icon-cache distro_features_check
> > >>   gobject-introspection> 
> > >
> > > So you can remove distro_features_check inherit as well, right?
> > 
> > Yeah, I guess. Feel free to amend.
> 
> The reviewer is asking you to do that, although perhaps not in so many words. 
> Can you, please?

Normally I agree with Paul, in this case I made exception and amended it
myself when chrry-picking.

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa@gmail.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 188 bytes --]

Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev

[alexander.kanavin]

>> > So you can remove distro_features_check inherit as well, right?
>>
>> Yeah, I guess. Feel free to amend.
>
> The reviewer is asking you to do that, although perhaps not in so many
> words.
> Can you, please?

I don't believe I should, if the review consists of a single trivial
nitpick from the person who also does the actual commits to master. It's
less friction and noise for both of us this way.

Alex

Re: [PATCH 2/2] gnome-bluetooth: replace systemd dependency with udev

[Paul Eggleton]

On Tue, 22 Mar 2016 18:25:25 alexander.kanavin@linux.intel.com wrote:
> >> > So you can remove distro_features_check inherit as well, right?
> >> 
> >> Yeah, I guess. Feel free to amend.
> > 
> > The reviewer is asking you to do that, although perhaps not in so many
> > words.
> > Can you, please?
> 
> I don't believe I should, if the review consists of a single trivial
> nitpick from the person who also does the actual commits to master. It's
> less friction and noise for both of us this way.

On the other hand, giving more work to our maintainers is not a good strategy 
if you want them to stay around.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre