From: Mason <slash.tmp@free.fr>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm <linux-pm@vger.kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Javi Merino <javi.merino@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Mans Rullgard <mans@mansr.com>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v3] thermal: add temperature sensor support for tango SoC
Date: Thu, 24 Mar 2016 18:56:03 +0100 [thread overview]
Message-ID: <56F42A33.108@free.fr> (raw)
In-Reply-To: <56F3DB1E.9050605@free.fr>
On 24/03/2016 13:18, Mason wrote:
> + if (temp_above_thresh(base, idx)) {
> + /* Downward linear search */
> + while (idx > IDX_MIN && temp_above_thresh(base, --idx))
> + cpu_relax();
> + } else {
> + /* Upward linear search */
> + while (idx < IDX_MAX && !temp_above_thresh(base, ++idx))
> + cpu_relax();
> + idx = idx - 1;
> + }
That's wrong, I mixed up the two branches.
When temp is above thresh, we should search upward.
I'll send v4 in a few days (needs more testing).
Regards.
next prev parent reply other threads:[~2016-03-24 17:56 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 16:49 [RFC] Temperature sensor driver (tango) Mason
2016-03-04 15:52 ` [PATCH v2] thermal: add temperature sensor support for tango SoC Mason
2016-03-08 21:48 ` Eduardo Valentin
2016-03-21 10:31 ` Mason
2016-03-24 12:18 ` [PATCH v3] " Mason
2016-03-24 17:56 ` Mason [this message]
2016-03-27 20:35 ` [PATCH v4] " Mason
2016-03-28 11:49 ` [PATCH v5] " Mason
2016-03-29 2:00 ` Eduardo Valentin
2016-03-29 18:48 ` Mason
2016-03-30 0:05 ` Eduardo Valentin
2016-03-30 15:18 ` Mason
2016-03-31 20:16 ` [PATCH v6] " Mason
2016-04-01 1:52 ` Eduardo Valentin
2016-04-04 11:48 ` Mason
2016-04-04 11:49 ` [PATCH v7] " Mason
2016-04-05 2:05 ` Eduardo Valentin
2016-04-05 14:58 ` Mason
2016-04-06 15:48 ` Eduardo Valentin
2016-04-06 15:51 ` Eduardo Valentin
2016-04-13 20:28 ` Mason
2016-04-19 14:21 ` [PATCH v8 1/2] " Mason
2016-04-19 14:49 ` Mason
2016-04-19 14:32 ` [PATCH v8 2/2] ARM: dts: tango4: Initial thermal support Mason
2016-04-20 22:45 ` Eduardo Valentin
2016-04-01 1:48 ` [PATCH v5] thermal: add temperature sensor support for tango SoC Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F42A33.108@free.fr \
--to=slash.tmp@free.fr \
--cc=arnd@arndb.de \
--cc=edubezval@gmail.com \
--cc=javi.merino@arm.com \
--cc=linux-pm@vger.kernel.org \
--cc=mans@mansr.com \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.