From: Mason <slash.tmp@free.fr>
To: Eduardo Valentin <edubezval@gmail.com>
Cc: linux-pm <linux-pm@vger.kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
Javi Merino <javi.merino@arm.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
Rob Herring <robh@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, arm-soc <arm@kernel.org>
Subject: Re: [PATCH v7] thermal: add temperature sensor support for tango SoC
Date: Wed, 13 Apr 2016 22:28:18 +0200 [thread overview]
Message-ID: <570EABE2.7010609@free.fr> (raw)
In-Reply-To: <20160406155155.GB326@localhost.localdomain>
On 06/04/2016 17:51, Eduardo Valentin wrote:
> On Mon, Apr 04, 2016 at 01:49:44PM +0200, Mason wrote:
>
>> + priv->zone = thermal_zone_of_sensor_register(&pdev->dev, 0, priv, &ops);
>
> I would still prefer you use the devm_ version.
In the .remove callback, I call thermal_zone_of_sensor_unregister()
and then the sensor is powered down.
I don't know when the devm garbage collector kicks in.
Is it before or after calling .remove?
(I suspect it is *after*, when the driver is detached.)
I can't power the sensor down until it has been "unregistered".
If .get_temp is called with the sensor powered down, the HW
will return garbage, which might have weird consequences.
The documentation states
https://www.kernel.org/doc/Documentation/thermal/sysfs-api.txt
devm_thermal_zone_of_sensor_register()
"The benefit of using this interface to register sensor is that it
is not require to explicitly call thermal_zone_of_sensor_unregister()"
So I can still explicitly call thermal_zone_of_sensor_unregister?
What is the point of devm_thermal_zone_of_sensor_unregister?
Regards.
next prev parent reply other threads:[~2016-04-13 20:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-01 16:49 [RFC] Temperature sensor driver (tango) Mason
2016-03-04 15:52 ` [PATCH v2] thermal: add temperature sensor support for tango SoC Mason
2016-03-08 21:48 ` Eduardo Valentin
2016-03-21 10:31 ` Mason
2016-03-24 12:18 ` [PATCH v3] " Mason
2016-03-24 17:56 ` Mason
2016-03-27 20:35 ` [PATCH v4] " Mason
2016-03-28 11:49 ` [PATCH v5] " Mason
2016-03-29 2:00 ` Eduardo Valentin
2016-03-29 18:48 ` Mason
2016-03-30 0:05 ` Eduardo Valentin
2016-03-30 15:18 ` Mason
2016-03-31 20:16 ` [PATCH v6] " Mason
2016-04-01 1:52 ` Eduardo Valentin
2016-04-04 11:48 ` Mason
2016-04-04 11:49 ` [PATCH v7] " Mason
2016-04-05 2:05 ` Eduardo Valentin
2016-04-05 14:58 ` Mason
2016-04-06 15:48 ` Eduardo Valentin
2016-04-06 15:51 ` Eduardo Valentin
2016-04-13 20:28 ` Mason [this message]
2016-04-19 14:21 ` [PATCH v8 1/2] " Mason
2016-04-19 14:49 ` Mason
2016-04-19 14:32 ` [PATCH v8 2/2] ARM: dts: tango4: Initial thermal support Mason
2016-04-20 22:45 ` Eduardo Valentin
2016-04-01 1:48 ` [PATCH v5] thermal: add temperature sensor support for tango SoC Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570EABE2.7010609@free.fr \
--to=slash.tmp@free.fr \
--cc=arm@kernel.org \
--cc=edubezval@gmail.com \
--cc=javi.merino@arm.com \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.