From: Mark yao <mark.yao@rock-chips.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>, linux-kernel@vger.kernel.org
Cc: linux-rockchip@lists.infradead.org,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: vop: Don't reject empty modesets
Date: Mon, 28 Mar 2016 14:40:05 +0800 [thread overview]
Message-ID: <56F8D1C5.6060504@rock-chips.com> (raw)
In-Reply-To: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com>
On 2016年03月18日 19:22, Tomeu Vizoso wrote:
> So that when DRM_IOCTL_MODE_SETCRTC is called without a FB nor mode, the
> CRTC gets disabled.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Link: http://lkml.kernel.org/g/CAAObsKAv+05ih5U+=4kic_NsjGMhfxYheHR8xXXmacZs+p5SHw@mail.gmail.com
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index fd370548d7d7..5e57f5b2e4b0 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -885,9 +885,6 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
> {
> struct vop *vop = to_vop(crtc);
>
> - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0)
> - return false;
> -
> adjusted_mode->clock =
> clk_round_rate(vop->dclk, mode->clock * 1000) / 1000;
>
Applied to my drm-fixes, Thanks.
--
Ｍark Yao
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: mark.yao@rock-chips.com (Mark yao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: vop: Don't reject empty modesets
Date: Mon, 28 Mar 2016 14:40:05 +0800 [thread overview]
Message-ID: <56F8D1C5.6060504@rock-chips.com> (raw)
In-Reply-To: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com>
On 2016?03?18? 19:22, Tomeu Vizoso wrote:
> So that when DRM_IOCTL_MODE_SETCRTC is called without a FB nor mode, the
> CRTC gets disabled.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Link: http://lkml.kernel.org/g/CAAObsKAv+05ih5U+=4kic_NsjGMhfxYheHR8xXXmacZs+p5SHw at mail.gmail.com
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index fd370548d7d7..5e57f5b2e4b0 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -885,9 +885,6 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
> {
> struct vop *vop = to_vop(crtc);
>
> - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0)
> - return false;
> -
> adjusted_mode->clock =
> clk_round_rate(vop->dclk, mode->clock * 1000) / 1000;
>
Applied to my drm-fixes, Thanks.
--
?ark Yao
WARNING: multiple messages have this Message-ID (diff)
From: Mark yao <mark.yao@rock-chips.com>
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>, linux-kernel@vger.kernel.org
Cc: David Airlie <airlied@linux.ie>, Heiko Stuebner <heiko@sntech.de>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: vop: Don't reject empty modesets
Date: Mon, 28 Mar 2016 14:40:05 +0800 [thread overview]
Message-ID: <56F8D1C5.6060504@rock-chips.com> (raw)
In-Reply-To: <1458300123-6397-1-git-send-email-tomeu.vizoso@collabora.com>
On 2016年03月18日 19:22, Tomeu Vizoso wrote:
> So that when DRM_IOCTL_MODE_SETCRTC is called without a FB nor mode, the
> CRTC gets disabled.
>
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Link: http://lkml.kernel.org/g/CAAObsKAv+05ih5U+=4kic_NsjGMhfxYheHR8xXXmacZs+p5SHw@mail.gmail.com
> ---
> drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> index fd370548d7d7..5e57f5b2e4b0 100644
> --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c
> @@ -885,9 +885,6 @@ static bool vop_crtc_mode_fixup(struct drm_crtc *crtc,
> {
> struct vop *vop = to_vop(crtc);
>
> - if (adjusted_mode->htotal == 0 || adjusted_mode->vtotal == 0)
> - return false;
> -
> adjusted_mode->clock =
> clk_round_rate(vop->dclk, mode->clock * 1000) / 1000;
>
Applied to my drm-fixes, Thanks.
--
Ｍark Yao
next prev parent reply other threads:[~2016-03-28 6:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 11:22 [PATCH] drm/rockchip: vop: Don't reject empty modesets Tomeu Vizoso
2016-03-18 11:22 ` Tomeu Vizoso
2016-03-18 11:22 ` Tomeu Vizoso
2016-03-28 6:40 ` Mark yao [this message]
2016-03-28 6:40 ` Mark yao
2016-03-28 6:40 ` Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F8D1C5.6060504@rock-chips.com \
--to=mark.yao@rock-chips.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.