From: sergei.shtylyov@cogentembedded.com (Sergei Shtylyov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP registers.
Date: Mon, 28 Mar 2016 19:42:14 +0300 [thread overview]
Message-ID: <56F95EE6.1010403@cogentembedded.com> (raw)
In-Reply-To: <56F94772.7070009@lechnology.com>
Hello.
On 03/28/2016 06:02 PM, David Lechner wrote:
>>> +/* register offsets */
>>> +#define CFGCHIP_REG(n) (n * 4)
>>> +#define CFGCHIP0_REG CFGCHIP_REG(0)
>>> +#define CFGCHIP1_REG CFGCHIP_REG(1)
>>> +#define CFGCHIP2_REG CFGCHIP_REG(2)
>>> +#define CFGCHIP3_REG CFGCHIP_REG(3)
>>> +#define CFGCHIP4_REG CFGCHIP_REG(4)
>>
>> Why not just use CFGCHIP_REG(n) directly?
>
> I considered that, but I went this way because A) the TRM uses, for example,
> "CFGCHIP2", so I wanted to keep "CFGCHIP" and "2" together
I'd just drop the _REG suffix.
> and B) this tells
> you how many CFGCHIP registers there are, i.e. there is no CFGCHIP5_REG.
You can tell that in a comment. Having a parametrized macro and using it
to just #define more macros doesn't appeal to me at all...
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: David Lechner <david@lechnology.com>
Cc: petr@barix.com, David.Laight@ACULAB.COM,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Sekhar Nori <nsekhar@ti.com>, Kevin Hilman <khilman@kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>, Bin Liu <b-liu@ti.com>,
Lee Jones <lee.jones@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
"open list:USB SUBSYSTEM" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP registers.
Date: Mon, 28 Mar 2016 19:42:14 +0300 [thread overview]
Message-ID: <56F95EE6.1010403@cogentembedded.com> (raw)
In-Reply-To: <56F94772.7070009@lechnology.com>
Hello.
On 03/28/2016 06:02 PM, David Lechner wrote:
>>> +/* register offsets */
>>> +#define CFGCHIP_REG(n) (n * 4)
>>> +#define CFGCHIP0_REG CFGCHIP_REG(0)
>>> +#define CFGCHIP1_REG CFGCHIP_REG(1)
>>> +#define CFGCHIP2_REG CFGCHIP_REG(2)
>>> +#define CFGCHIP3_REG CFGCHIP_REG(3)
>>> +#define CFGCHIP4_REG CFGCHIP_REG(4)
>>
>> Why not just use CFGCHIP_REG(n) directly?
>
> I considered that, but I went this way because A) the TRM uses, for example,
> "CFGCHIP2", so I wanted to keep "CFGCHIP" and "2" together
I'd just drop the _REG suffix.
> and B) this tells
> you how many CFGCHIP registers there are, i.e. there is no CFGCHIP5_REG.
You can tell that in a comment. Having a parametrized macro and using it
to just #define more macros doesn't appeal to me at all...
MBR, Sergei
next prev parent reply other threads:[~2016-03-28 16:42 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 23:51 [PATCH v3 00/16] da8xx USB clocks David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` [PATCH v3 01/16] dt: davinci: use proper address after @ David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-25 13:29 ` Sergei Shtylyov
2016-03-25 13:29 ` Sergei Shtylyov
2016-03-25 13:29 ` Sergei Shtylyov
2016-03-25 15:13 ` Rob Herring
2016-03-25 15:13 ` Rob Herring
2016-03-25 15:13 ` Rob Herring
2016-03-25 16:36 ` Sergei Shtylyov
2016-03-25 16:36 ` Sergei Shtylyov
2016-03-25 16:36 ` Sergei Shtylyov
2016-03-25 15:14 ` Rob Herring
2016-03-25 15:14 ` Rob Herring
2016-03-25 15:14 ` Rob Herring
2016-04-11 8:19 ` Sekhar Nori
2016-04-11 8:19 ` Sekhar Nori
2016-04-11 8:19 ` Sekhar Nori
2016-03-24 23:51 ` [PATCH v3 02/16] mfd: da8xx-cfgchip: New header file for CFGCHIP registers David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-25 17:22 ` Sergei Shtylyov
2016-03-25 17:22 ` Sergei Shtylyov
2016-03-25 17:22 ` Sergei Shtylyov
2016-03-28 15:02 ` David Lechner
2016-03-28 15:02 ` David Lechner
2016-03-28 15:02 ` David Lechner
2016-03-28 16:42 ` Sergei Shtylyov [this message]
2016-03-28 16:42 ` Sergei Shtylyov
2016-04-11 8:23 ` Sekhar Nori
2016-04-11 8:23 ` Sekhar Nori
2016-04-11 8:23 ` Sekhar Nori
2016-03-24 23:51 ` [PATCH v3 03/16] ARM: davinici: da8xx: move usb code to new file David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-04-11 8:55 ` Sekhar Nori
2016-04-11 8:55 ` Sekhar Nori
2016-04-11 8:55 ` Sekhar Nori
2016-03-24 23:51 ` [PATCH v3 04/16] ARM: davinci: Move clock init after ioremap David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-04-11 9:14 ` Sekhar Nori
2016-04-11 9:14 ` Sekhar Nori
2016-04-11 9:14 ` Sekhar Nori
2016-03-24 23:51 ` [PATCH v3 05/16] ARM: davinci: add set_parent callback for mux clocks David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-04-11 10:40 ` Sekhar Nori
2016-04-11 10:40 ` Sekhar Nori
2016-04-11 10:40 ` Sekhar Nori
2016-03-24 23:51 ` [PATCH v3 06/16] ARM: davinci: da850: use clk->set_parent for async3 David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-04-11 10:49 ` Sekhar Nori
2016-04-11 10:49 ` Sekhar Nori
2016-04-11 10:49 ` Sekhar Nori
2016-03-24 23:51 ` [PATCH v3 07/16] ARM: davinci: da8xx: add usb phy clocks David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` [PATCH v3 08/16] dt-bindings: Add bindings for phy-da8xx-usb David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-25 15:04 ` Rob Herring
2016-03-25 15:04 ` Rob Herring
2016-03-24 23:51 ` [PATCH v3 09/16] phy: da8xx-usb: new driver for DA8xx SoC USB PHY David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-25 1:57 ` [PATCH] " David Lechner
2016-03-25 1:57 ` David Lechner
2016-03-25 1:57 ` David Lechner
2016-03-26 14:10 ` Sergei Shtylyov
2016-03-26 14:10 ` Sergei Shtylyov
2016-04-13 13:20 ` [PATCH v3 09/16] " Kishon Vijay Abraham I
2016-04-13 13:20 ` Kishon Vijay Abraham I
2016-04-13 13:20 ` Kishon Vijay Abraham I
2016-04-13 20:07 ` David Lechner
2016-04-13 20:07 ` David Lechner
2016-04-14 12:38 ` Kishon Vijay Abraham I
2016-04-14 12:38 ` Kishon Vijay Abraham I
2016-04-14 12:38 ` Kishon Vijay Abraham I
2016-03-24 23:51 ` [PATCH v3 10/16] ARM: davinci: da8xx: Add CFGCHIPn syscon platform declaration David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` [PATCH v3 11/16] ARM: davinci: da8xx: Add USB PHY " David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` [PATCH v3 12/16] ARM: dt: da850: Add cfgchip syscon node David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` [PATCH v3 13/16] ARM: dt: da850: Add usb phy node David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` [PATCH v3 14/16] usb: ohci-da8xx: Remove code that references mach David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` [PATCH v3 15/16] usb: musb: da8xx: Use devm in probe David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-31 22:21 ` Bin Liu
2016-03-31 22:21 ` Bin Liu
2016-03-31 22:21 ` Bin Liu
2016-03-31 22:28 ` David Lechner
2016-03-31 22:28 ` David Lechner
2016-03-31 22:28 ` David Lechner
2016-04-01 14:56 ` Bin Liu
2016-04-01 14:56 ` Bin Liu
2016-04-01 14:56 ` Bin Liu
2016-04-01 10:36 ` Sergei Shtylyov
2016-04-01 10:36 ` Sergei Shtylyov
2016-04-01 10:36 ` Sergei Shtylyov
2016-03-24 23:51 ` [PATCH v3 16/16] usb: musb: da8xx: Remove mach code David Lechner
2016-03-24 23:51 ` David Lechner
2016-03-24 23:51 ` David Lechner
2016-04-07 16:29 ` [PATCH v3 00/16] da8xx USB clocks David Lechner
2016-04-07 16:29 ` David Lechner
2016-04-07 16:29 ` David Lechner
2016-04-11 11:28 ` Sekhar Nori
2016-04-11 11:28 ` Sekhar Nori
2016-04-11 11:28 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F95EE6.1010403@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.