From: Bart Van Assche <bart.vanassche@sandisk.com>
To: James Bottomley <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: [PATCH 1/5] libiscsi: Unexport iscsi_eh_target_reset()
Date: Wed, 30 Mar 2016 11:26:46 -0700 [thread overview]
Message-ID: <56FC1A66.9090407@sandisk.com> (raw)
In-Reply-To: <56FC1A3B.4040704@sandisk.com>
Running "git grep -nHw iscsi_eh_target_reset" shows that this
function is only called from inside the drivers/scsi/libiscsi.c
source file. Hence unexport this function.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/libiscsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/libiscsi.c b/drivers/scsi/libiscsi.c
index 6bffd91..120150a 100644
--- a/drivers/scsi/libiscsi.c
+++ b/drivers/scsi/libiscsi.c
@@ -2423,7 +2423,7 @@ static void iscsi_prep_tgt_reset_pdu(struct scsi_cmnd *sc, struct iscsi_tm *hdr)
*
* This will attempt to send a warm target reset.
*/
-int iscsi_eh_target_reset(struct scsi_cmnd *sc)
+static int iscsi_eh_target_reset(struct scsi_cmnd *sc)
{
struct iscsi_cls_session *cls_session;
struct iscsi_session *session;
@@ -2495,7 +2495,6 @@ done:
mutex_unlock(&session->eh_mutex);
return rc;
}
-EXPORT_SYMBOL_GPL(iscsi_eh_target_reset);
/**
* iscsi_eh_recover_target - reset target and possibly the session
--
2.7.3
next prev parent reply other threads:[~2016-03-30 18:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 18:26 [PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code Bart Van Assche
2016-03-30 18:26 ` Bart Van Assche [this message]
2016-03-31 7:58 ` [PATCH 1/5] libiscsi: Unexport iscsi_eh_target_reset() Johannes Thumshirn
2016-03-30 18:27 ` [PATCH 2/5] libiscsi: Remove set-but-not-used variables Bart Van Assche
2016-03-31 7:59 ` Johannes Thumshirn
2016-03-30 18:27 ` [PATCH 3/5] scsi_transport_iscsi: " Bart Van Assche
2016-03-31 8:01 ` Johannes Thumshirn
2016-03-30 18:27 ` [PATCH 4/5] scsi_transport_iscsi: Unexport iscsi_is_flashnode_conn_dev() Bart Van Assche
2016-03-31 8:02 ` Johannes Thumshirn
2016-03-30 18:28 ` [PATCH 5/5] scsi_transport_iscsi: Declare local symbols static Bart Van Assche
2016-03-31 8:03 ` Johannes Thumshirn
2016-04-04 23:23 ` [PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC1A66.9090407@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.