From: Bart Van Assche <bart.vanassche@sandisk.com>
To: James Bottomley <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: [PATCH 5/5] scsi_transport_iscsi: Declare local symbols static
Date: Wed, 30 Mar 2016 11:28:11 -0700 [thread overview]
Message-ID: <56FC1ABB.8050501@sandisk.com> (raw)
In-Reply-To: <56FC1A3B.4040704@sandisk.com>
Avoid that building with W=1 causes gcc to report warnings about
symbols that have not been declared.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/scsi_transport_iscsi.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index dff7413..c169fa1 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -1009,7 +1009,7 @@ static void iscsi_flashnode_sess_release(struct device *dev)
kfree(fnode_sess);
}
-struct device_type iscsi_flashnode_sess_dev_type = {
+static struct device_type iscsi_flashnode_sess_dev_type = {
.name = "iscsi_flashnode_sess_dev_type",
.groups = iscsi_flashnode_sess_attr_groups,
.release = iscsi_flashnode_sess_release,
@@ -1195,13 +1195,13 @@ static void iscsi_flashnode_conn_release(struct device *dev)
kfree(fnode_conn);
}
-struct device_type iscsi_flashnode_conn_dev_type = {
+static struct device_type iscsi_flashnode_conn_dev_type = {
.name = "iscsi_flashnode_conn_dev_type",
.groups = iscsi_flashnode_conn_attr_groups,
.release = iscsi_flashnode_conn_release,
};
-struct bus_type iscsi_flashnode_bus;
+static struct bus_type iscsi_flashnode_bus;
int iscsi_flashnode_bus_match(struct device *dev,
struct device_driver *drv)
@@ -1212,7 +1212,7 @@ int iscsi_flashnode_bus_match(struct device *dev,
}
EXPORT_SYMBOL_GPL(iscsi_flashnode_bus_match);
-struct bus_type iscsi_flashnode_bus = {
+static struct bus_type iscsi_flashnode_bus = {
.name = "iscsi_flashnode",
.match = &iscsi_flashnode_bus_match,
};
--
2.7.3
next prev parent reply other threads:[~2016-03-30 18:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 18:26 [PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code Bart Van Assche
2016-03-30 18:26 ` [PATCH 1/5] libiscsi: Unexport iscsi_eh_target_reset() Bart Van Assche
2016-03-31 7:58 ` Johannes Thumshirn
2016-03-30 18:27 ` [PATCH 2/5] libiscsi: Remove set-but-not-used variables Bart Van Assche
2016-03-31 7:59 ` Johannes Thumshirn
2016-03-30 18:27 ` [PATCH 3/5] scsi_transport_iscsi: " Bart Van Assche
2016-03-31 8:01 ` Johannes Thumshirn
2016-03-30 18:27 ` [PATCH 4/5] scsi_transport_iscsi: Unexport iscsi_is_flashnode_conn_dev() Bart Van Assche
2016-03-31 8:02 ` Johannes Thumshirn
2016-03-30 18:28 ` Bart Van Assche [this message]
2016-03-31 8:03 ` [PATCH 5/5] scsi_transport_iscsi: Declare local symbols static Johannes Thumshirn
2016-04-04 23:23 ` [PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC1ABB.8050501@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.