From: Bart Van Assche <bart.vanassche@sandisk.com>
To: James Bottomley <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Mike Christie <michaelc@cs.wisc.edu>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: [PATCH 4/5] scsi_transport_iscsi: Unexport iscsi_is_flashnode_conn_dev()
Date: Wed, 30 Mar 2016 11:27:47 -0700 [thread overview]
Message-ID: <56FC1AA3.5040600@sandisk.com> (raw)
In-Reply-To: <56FC1A3B.4040704@sandisk.com>
The output of "git grep -nHw iscsi_is_flashnode_conn_dev" shows
that this function is only called from inside source file
drivers/scsi/scsi_transport_iscsi.c. Hence unexport this function.
Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
---
drivers/scsi/scsi_transport_iscsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
index 446781d..dff7413 100644
--- a/drivers/scsi/scsi_transport_iscsi.c
+++ b/drivers/scsi/scsi_transport_iscsi.c
@@ -1324,11 +1324,10 @@ EXPORT_SYMBOL_GPL(iscsi_create_flashnode_conn);
* 1 on success
* 0 on failure
*/
-int iscsi_is_flashnode_conn_dev(struct device *dev, void *data)
+static int iscsi_is_flashnode_conn_dev(struct device *dev, void *data)
{
return dev->bus == &iscsi_flashnode_bus;
}
-EXPORT_SYMBOL_GPL(iscsi_is_flashnode_conn_dev);
static int iscsi_destroy_flashnode_conn(struct iscsi_bus_flash_conn *fnode_conn)
{
--
2.7.3
next prev parent reply other threads:[~2016-03-30 18:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-30 18:26 [PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code Bart Van Assche
2016-03-30 18:26 ` [PATCH 1/5] libiscsi: Unexport iscsi_eh_target_reset() Bart Van Assche
2016-03-31 7:58 ` Johannes Thumshirn
2016-03-30 18:27 ` [PATCH 2/5] libiscsi: Remove set-but-not-used variables Bart Van Assche
2016-03-31 7:59 ` Johannes Thumshirn
2016-03-30 18:27 ` [PATCH 3/5] scsi_transport_iscsi: " Bart Van Assche
2016-03-31 8:01 ` Johannes Thumshirn
2016-03-30 18:27 ` Bart Van Assche [this message]
2016-03-31 8:02 ` [PATCH 4/5] scsi_transport_iscsi: Unexport iscsi_is_flashnode_conn_dev() Johannes Thumshirn
2016-03-30 18:28 ` [PATCH 5/5] scsi_transport_iscsi: Declare local symbols static Bart Van Assche
2016-03-31 8:03 ` Johannes Thumshirn
2016-04-04 23:23 ` [PATCH 0/5] Fix several static checker warnings reported against the iSCSI kernel code Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FC1AA3.5040600@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.