From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, jasowang@redhat.com
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak
Date: Thu, 31 Mar 2016 10:22:37 -0600 [thread overview]
Message-ID: <56FD4ECD.9040703@redhat.com> (raw)
In-Reply-To: <1459434536-28145-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On 03/31/2016 08:28 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
May want to add: regression introduced in commit 96a1616.
> ---
> net/net.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/net/net.c b/net/net.c
> index 594c3b8..3847a13 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev, Error **errp)
> }
>
> error_propagate(errp, err);
> + opts_visitor_cleanup(ov);
> return ret;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, jasowang@redhat.com
Subject: Re: [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak
Date: Thu, 31 Mar 2016 10:22:37 -0600 [thread overview]
Message-ID: <56FD4ECD.9040703@redhat.com> (raw)
In-Reply-To: <1459434536-28145-1-git-send-email-pbonzini@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On 03/31/2016 08:28 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
May want to add: regression introduced in commit 96a1616.
> ---
> net/net.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/net/net.c b/net/net.c
> index 594c3b8..3847a13 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev, Error **errp)
> }
>
> error_propagate(errp, err);
> + opts_visitor_cleanup(ov);
> return ret;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-03-31 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 14:28 [Qemu-trivial] [PATCH] net: fix OptsVisitor memory leak Paolo Bonzini
2016-03-31 14:28 ` [Qemu-devel] " Paolo Bonzini
2016-03-31 16:22 ` Eric Blake [this message]
2016-03-31 16:22 ` Eric Blake
2016-04-01 2:00 ` [Qemu-trivial] " Jason Wang
2016-04-01 2:00 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FD4ECD.9040703@redhat.com \
--to=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.