* [Qemu-trivial] [PATCH] net: fix OptsVisitor memory leak
@ 2016-03-31 14:28 ` Paolo Bonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2016-03-31 14:28 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, jasowang
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
net/net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/net.c b/net/net.c
index 594c3b8..3847a13 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev, Error **errp)
}
error_propagate(errp, err);
+ opts_visitor_cleanup(ov);
return ret;
}
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak
@ 2016-03-31 14:28 ` Paolo Bonzini
0 siblings, 0 replies; 6+ messages in thread
From: Paolo Bonzini @ 2016-03-31 14:28 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, jasowang
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
net/net.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/net.c b/net/net.c
index 594c3b8..3847a13 100644
--- a/net/net.c
+++ b/net/net.c
@@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev, Error **errp)
}
error_propagate(errp, err);
+ opts_visitor_cleanup(ov);
return ret;
}
--
2.5.5
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak
2016-03-31 14:28 ` [Qemu-devel] " Paolo Bonzini
@ 2016-03-31 16:22 ` Eric Blake
-1 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2016-03-31 16:22 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial, jasowang
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On 03/31/2016 08:28 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
May want to add: regression introduced in commit 96a1616.
> ---
> net/net.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/net/net.c b/net/net.c
> index 594c3b8..3847a13 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev, Error **errp)
> }
>
> error_propagate(errp, err);
> + opts_visitor_cleanup(ov);
> return ret;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak
@ 2016-03-31 16:22 ` Eric Blake
0 siblings, 0 replies; 6+ messages in thread
From: Eric Blake @ 2016-03-31 16:22 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: qemu-trivial, jasowang
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On 03/31/2016 08:28 AM, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
May want to add: regression introduced in commit 96a1616.
> ---
> net/net.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/net/net.c b/net/net.c
> index 594c3b8..3847a13 100644
> --- a/net/net.c
> +++ b/net/net.c
> @@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev, Error **errp)
> }
>
> error_propagate(errp, err);
> + opts_visitor_cleanup(ov);
> return ret;
> }
>
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak
2016-03-31 16:22 ` Eric Blake
@ 2016-04-01 2:00 ` Jason Wang
-1 siblings, 0 replies; 6+ messages in thread
From: Jason Wang @ 2016-04-01 2:00 UTC (permalink / raw)
To: Eric Blake, Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
On 04/01/2016 12:22 AM, Eric Blake wrote:
> On 03/31/2016 08:28 AM, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> May want to add: regression introduced in commit 96a1616.
>
>> ---
>> net/net.c | 1 +
>> 1 file changed, 1 insertion(+)
> Reviewed-by: Eric Blake <eblake@redhat.com>
Applied to -net.
Thanks
>
>> diff --git a/net/net.c b/net/net.c
>> index 594c3b8..3847a13 100644
>> --- a/net/net.c
>> +++ b/net/net.c
>> @@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev, Error **errp)
>> }
>>
>> error_propagate(errp, err);
>> + opts_visitor_cleanup(ov);
>> return ret;
>> }
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] net: fix OptsVisitor memory leak
@ 2016-04-01 2:00 ` Jason Wang
0 siblings, 0 replies; 6+ messages in thread
From: Jason Wang @ 2016-04-01 2:00 UTC (permalink / raw)
To: Eric Blake, Paolo Bonzini, qemu-devel; +Cc: qemu-trivial
On 04/01/2016 12:22 AM, Eric Blake wrote:
> On 03/31/2016 08:28 AM, Paolo Bonzini wrote:
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> May want to add: regression introduced in commit 96a1616.
>
>> ---
>> net/net.c | 1 +
>> 1 file changed, 1 insertion(+)
> Reviewed-by: Eric Blake <eblake@redhat.com>
Applied to -net.
Thanks
>
>> diff --git a/net/net.c b/net/net.c
>> index 594c3b8..3847a13 100644
>> --- a/net/net.c
>> +++ b/net/net.c
>> @@ -1100,6 +1100,7 @@ int net_client_init(QemuOpts *opts, int is_netdev, Error **errp)
>> }
>>
>> error_propagate(errp, err);
>> + opts_visitor_cleanup(ov);
>> return ret;
>> }
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-04-01 2:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-31 14:28 [Qemu-trivial] [PATCH] net: fix OptsVisitor memory leak Paolo Bonzini
2016-03-31 14:28 ` [Qemu-devel] " Paolo Bonzini
2016-03-31 16:22 ` [Qemu-trivial] " Eric Blake
2016-03-31 16:22 ` Eric Blake
2016-04-01 2:00 ` [Qemu-trivial] " Jason Wang
2016-04-01 2:00 ` Jason Wang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.