All of lore.kernel.org
 help / color / mirror / Atom feed
From: tomi.valkeinen@gmail.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: dtc warnings
Date: Fri, 1 Apr 2016 10:49:13 +0300	[thread overview]
Message-ID: <56FE27F9.2070100@gmail.com> (raw)
In-Reply-To: <CAL_Jsq+=OjY8y_8x7OSm-MWYKbrHN5cbv4TLwULxhNq+gfiMtw@mail.gmail.com>

Hi Rob,

On 01/04/16 04:40, Rob Herring wrote:
> You may have noticed that linux-next had gotten noisy with dtc
> warnings lately. I dropped the change for a bit, but added it back
> today except now it is disabled unless building with "W=1".
> 
> There's ~25K (2500 unique) warnings generated from the ARM dts files.
> Here's the ranking of warnings by dtb. OMAP is the clear winner (based
> on the similar counts, probably lots of duplicates). Please help
> remind contributors to test with W=1 and start to fix these.
> 
> At least for memory nodes, I plan to whitelist allowing no
> unit-address. There could be others, but none that I've seen so far.

What's the correct way to fix nodes for display platform devices? For
example, omap4-panda-common.dtsi has two connector nodes:

dvi0: connector at 0 {
	compatible = "dvi-connector";
	label = "dvi";
	...
};


hdmi0: connector at 1 {
	compatible = "hdmi-connector";
	label = "hdmi";
	...
};

Should I add the reg property, or should I rename the nodes to, say,
connector_dvi and connector_hdmi, or connector1 and connector2?

The index (reg) is not used for anything, but perhaps there could be
some use for it in the future (although I have no idea what the use
would be).

 Tomi

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20160401/3f8f3529/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: arm-platform-maintainers-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: dtc warnings
Date: Fri, 1 Apr 2016 10:49:13 +0300	[thread overview]
Message-ID: <56FE27F9.2070100@gmail.com> (raw)
In-Reply-To: <CAL_Jsq+=OjY8y_8x7OSm-MWYKbrHN5cbv4TLwULxhNq+gfiMtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1272 bytes --]

Hi Rob,

On 01/04/16 04:40, Rob Herring wrote:
> You may have noticed that linux-next had gotten noisy with dtc
> warnings lately. I dropped the change for a bit, but added it back
> today except now it is disabled unless building with "W=1".
> 
> There's ~25K (2500 unique) warnings generated from the ARM dts files.
> Here's the ranking of warnings by dtb. OMAP is the clear winner (based
> on the similar counts, probably lots of duplicates). Please help
> remind contributors to test with W=1 and start to fix these.
> 
> At least for memory nodes, I plan to whitelist allowing no
> unit-address. There could be others, but none that I've seen so far.

What's the correct way to fix nodes for display platform devices? For
example, omap4-panda-common.dtsi has two connector nodes:

dvi0: connector@0 {
	compatible = "dvi-connector";
	label = "dvi";
	...
};


hdmi0: connector@1 {
	compatible = "hdmi-connector";
	label = "hdmi";
	...
};

Should I add the reg property, or should I rename the nodes to, say,
connector_dvi and connector_hdmi, or connector1 and connector2?

The index (reg) is not used for anything, but perhaps there could be
some use for it in the future (although I have no idea what the use
would be).

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-04-01  7:49 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01  1:40 dtc warnings Rob Herring
2016-04-01  1:40 ` Rob Herring
2016-04-01  7:49 ` Tomi Valkeinen [this message]
2016-04-01  7:49   ` Tomi Valkeinen
2016-04-01  7:53   ` Krzysztof Kozlowski
2016-04-01  7:53     ` Krzysztof Kozlowski
2016-04-01 13:57     ` Nishanth Menon
2016-04-01 13:57       ` Nishanth Menon
2016-04-03  6:59       ` Viresh Kumar
2016-04-03  6:59         ` Viresh Kumar
2016-04-03  8:08         ` Krzysztof Kozlowski
2016-04-03  8:08           ` Krzysztof Kozlowski
2016-04-03 12:27           ` Viresh Kumar
2016-04-03 12:27             ` Viresh Kumar
2016-04-04  5:16             ` Rob Herring
2016-04-04  5:16               ` Rob Herring
2016-04-04  5:50               ` Viresh Kumar
2016-04-04  5:50                 ` Viresh Kumar
2016-04-04  5:56                 ` Krzysztof Kozlowski
2016-04-04  5:56                   ` Krzysztof Kozlowski
2016-04-01 13:25   ` Rob Herring
2016-04-01 13:25     ` Rob Herring
     [not found] ` <CAL_Jsq+=OjY8y_8x7OSm-MWYKbrHN5cbv4TLwULxhNq+gfiMtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-01 15:42   ` Tony Lindgren
2016-04-01 15:42     ` Tony Lindgren
2016-04-21 12:47 ` Rob Herring
2016-04-21 12:47   ` Rob Herring
  -- strict thread matches above, loose matches on Subject: below --
2018-03-14  5:18 Stephen Rothwell
2018-03-16 14:13 ` Michael Ellerman
2018-03-16 21:25   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FE27F9.2070100@gmail.com \
    --to=tomi.valkeinen@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.