All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	Tomi Valkeinen <tomi.valkeinen@gmail.com>,
	Viresh Kumar <viresh.kumar@linaro.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Krzysztof Kozlowski <krzk@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	arm-platform-maintainers@lists.infradead.org,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: dtc warnings
Date: Fri, 1 Apr 2016 08:57:30 -0500	[thread overview]
Message-ID: <56FE7E4A.2000601@ti.com> (raw)
In-Reply-To: <CAJKOXPdDyVbfSyshu4j21Ax2J-VwPpMZgAGEeO8VtgFYh4hTmw@mail.gmail.com>

On 04/01/2016 02:53 AM, Krzysztof Kozlowski wrote:
> On Fri, Apr 1, 2016 at 4:49 PM, Tomi Valkeinen <tomi.valkeinen@gmail.com> wrote:
>>
>> Hi Rob,
>>
>> On 01/04/16 04:40, Rob Herring wrote:
>>> You may have noticed that linux-next had gotten noisy with dtc
>>> warnings lately. I dropped the change for a bit, but added it back
>>> today except now it is disabled unless building with "W=1".
>>>
>>> There's ~25K (2500 unique) warnings generated from the ARM dts files.
>>> Here's the ranking of warnings by dtb. OMAP is the clear winner (based
>>> on the similar counts, probably lots of duplicates). Please help
>>> remind contributors to test with W=1 and start to fix these.
>>>
>>> At least for memory nodes, I plan to whitelist allowing no
>>> unit-address. There could be others, but none that I've seen so far.
>>
>> What's the correct way to fix nodes for display platform devices? For
>> example, omap4-panda-common.dtsi has two connector nodes:
>>
>> dvi0: connector@0 {
>>         compatible = "dvi-connector";
>>         label = "dvi";
>>         ...
>> };
>>
>>
>> hdmi0: connector@1 {
>>         compatible = "hdmi-connector";
>>         label = "hdmi";
>>         ...
>> };
> 
> I have the same doubts. The ePAPR says in that case "the node-name
> alone differentiates the node from other nodes at the same level in
> the tree.". But which is preferred? Differentiating by number or by
> type?
> 
> Similarly, what to do with the opp modes (a lot of warnings) in
> Documentation/devicetree/bindings/opp/opp.txt?
> 
+ linux-pm and Viresh for opp.txt


-- 
Regards,
Nishanth Menon

WARNING: multiple messages have this Message-ID (diff)
From: nm@ti.com (Nishanth Menon)
To: linux-arm-kernel@lists.infradead.org
Subject: dtc warnings
Date: Fri, 1 Apr 2016 08:57:30 -0500	[thread overview]
Message-ID: <56FE7E4A.2000601@ti.com> (raw)
In-Reply-To: <CAJKOXPdDyVbfSyshu4j21Ax2J-VwPpMZgAGEeO8VtgFYh4hTmw@mail.gmail.com>

On 04/01/2016 02:53 AM, Krzysztof Kozlowski wrote:
> On Fri, Apr 1, 2016 at 4:49 PM, Tomi Valkeinen <tomi.valkeinen@gmail.com> wrote:
>>
>> Hi Rob,
>>
>> On 01/04/16 04:40, Rob Herring wrote:
>>> You may have noticed that linux-next had gotten noisy with dtc
>>> warnings lately. I dropped the change for a bit, but added it back
>>> today except now it is disabled unless building with "W=1".
>>>
>>> There's ~25K (2500 unique) warnings generated from the ARM dts files.
>>> Here's the ranking of warnings by dtb. OMAP is the clear winner (based
>>> on the similar counts, probably lots of duplicates). Please help
>>> remind contributors to test with W=1 and start to fix these.
>>>
>>> At least for memory nodes, I plan to whitelist allowing no
>>> unit-address. There could be others, but none that I've seen so far.
>>
>> What's the correct way to fix nodes for display platform devices? For
>> example, omap4-panda-common.dtsi has two connector nodes:
>>
>> dvi0: connector at 0 {
>>         compatible = "dvi-connector";
>>         label = "dvi";
>>         ...
>> };
>>
>>
>> hdmi0: connector at 1 {
>>         compatible = "hdmi-connector";
>>         label = "hdmi";
>>         ...
>> };
> 
> I have the same doubts. The ePAPR says in that case "the node-name
> alone differentiates the node from other nodes at the same level in
> the tree.". But which is preferred? Differentiating by number or by
> type?
> 
> Similarly, what to do with the opp modes (a lot of warnings) in
> Documentation/devicetree/bindings/opp/opp.txt?
> 
+ linux-pm and Viresh for opp.txt


-- 
Regards,
Nishanth Menon

  reply	other threads:[~2016-04-01 13:58 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-01  1:40 dtc warnings Rob Herring
2016-04-01  1:40 ` Rob Herring
2016-04-01  7:49 ` Tomi Valkeinen
2016-04-01  7:49   ` Tomi Valkeinen
2016-04-01  7:53   ` Krzysztof Kozlowski
2016-04-01  7:53     ` Krzysztof Kozlowski
2016-04-01 13:57     ` Nishanth Menon [this message]
2016-04-01 13:57       ` Nishanth Menon
2016-04-03  6:59       ` Viresh Kumar
2016-04-03  6:59         ` Viresh Kumar
2016-04-03  8:08         ` Krzysztof Kozlowski
2016-04-03  8:08           ` Krzysztof Kozlowski
2016-04-03 12:27           ` Viresh Kumar
2016-04-03 12:27             ` Viresh Kumar
2016-04-04  5:16             ` Rob Herring
2016-04-04  5:16               ` Rob Herring
2016-04-04  5:50               ` Viresh Kumar
2016-04-04  5:50                 ` Viresh Kumar
2016-04-04  5:56                 ` Krzysztof Kozlowski
2016-04-04  5:56                   ` Krzysztof Kozlowski
2016-04-01 13:25   ` Rob Herring
2016-04-01 13:25     ` Rob Herring
     [not found] ` <CAL_Jsq+=OjY8y_8x7OSm-MWYKbrHN5cbv4TLwULxhNq+gfiMtw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-04-01 15:42   ` Tony Lindgren
2016-04-01 15:42     ` Tony Lindgren
2016-04-21 12:47 ` Rob Herring
2016-04-21 12:47   ` Rob Herring
  -- strict thread matches above, loose matches on Subject: below --
2018-03-14  5:18 Stephen Rothwell
2018-03-16 14:13 ` Michael Ellerman
2018-03-16 21:25   ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56FE7E4A.2000601@ti.com \
    --to=nm@ti.com \
    --cc=arm-platform-maintainers@lists.infradead.org \
    --cc=devicetree@vger.kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=krzk@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=tomi.valkeinen@gmail.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.