* [PATCH] bmips: rename BCM63168 to BCM63268
@ 2016-04-03 12:00 ` Álvaro Fernández Rojas
0 siblings, 0 replies; 9+ messages in thread
From: Álvaro Fernández Rojas @ 2016-04-03 12:00 UTC (permalink / raw)
To: linux-mips-6z/3iImG2C8G8FEW9MqTrA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, jogo-p3rKhJxN3npAfugRpC6u6w,
cernekee-Re5JQEeQqe8AvxtiuMwx3w, simon-A6De1vDTPLDsq35pWSNszA
Cc: Álvaro Fernández Rojas
BCM63168 and BCM63268 are very similar and Broadcom refers to them as BCM63268
in GPL sources (e.g. 63268_map_part.h).
Use alphabetical order for supported bmips quirks.
Add BCM63268 to devicetree documentation.
Signed-off-by: Álvaro Fernández Rojas <noltari-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
Documentation/devicetree/bindings/mips/brcm/soc.txt | 2 +-
arch/mips/bmips/setup.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mips/brcm/soc.txt b/Documentation/devicetree/bindings/mips/brcm/soc.txt
index e58a4f6..aae0b92 100644
--- a/Documentation/devicetree/bindings/mips/brcm/soc.txt
+++ b/Documentation/devicetree/bindings/mips/brcm/soc.txt
@@ -4,7 +4,7 @@ Required properties:
- compatible: "brcm,bcm3384", "brcm,bcm33843"
"brcm,bcm3384-viper", "brcm,bcm33843-viper"
- "brcm,bcm6328", "brcm,bcm6358", "brcm,bcm6368",
+ "brcm,bcm63268", "brcm,bcm6328", "brcm,bcm6358", "brcm,bcm6368",
"brcm,bcm7125", "brcm,bcm7346", "brcm,bcm7358", "brcm,bcm7360",
"brcm,bcm7362", "brcm,bcm7420", "brcm,bcm7425"
diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c
index 38b5bd5..bfee6ea 100644
--- a/arch/mips/bmips/setup.c
+++ b/arch/mips/bmips/setup.c
@@ -112,10 +112,10 @@ static void bcm6368_quirks(void)
static const struct bmips_quirk bmips_quirk_list[] = {
{ "brcm,bcm3384-viper", &bcm3384_viper_quirks },
{ "brcm,bcm33843-viper", &bcm3384_viper_quirks },
+ { "brcm,bcm63268", &bcm6368_quirks },
{ "brcm,bcm6328", &bcm6328_quirks },
{ "brcm,bcm6358", &bcm6358_quirks },
{ "brcm,bcm6368", &bcm6368_quirks },
- { "brcm,bcm63168", &bcm6368_quirks },
{ },
};
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] bmips: rename BCM63168 to BCM63268
2016-04-03 12:00 ` Álvaro Fernández Rojas
(?)
@ 2016-04-03 14:41 ` Simon Arlott
2016-04-03 18:31 ` Florian Fainelli
-1 siblings, 1 reply; 9+ messages in thread
From: Simon Arlott @ 2016-04-03 14:41 UTC (permalink / raw)
To: Álvaro Fernández Rojas, linux-mips, devicetree,
f.fainelli, jogo, cernekee
On 03/04/16 13:00, Álvaro Fernández Rojas wrote:
> BCM63168 and BCM63268 are very similar and Broadcom refers to them as BCM63268
They are practically the same but they both exist.
> diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c
> index 38b5bd5..bfee6ea 100644
> --- a/arch/mips/bmips/setup.c
> +++ b/arch/mips/bmips/setup.c
> @@ -112,10 +112,10 @@ static void bcm6368_quirks(void)
> static const struct bmips_quirk bmips_quirk_list[] = {
> { "brcm,bcm3384-viper", &bcm3384_viper_quirks },
> { "brcm,bcm33843-viper", &bcm3384_viper_quirks },
> + { "brcm,bcm63268", &bcm6368_quirks },
> { "brcm,bcm6328", &bcm6328_quirks },
> { "brcm,bcm6358", &bcm6358_quirks },
> { "brcm,bcm6368", &bcm6368_quirks },
> - { "brcm,bcm63168", &bcm6368_quirks },
You can add "brcm,bcm63268" but you can't remove support for
"brcm,bcm63168".
> { },
> };
>
>
--
Simon Arlott
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] bmips: rename BCM63168 to BCM63268
@ 2016-04-03 18:31 ` Florian Fainelli
0 siblings, 0 replies; 9+ messages in thread
From: Florian Fainelli @ 2016-04-03 18:31 UTC (permalink / raw)
To: Simon Arlott, Álvaro Fernández Rojas, linux-mips,
devicetree, jogo, cernekee
Le 03/04/2016 07:41, Simon Arlott a écrit :
> On 03/04/16 13:00, Álvaro Fernández Rojas wrote:
>> BCM63168 and BCM63268 are very similar and Broadcom refers to them as BCM63268
>
> They are practically the same but they both exist.
>
>> diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c
>> index 38b5bd5..bfee6ea 100644
>> --- a/arch/mips/bmips/setup.c
>> +++ b/arch/mips/bmips/setup.c
>> @@ -112,10 +112,10 @@ static void bcm6368_quirks(void)
>> static const struct bmips_quirk bmips_quirk_list[] = {
>> { "brcm,bcm3384-viper", &bcm3384_viper_quirks },
>> { "brcm,bcm33843-viper", &bcm3384_viper_quirks },
>> + { "brcm,bcm63268", &bcm6368_quirks },
>> { "brcm,bcm6328", &bcm6328_quirks },
>> { "brcm,bcm6358", &bcm6358_quirks },
>> { "brcm,bcm6368", &bcm6368_quirks },
>> - { "brcm,bcm63168", &bcm6368_quirks },
>
> You can add "brcm,bcm63268" but you can't remove support for
> "brcm,bcm63168".
Agreed, this cannot be removed now.
--
Florian
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] bmips: rename BCM63168 to BCM63268
@ 2016-04-03 18:31 ` Florian Fainelli
0 siblings, 0 replies; 9+ messages in thread
From: Florian Fainelli @ 2016-04-03 18:31 UTC (permalink / raw)
To: Simon Arlott, Álvaro Fernández Rojas,
linux-mips-6z/3iImG2C8G8FEW9MqTrA,
devicetree-u79uwXL29TY76Z2rM5mHXA, jogo-p3rKhJxN3npAfugRpC6u6w,
cernekee-Re5JQEeQqe8AvxtiuMwx3w
Le 03/04/2016 07:41, Simon Arlott a écrit :
> On 03/04/16 13:00, Álvaro Fernández Rojas wrote:
>> BCM63168 and BCM63268 are very similar and Broadcom refers to them as BCM63268
>
> They are practically the same but they both exist.
>
>> diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c
>> index 38b5bd5..bfee6ea 100644
>> --- a/arch/mips/bmips/setup.c
>> +++ b/arch/mips/bmips/setup.c
>> @@ -112,10 +112,10 @@ static void bcm6368_quirks(void)
>> static const struct bmips_quirk bmips_quirk_list[] = {
>> { "brcm,bcm3384-viper", &bcm3384_viper_quirks },
>> { "brcm,bcm33843-viper", &bcm3384_viper_quirks },
>> + { "brcm,bcm63268", &bcm6368_quirks },
>> { "brcm,bcm6328", &bcm6328_quirks },
>> { "brcm,bcm6358", &bcm6358_quirks },
>> { "brcm,bcm6368", &bcm6368_quirks },
>> - { "brcm,bcm63168", &bcm6368_quirks },
>
> You can add "brcm,bcm63268" but you can't remove support for
> "brcm,bcm63168".
Agreed, this cannot be removed now.
--
Florian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] bmips: add support for BCM63268
2016-04-03 12:00 ` Álvaro Fernández Rojas
(?)
(?)
@ 2016-04-04 8:11 ` Álvaro Fernández Rojas
2016-04-07 17:57 ` Rob Herring
2016-04-09 10:57 ` [PATCH] " Álvaro Fernández Rojas
-1 siblings, 2 replies; 9+ messages in thread
From: Álvaro Fernández Rojas @ 2016-04-04 8:11 UTC (permalink / raw)
To: linux-mips, devicetree, f.fainelli, jogo, cernekee, simon
Cc: Álvaro Fernández Rojas
This SoC is very similar to BCM63168 and Broadcom usually refers to them as
BCM63268.
Use alphabetical order for bmips quirks.
Add BCM63268 and missing BCM63168 to device tree documentation.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
v2: keep support for BCM63168
Documentation/devicetree/bindings/mips/brcm/soc.txt | 3 ++-
arch/mips/bmips/setup.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/mips/brcm/soc.txt b/Documentation/devicetree/bindings/mips/brcm/soc.txt
index e58a4f6..7a08c3e 100644
--- a/Documentation/devicetree/bindings/mips/brcm/soc.txt
+++ b/Documentation/devicetree/bindings/mips/brcm/soc.txt
@@ -4,7 +4,8 @@ Required properties:
- compatible: "brcm,bcm3384", "brcm,bcm33843"
"brcm,bcm3384-viper", "brcm,bcm33843-viper"
- "brcm,bcm6328", "brcm,bcm6358", "brcm,bcm6368",
+ "brcm,bcm63168", "brcm,bcm63268", "brcm,bcm6328",
+ "brcm,bcm6358", "brcm,bcm6368",
"brcm,bcm7125", "brcm,bcm7346", "brcm,bcm7358", "brcm,bcm7360",
"brcm,bcm7362", "brcm,bcm7420", "brcm,bcm7425"
diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c
index 38b5bd5..7cca770 100644
--- a/arch/mips/bmips/setup.c
+++ b/arch/mips/bmips/setup.c
@@ -112,10 +112,11 @@ static void bcm6368_quirks(void)
static const struct bmips_quirk bmips_quirk_list[] = {
{ "brcm,bcm3384-viper", &bcm3384_viper_quirks },
{ "brcm,bcm33843-viper", &bcm3384_viper_quirks },
+ { "brcm,bcm63168", &bcm6368_quirks },
+ { "brcm,bcm63268", &bcm6368_quirks },
{ "brcm,bcm6328", &bcm6328_quirks },
{ "brcm,bcm6358", &bcm6358_quirks },
{ "brcm,bcm6368", &bcm6368_quirks },
- { "brcm,bcm63168", &bcm6368_quirks },
{ },
};
--
2.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] bmips: add support for BCM63268
@ 2016-04-07 17:57 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2016-04-07 17:57 UTC (permalink / raw)
To: Álvaro Fernández Rojas
Cc: linux-mips, devicetree, f.fainelli, jogo, cernekee, simon
On Mon, Apr 04, 2016 at 10:11:57AM +0200, Álvaro Fernández Rojas wrote:
> This SoC is very similar to BCM63168 and Broadcom usually refers to them as
> BCM63268.
> Use alphabetical order for bmips quirks.
> Add BCM63268 and missing BCM63168 to device tree documentation.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> v2: keep support for BCM63168
>
> Documentation/devicetree/bindings/mips/brcm/soc.txt | 3 ++-
> arch/mips/bmips/setup.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] bmips: add support for BCM63268
@ 2016-04-07 17:57 ` Rob Herring
0 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2016-04-07 17:57 UTC (permalink / raw)
To: Álvaro Fernández Rojas
Cc: linux-mips-6z/3iImG2C8G8FEW9MqTrA,
devicetree-u79uwXL29TY76Z2rM5mHXA,
f.fainelli-Re5JQEeQqe8AvxtiuMwx3w, jogo-p3rKhJxN3npAfugRpC6u6w,
cernekee-Re5JQEeQqe8AvxtiuMwx3w, simon-A6De1vDTPLDsq35pWSNszA
On Mon, Apr 04, 2016 at 10:11:57AM +0200, Álvaro Fernández Rojas wrote:
> This SoC is very similar to BCM63168 and Broadcom usually refers to them as
> BCM63268.
> Use alphabetical order for bmips quirks.
> Add BCM63268 and missing BCM63168 to device tree documentation.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
> v2: keep support for BCM63168
>
> Documentation/devicetree/bindings/mips/brcm/soc.txt | 3 ++-
> arch/mips/bmips/setup.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] bmips: add support for BCM63268
2016-04-04 8:11 ` [PATCH v2] bmips: add support for BCM63268 Álvaro Fernández Rojas
2016-04-07 17:57 ` Rob Herring
@ 2016-04-09 10:57 ` Álvaro Fernández Rojas
1 sibling, 0 replies; 9+ messages in thread
From: Álvaro Fernández Rojas @ 2016-04-09 10:57 UTC (permalink / raw)
To: linux-mips, linux-kernel, devicetree, ralf, f.fainelli, jogo,
cernekee, robh, simon
Cc: Álvaro Fernández Rojas
This SoC is very similar to BCM63168 and Broadcom usually refers to them as
BCM63268.
Add BCM63268 and missing BCM63168 to device tree documentation.
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Acked-by: Rob Herring <robh@kernel.org>
---
v3: use numerical order
v2: keep support for BCM63168
Documentation/devicetree/bindings/mips/brcm/soc.txt | 1 +
arch/mips/bmips/setup.c | 1 +
2 files changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mips/brcm/soc.txt b/Documentation/devicetree/bindings/mips/brcm/soc.txt
index e58a4f6..4a7e030 100644
--- a/Documentation/devicetree/bindings/mips/brcm/soc.txt
+++ b/Documentation/devicetree/bindings/mips/brcm/soc.txt
@@ -5,6 +5,7 @@ Required properties:
- compatible: "brcm,bcm3384", "brcm,bcm33843"
"brcm,bcm3384-viper", "brcm,bcm33843-viper"
"brcm,bcm6328", "brcm,bcm6358", "brcm,bcm6368",
+ "brcm,bcm63168", "brcm,bcm63268",
"brcm,bcm7125", "brcm,bcm7346", "brcm,bcm7358", "brcm,bcm7360",
"brcm,bcm7362", "brcm,bcm7420", "brcm,bcm7425"
diff --git a/arch/mips/bmips/setup.c b/arch/mips/bmips/setup.c
index 38b5bd5..92d0483 100644
--- a/arch/mips/bmips/setup.c
+++ b/arch/mips/bmips/setup.c
@@ -116,6 +116,7 @@ static const struct bmips_quirk bmips_quirk_list[] = {
{ "brcm,bcm6358", &bcm6358_quirks },
{ "brcm,bcm6368", &bcm6368_quirks },
{ "brcm,bcm63168", &bcm6368_quirks },
+ { "brcm,bcm63268", &bcm6368_quirks },
{ },
};
--
2.1.4
^ permalink raw reply related [flat|nested] 9+ messages in thread