All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Fedorov <sergey.fedorov@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-arm] [PATCH 2/4] target-arm: Remove incorrect ALIAS tags from ESR_EL2 and ESR_EL3
Date: Mon, 4 Apr 2016 17:16:10 +0300	[thread overview]
Message-ID: <5702772A.1080005@linaro.org> (raw)
In-Reply-To: <1459435778-5526-3-git-send-email-peter.maydell@linaro.org>

On 31/03/16 17:49, Peter Maydell wrote:
> The regdefs for the ESR_EL2 and ESR_EL3 system registers should not
> be marked as ARM_CP_ALIAS, because these are the master copies; the
> DFSR regdef in vmsa_pmsa_cp_reginfo[] is marked as an alias.
> Remove the ALIAS tags so that these registers are correctly migrated.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.rog>

> ---
>  target-arm/helper.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index e583e6a..0e54d90 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -3509,7 +3509,6 @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
>        .access = PL2_RW,
>        .fieldoffset = offsetof(CPUARMState, elr_el[2]) },
>      { .name = "ESR_EL2", .state = ARM_CP_STATE_AA64,
> -      .type = ARM_CP_ALIAS,
>        .opc0 = 3, .opc1 = 4, .crn = 5, .crm = 2, .opc2 = 0,
>        .access = PL2_RW, .fieldoffset = offsetof(CPUARMState, cp15.esr_el[2]) },
>      { .name = "FAR_EL2", .state = ARM_CP_STATE_AA64,
> @@ -3759,7 +3758,6 @@ static const ARMCPRegInfo el3_cp_reginfo[] = {
>        .access = PL3_RW,
>        .fieldoffset = offsetof(CPUARMState, elr_el[3]) },
>      { .name = "ESR_EL3", .state = ARM_CP_STATE_AA64,
> -      .type = ARM_CP_ALIAS,
>        .opc0 = 3, .opc1 = 6, .crn = 5, .crm = 2, .opc2 = 0,
>        .access = PL3_RW, .fieldoffset = offsetof(CPUARMState, cp15.esr_el[3]) },
>      { .name = "FAR_EL3", .state = ARM_CP_STATE_AA64,


WARNING: multiple messages have this Message-ID (diff)
From: Sergey Fedorov <sergey.fedorov@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm@nongnu.org, qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Subject: Re: [Qemu-devel] [PATCH 2/4] target-arm: Remove incorrect ALIAS tags from ESR_EL2 and ESR_EL3
Date: Mon, 4 Apr 2016 17:16:10 +0300	[thread overview]
Message-ID: <5702772A.1080005@linaro.org> (raw)
In-Reply-To: <1459435778-5526-3-git-send-email-peter.maydell@linaro.org>

On 31/03/16 17:49, Peter Maydell wrote:
> The regdefs for the ESR_EL2 and ESR_EL3 system registers should not
> be marked as ARM_CP_ALIAS, because these are the master copies; the
> DFSR regdef in vmsa_pmsa_cp_reginfo[] is marked as an alias.
> Remove the ALIAS tags so that these registers are correctly migrated.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Reviewed-by: Sergey Fedorov <sergey.fedorov@linaro.rog>

> ---
>  target-arm/helper.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/target-arm/helper.c b/target-arm/helper.c
> index e583e6a..0e54d90 100644
> --- a/target-arm/helper.c
> +++ b/target-arm/helper.c
> @@ -3509,7 +3509,6 @@ static const ARMCPRegInfo el2_cp_reginfo[] = {
>        .access = PL2_RW,
>        .fieldoffset = offsetof(CPUARMState, elr_el[2]) },
>      { .name = "ESR_EL2", .state = ARM_CP_STATE_AA64,
> -      .type = ARM_CP_ALIAS,
>        .opc0 = 3, .opc1 = 4, .crn = 5, .crm = 2, .opc2 = 0,
>        .access = PL2_RW, .fieldoffset = offsetof(CPUARMState, cp15.esr_el[2]) },
>      { .name = "FAR_EL2", .state = ARM_CP_STATE_AA64,
> @@ -3759,7 +3758,6 @@ static const ARMCPRegInfo el3_cp_reginfo[] = {
>        .access = PL3_RW,
>        .fieldoffset = offsetof(CPUARMState, elr_el[3]) },
>      { .name = "ESR_EL3", .state = ARM_CP_STATE_AA64,
> -      .type = ARM_CP_ALIAS,
>        .opc0 = 3, .opc1 = 6, .crn = 5, .crm = 2, .opc2 = 0,
>        .access = PL3_RW, .fieldoffset = offsetof(CPUARMState, cp15.esr_el[3]) },
>      { .name = "FAR_EL3", .state = ARM_CP_STATE_AA64,

  reply	other threads:[~2016-04-04 14:16 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-31 14:49 [Qemu-arm] [PATCH for-2.6 0/4] various regdef fixes for EL2/EL3 regs Peter Maydell
2016-03-31 14:49 ` [Qemu-devel] " Peter Maydell
2016-03-31 14:49 ` [Qemu-arm] [PATCH 1/4] target-arm: Correctly reset SCTLR_EL3 for 64-bit CPUs Peter Maydell
2016-03-31 14:49   ` [Qemu-devel] " Peter Maydell
2016-03-31 14:59   ` [Qemu-arm] " Laurent Desnogues
2016-03-31 14:59     ` Laurent Desnogues
2016-04-04 14:13   ` [Qemu-arm] " Sergey Fedorov
2016-04-04 14:13     ` [Qemu-devel] " Sergey Fedorov
2016-03-31 14:49 ` [Qemu-arm] [PATCH 2/4] target-arm: Remove incorrect ALIAS tags from ESR_EL2 and ESR_EL3 Peter Maydell
2016-03-31 14:49   ` [Qemu-devel] " Peter Maydell
2016-04-04 14:16   ` Sergey Fedorov [this message]
2016-04-04 14:16     ` Sergey Fedorov
2016-03-31 14:49 ` [Qemu-arm] [PATCH 3/4] target-arm: Make the 64-bit version of VTCR do the migration Peter Maydell
2016-03-31 14:49   ` [Qemu-devel] " Peter Maydell
2016-04-04 14:22   ` [Qemu-arm] " Sergey Fedorov
2016-04-04 14:22     ` [Qemu-devel] " Sergey Fedorov
2016-03-31 14:49 ` [Qemu-arm] [PATCH 4/4] target-arm: Avoid unnecessary TLB flush on TCR_EL2 writes Peter Maydell
2016-03-31 14:49   ` [Qemu-devel] " Peter Maydell
2016-04-04 14:58   ` [Qemu-arm] " Sergey Fedorov
2016-04-04 14:58     ` [Qemu-devel] " Sergey Fedorov
2016-04-04 15:01     ` [Qemu-arm] " Peter Maydell
2016-04-04 15:01       ` [Qemu-devel] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5702772A.1080005@linaro.org \
    --to=sergey.fedorov@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.