From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
bridge@lists.linux-foundation.org
Cc: nikolay@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [Bridge] [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm
Date: Tue, 5 Apr 2016 14:08:13 +0900 [thread overview]
Message-ID: <5703483D.80109@lab.ntt.co.jp> (raw)
In-Reply-To: <baf4788b6ac529a2132ace735fc1caf4989307da.1459827115.git.lucien.xin@gmail.com>
On 2016/04/05 12:32, Xin Long wrote:
> There are some repetitive codes in stp_state_store, we can remove
> them by calling store_bridge_parm.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/bridge/br_sysfs_br.c | 24 +++++++-----------------
> 1 file changed, 7 insertions(+), 17 deletions(-)
>
> diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
> index 137cd3b..9918763 100644
> --- a/net/bridge/br_sysfs_br.c
> +++ b/net/bridge/br_sysfs_br.c
> @@ -128,27 +128,17 @@ static ssize_t stp_state_show(struct device *d,
> }
>
>
> +static int set_stp_state(struct net_bridge *br, unsigned long val)
> +{
You forgot to add rtnl lock here?
The missing lock is restored in patch 4, but at this point bisect could
break..
> + br_stp_set_enabled(br, val);
> + return 0;
> +}
Toshiaki Makita
WARNING: multiple messages have this Message-ID (diff)
From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: Xin Long <lucien.xin@gmail.com>,
network dev <netdev@vger.kernel.org>,
bridge@lists.linux-foundation.org
Cc: nikolay@cumulusnetworks.com, davem@davemloft.net
Subject: Re: [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store by calling store_bridge_parm
Date: Tue, 5 Apr 2016 14:08:13 +0900 [thread overview]
Message-ID: <5703483D.80109@lab.ntt.co.jp> (raw)
In-Reply-To: <baf4788b6ac529a2132ace735fc1caf4989307da.1459827115.git.lucien.xin@gmail.com>
On 2016/04/05 12:32, Xin Long wrote:
> There are some repetitive codes in stp_state_store, we can remove
> them by calling store_bridge_parm.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/bridge/br_sysfs_br.c | 24 +++++++-----------------
> 1 file changed, 7 insertions(+), 17 deletions(-)
>
> diff --git a/net/bridge/br_sysfs_br.c b/net/bridge/br_sysfs_br.c
> index 137cd3b..9918763 100644
> --- a/net/bridge/br_sysfs_br.c
> +++ b/net/bridge/br_sysfs_br.c
> @@ -128,27 +128,17 @@ static ssize_t stp_state_show(struct device *d,
> }
>
>
> +static int set_stp_state(struct net_bridge *br, unsigned long val)
> +{
You forgot to add rtnl lock here?
The missing lock is restored in patch 4, but at this point bisect could
break..
> + br_stp_set_enabled(br, val);
> + return 0;
> +}
Toshiaki Makita
next prev parent reply other threads:[~2016-04-05 5:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-05 3:32 [Bridge] [PATCHv2 net-next 0/6] bridge: support sending rntl info when we set attributes through sysfs/ioctl Xin Long
2016-04-05 3:32 ` Xin Long
2016-04-05 3:32 ` [Bridge] [PATCHv2 net-next 1/6] bridge: simplify the flush_store by calling store_bridge_parm Xin Long
2016-04-05 3:32 ` Xin Long
2016-04-05 3:32 ` [Bridge] [PATCHv2 net-next 2/6] bridge: simplify the forward_delay_store " Xin Long
2016-04-05 3:32 ` Xin Long
2016-04-05 3:32 ` [Bridge] [PATCHv2 net-next 3/6] bridge: simplify the stp_state_store " Xin Long
2016-04-05 3:32 ` Xin Long
2016-04-05 5:08 ` Toshiaki Makita [this message]
2016-04-05 5:08 ` Toshiaki Makita
2016-04-06 20:10 ` [Bridge] " David Miller
2016-04-06 20:10 ` David Miller
2016-04-07 3:49 ` [Bridge] " Xin Long
2016-04-07 3:49 ` Xin Long
2016-04-05 3:32 ` [Bridge] [PATCHv2 net-next 4/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_br Xin Long
2016-04-05 3:32 ` Xin Long
2016-04-05 3:32 ` [Bridge] [PATCHv2 net-next 5/6] bridge: a netlink notification should be sent when those attributes are changed by br_sysfs_if Xin Long
2016-04-05 3:32 ` Xin Long
2016-04-05 3:32 ` [Bridge] [PATCHv2 net-next 6/6] bridge: a netlink notification should be sent when those attributes are changed by ioctl Xin Long
2016-04-05 3:32 ` Xin Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5703483D.80109@lab.ntt.co.jp \
--to=makita.toshiaki@lab.ntt.co.jp \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.