All of lore.kernel.org
 help / color / mirror / Atom feed
* [LTP]  [PATCH] cpuset: change default cpuset mount value
@ 2016-04-07  9:36 Basavaraju
  2016-04-07 15:31 ` Cyril Hrubis
  0 siblings, 1 reply; 2+ messages in thread
From: Basavaraju @ 2016-04-07  9:36 UTC (permalink / raw)
  To: ltp

Hi,

Earlier cpuset is mounted under /dev/cpuset by default. This behaviour is changed in RHEL7.1 and RHEL7.2 Distributions

by default, Now its mounting under /sys/fs/cgroup/cpuset.


[root@localhost ~]# mount | grep cpuset
cgroup on /sys/fs/cgroup/cpuset type cgroup 
(rw,nosuid,nodev,noexec,relatime,cpuset)
[root@localhost ~]#

Signed-off-by: Basavaraju.G<basava@linux.vnet.ibm.com>
Tested-by: Basavaraju.G<basava@linux.vnet.ibm.com>


diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh 
b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
index cd7000e..4c5a17b 100755
--- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
+++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
@@ -35,7 +35,7 @@ fi
  N_NODES=${N_NODES#*-*}
  N_NODES=$(($N_NODES + 1))

-CPUSET="/dev/cpuset"
+CPUSET="/sys/fs/cgroup/cpuset"
  CPUSET_TMP="/tmp/cpuset_tmp"

  HOTPLUG_CPU="1"


Best Regards,
Basavaraju.G


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linux.it/pipermail/ltp/attachments/20160407/c3291688/attachment.html>

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [LTP] [PATCH] cpuset: change default cpuset mount value
  2016-04-07  9:36 [LTP] [PATCH] cpuset: change default cpuset mount value Basavaraju
@ 2016-04-07 15:31 ` Cyril Hrubis
  0 siblings, 0 replies; 2+ messages in thread
From: Cyril Hrubis @ 2016-04-07 15:31 UTC (permalink / raw)
  To: ltp

Hi!
> diff --git a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh 
> b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> index cd7000e..4c5a17b 100755
> --- a/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> +++ b/testcases/kernel/controllers/cpuset/cpuset_funcs.sh
> @@ -35,7 +35,7 @@ fi
>   N_NODES=${N_NODES#*-*}
>   N_NODES=$(($N_NODES + 1))
> 
> -CPUSET="/dev/cpuset"
> +CPUSET="/sys/fs/cgroup/cpuset"
>   CPUSET_TMP="/tmp/cpuset_tmp"

This does not seem like a good solution for two reasons. The first is
that LTP should be backward compatible with older distributions and the
second is that the testcase umounts and removes the directory at the end
of the test which will break the system since the /sys/fs/cgroup/cpuset
directory is mounted (and possibly used) by default on newer
distributions.

So the test should be changed to:

* Create and mount cpuset on older distros

* Make use of allready moutned cpuset on newer distros

The cgroup_fj/cgroup_fj_common.sh was allready fixed to work this way.

-- 
Cyril Hrubis
chrubis@suse.cz

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-04-07 15:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-07  9:36 [LTP] [PATCH] cpuset: change default cpuset mount value Basavaraju
2016-04-07 15:31 ` Cyril Hrubis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.