* [kvm-unit-tests PATCH] fix machine type handling for ppc64le @ 2016-04-11 11:37 Lukáš Doktor 2016-04-11 11:37 ` [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone Lukáš Doktor 2016-04-11 11:37 ` [PATCH 2/2] powerpc: Improve "kvm unavailable" message Lukáš Doktor 0 siblings, 2 replies; 7+ messages in thread From: Lukáš Doktor @ 2016-04-11 11:37 UTC (permalink / raw) To: ldoktor, kvm, drjones, pbonzini, lvivier Hello guys, this mini-series fixes the "MACHINE" type handling in "mkstandalone" and improves the UI message when kvm not available on ppc64. ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone 2016-04-11 11:37 [kvm-unit-tests PATCH] fix machine type handling for ppc64le Lukáš Doktor @ 2016-04-11 11:37 ` Lukáš Doktor 2016-04-11 11:56 ` Andrew Jones 2016-05-10 12:36 ` Paolo Bonzini 2016-04-11 11:37 ` [PATCH 2/2] powerpc: Improve "kvm unavailable" message Lukáš Doktor 1 sibling, 2 replies; 7+ messages in thread From: Lukáš Doktor @ 2016-04-11 11:37 UTC (permalink / raw) To: ldoktor, kvm, drjones, pbonzini, lvivier The query for machine type in `mkstandalone` is missing the `ppc64le` fixture. This patch uses the version from `configure` which should contain all fixtures. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com> --- scripts/mkstandalone.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh index ef15bc8..26094df 100755 --- a/scripts/mkstandalone.sh +++ b/scripts/mkstandalone.sh @@ -40,7 +40,7 @@ generate_test () echo "#!/bin/bash" echo "export STANDALONE=yes" - echo "export HOST=\$(uname -m | sed -e s/i.86/i386/ | sed -e 's/arm.*/arm/')" + echo "export HOST=\$(uname -m | sed -e 's/i.86/i386/;s/arm.*/arm/;s/ppc64.*/ppc64/')" echo "export PRETTY_PRINT_STACKS=no" config_export ARCH -- 2.5.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone 2016-04-11 11:37 ` [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone Lukáš Doktor @ 2016-04-11 11:56 ` Andrew Jones 2016-05-10 12:36 ` Paolo Bonzini 1 sibling, 0 replies; 7+ messages in thread From: Andrew Jones @ 2016-04-11 11:56 UTC (permalink / raw) To: Lukáš Doktor; +Cc: kvm, pbonzini, lvivier On Mon, Apr 11, 2016 at 01:37:52PM +0200, Lukáš Doktor wrote: > The query for machine type in `mkstandalone` is missing the `ppc64le` > fixture. This patch uses the version from `configure` which should > contain all fixtures. > > Signed-off-by: Lukáš Doktor <ldoktor@redhat.com> > --- > scripts/mkstandalone.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Andrew Jones <drjones@redhat.com> > > diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh > index ef15bc8..26094df 100755 > --- a/scripts/mkstandalone.sh > +++ b/scripts/mkstandalone.sh > @@ -40,7 +40,7 @@ generate_test () > > echo "#!/bin/bash" > echo "export STANDALONE=yes" > - echo "export HOST=\$(uname -m | sed -e s/i.86/i386/ | sed -e 's/arm.*/arm/')" > + echo "export HOST=\$(uname -m | sed -e 's/i.86/i386/;s/arm.*/arm/;s/ppc64.*/ppc64/')" > echo "export PRETTY_PRINT_STACKS=no" > > config_export ARCH > -- > 2.5.5 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone 2016-04-11 11:37 ` [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone Lukáš Doktor 2016-04-11 11:56 ` Andrew Jones @ 2016-05-10 12:36 ` Paolo Bonzini 1 sibling, 0 replies; 7+ messages in thread From: Paolo Bonzini @ 2016-05-10 12:36 UTC (permalink / raw) To: Lukáš Doktor, kvm, drjones, lvivier On 11/04/2016 13:37, Lukáš Doktor wrote: > The query for machine type in `mkstandalone` is missing the `ppc64le` > fixture. This patch uses the version from `configure` which should > contain all fixtures. > > Signed-off-by: Lukáš Doktor <ldoktor@redhat.com> > --- > scripts/mkstandalone.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/scripts/mkstandalone.sh b/scripts/mkstandalone.sh > index ef15bc8..26094df 100755 > --- a/scripts/mkstandalone.sh > +++ b/scripts/mkstandalone.sh > @@ -40,7 +40,7 @@ generate_test () > > echo "#!/bin/bash" > echo "export STANDALONE=yes" > - echo "export HOST=\$(uname -m | sed -e s/i.86/i386/ | sed -e 's/arm.*/arm/')" > + echo "export HOST=\$(uname -m | sed -e 's/i.86/i386/;s/arm.*/arm/;s/ppc64.*/ppc64/')" > echo "export PRETTY_PRINT_STACKS=no" > > config_export ARCH > Queued this one, thanks. Paolo ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 2/2] powerpc: Improve "kvm unavailable" message 2016-04-11 11:37 [kvm-unit-tests PATCH] fix machine type handling for ppc64le Lukáš Doktor 2016-04-11 11:37 ` [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone Lukáš Doktor @ 2016-04-11 11:37 ` Lukáš Doktor 2016-04-11 12:02 ` Andrew Jones 1 sibling, 1 reply; 7+ messages in thread From: Lukáš Doktor @ 2016-04-11 11:37 UTC (permalink / raw) To: ldoktor, kvm, drjones, pbonzini, lvivier The message when ACCEL=kvm and kvm not available is rather confusing. Let's produce (hopefully) easier to understand message. Signed-off-by: Lukáš Doktor <ldoktor@redhat.com> --- powerpc/run | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/powerpc/run b/powerpc/run index 56698e6..adffb93 100755 --- a/powerpc/run +++ b/powerpc/run @@ -16,7 +16,7 @@ if [ -c /dev/kvm ]; then fi if [ "$ACCEL" = "kvm" ] && [ "$kvm_available" != "yes" ]; then - echo "skip $TESTNAME (kvm only)" + echo "skip $TESTNAME (kvm not available on your system)" exit 2 fi -- 2.5.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] powerpc: Improve "kvm unavailable" message 2016-04-11 11:37 ` [PATCH 2/2] powerpc: Improve "kvm unavailable" message Lukáš Doktor @ 2016-04-11 12:02 ` Andrew Jones 2016-04-11 14:50 ` Lukáš Doktor 0 siblings, 1 reply; 7+ messages in thread From: Andrew Jones @ 2016-04-11 12:02 UTC (permalink / raw) To: Lukáš Doktor; +Cc: kvm, pbonzini, lvivier, rkrcmar On Mon, Apr 11, 2016 at 01:37:53PM +0200, Lukáš Doktor wrote: > The message when ACCEL=kvm and kvm not available is rather confusing. > Let's produce (hopefully) easier to understand message. > > Signed-off-by: Lukáš Doktor <ldoktor@redhat.com> > --- > powerpc/run | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/powerpc/run b/powerpc/run > index 56698e6..adffb93 100755 > --- a/powerpc/run > +++ b/powerpc/run > @@ -16,7 +16,7 @@ if [ -c /dev/kvm ]; then > fi > > if [ "$ACCEL" = "kvm" ] && [ "$kvm_available" != "yes" ]; then > - echo "skip $TESTNAME (kvm only)" > + echo "skip $TESTNAME (kvm not available on your system)" This will now be inconsistent with scripts/runtime.bash. Also, the 'kvm only' message conveys that this test can only run with kvm, as opposed to also with tcg. While I agree it's terse, we've now lost that information with the new message. Additionally, I would say 'this system' instead of 'your system' in the message. I think Radim has some plans for giving run script error messages an overhaul. Maybe he can address this one with that series too? Anyway, for now, I would suggest we drop this patch. Thanks, drew > exit 2 > fi > > -- > 2.5.5 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 2/2] powerpc: Improve "kvm unavailable" message 2016-04-11 12:02 ` Andrew Jones @ 2016-04-11 14:50 ` Lukáš Doktor 0 siblings, 0 replies; 7+ messages in thread From: Lukáš Doktor @ 2016-04-11 14:50 UTC (permalink / raw) To: Andrew Jones; +Cc: kvm, pbonzini, lvivier, rkrcmar Dne 11.4.2016 v 14:02 Andrew Jones napsal(a): > On Mon, Apr 11, 2016 at 01:37:53PM +0200, Lukáš Doktor wrote: >> The message when ACCEL=kvm and kvm not available is rather confusing. >> Let's produce (hopefully) easier to understand message. >> >> Signed-off-by: Lukáš Doktor <ldoktor@redhat.com> >> --- >> powerpc/run | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/powerpc/run b/powerpc/run >> index 56698e6..adffb93 100755 >> --- a/powerpc/run >> +++ b/powerpc/run >> @@ -16,7 +16,7 @@ if [ -c /dev/kvm ]; then >> fi >> >> if [ "$ACCEL" = "kvm" ] && [ "$kvm_available" != "yes" ]; then >> - echo "skip $TESTNAME (kvm only)" >> + echo "skip $TESTNAME (kvm not available on your system)" > > This will now be inconsistent with scripts/runtime.bash. Also, > the 'kvm only' message conveys that this test can only run with > kvm, as opposed to also with tcg. While I agree it's terse, we've > now lost that information with the new message. Additionally, I > would say 'this system' instead of 'your system' in the message. > > I think Radim has some plans for giving run script error messages > an overhaul. Maybe he can address this one with that series too? > Anyway, for now, I would suggest we drop this patch. > I thought the message probably has some inner-context, but for me it was super confusing. Even more because I'm using ACCEL=kvm,kvm-type=PR ... in some of my power testing, which works well, but when I tried ACCEL=kvm ... it reported test skips. I'm looking forward to some proper errors handling (and ways to pass SKIPs as well). Thank you and feel free to drop this patch, Lukáš > Thanks, > drew > >> exit 2 >> fi >> >> -- >> 2.5.5 >> ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-05-10 12:36 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-04-11 11:37 [kvm-unit-tests PATCH] fix machine type handling for ppc64le Lukáš Doktor 2016-04-11 11:37 ` [PATCH 1/2] scripts: Handle ppc64le machine name in mkstandalone Lukáš Doktor 2016-04-11 11:56 ` Andrew Jones 2016-05-10 12:36 ` Paolo Bonzini 2016-04-11 11:37 ` [PATCH 2/2] powerpc: Improve "kvm unavailable" message Lukáš Doktor 2016-04-11 12:02 ` Andrew Jones 2016-04-11 14:50 ` Lukáš Doktor
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.