From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: <qemu-trivial@nongnu.org>, <pbonzini@redhat.com>,
<qemu-devel@nongnu.org>, <peter.maydell@linaro.org>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] qdev property: cleanup
Date: Tue, 12 Apr 2016 20:49:04 +0800 [thread overview]
Message-ID: <570CEEC0.3020501@cn.fujitsu.com> (raw)
In-Reply-To: <87a8kzkzlj.fsf@dusky.pond.sub.org>
On 04/12/2016 04:20 PM, Markus Armbruster wrote:
>
> Here's my try rewording the comment (sticking to GTK-Doc conventions
> even though I dislike them):
>
> /**
> * @qdev_property_add_static:
> * @dev: Device to add the property to
> * @prop: The qdev property definition
> * @err: location to store error information
> *
> * Add a static QOM property to @dev for qdev property @prop.
> * On error, store error in @errp.
> */
>
> Paolo, is it correct?
>
> Cao jin, is it an improvement?
>
Yes, better, save the unnecessary pains to analyse the property type for
me:)
--
Yours Sincerely,
Cao jin
WARNING: multiple messages have this Message-ID (diff)
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, pbonzini@redhat.com,
qemu-devel@nongnu.org, peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] qdev property: cleanup
Date: Tue, 12 Apr 2016 20:49:04 +0800 [thread overview]
Message-ID: <570CEEC0.3020501@cn.fujitsu.com> (raw)
In-Reply-To: <87a8kzkzlj.fsf@dusky.pond.sub.org>
On 04/12/2016 04:20 PM, Markus Armbruster wrote:
>
> Here's my try rewording the comment (sticking to GTK-Doc conventions
> even though I dislike them):
>
> /**
> * @qdev_property_add_static:
> * @dev: Device to add the property to
> * @prop: The qdev property definition
> * @err: location to store error information
> *
> * Add a static QOM property to @dev for qdev property @prop.
> * On error, store error in @errp.
> */
>
> Paolo, is it correct?
>
> Cao jin, is it an improvement?
>
Yes, better, save the unnecessary pains to analyse the property type for
me:)
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-04-12 12:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 10:14 [Qemu-trivial] [PATCH] qdev property: cleanup Cao jin
2016-03-24 10:14 ` [Qemu-devel] " Cao jin
2016-03-24 11:25 ` [Qemu-trivial] " Paolo Bonzini
2016-03-24 11:25 ` [Qemu-devel] " Paolo Bonzini
2016-03-25 6:06 ` [Qemu-trivial] " Cao jin
2016-03-25 6:06 ` [Qemu-devel] " Cao jin
2016-04-08 11:17 ` [Qemu-trivial] " Markus Armbruster
2016-04-08 11:17 ` Markus Armbruster
2016-04-09 14:25 ` [Qemu-trivial] " Cao jin
2016-04-09 14:25 ` Cao jin
2016-04-12 8:20 ` [Qemu-trivial] " Markus Armbruster
2016-04-12 8:20 ` Markus Armbruster
2016-04-12 12:49 ` Cao jin [this message]
2016-04-12 12:49 ` Cao jin
2016-04-15 10:06 ` [Qemu-trivial] " Paolo Bonzini
2016-04-15 10:06 ` Paolo Bonzini
2016-04-15 11:15 ` [Qemu-trivial] " Cao jin
2016-04-15 11:15 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570CEEC0.3020501@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.