From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Paolo Bonzini <pbonzini@redhat.com>, <qemu-devel@nongnu.org>
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
eblake@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-trivial] [PATCH] qdev property: cleanup
Date: Fri, 25 Mar 2016 14:06:48 +0800 [thread overview]
Message-ID: <56F4D578.5040108@cn.fujitsu.com> (raw)
In-Reply-To: <56F3CEBE.7060002@redhat.com>
On 03/24/2016 07:25 PM, Paolo Bonzini wrote:
>
>
>> A question about legacy property: I don`t see legacy property is really
>> used in the code, so, why still add legacy property to object?
>
> It's used here:
>
> static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props,
> int indent)
Thanks Paolo, I saw here, and then I thought the property is added and
just be printed out, seems for no real benefit("really used"). Now I
think I see where I was wrong. Thanks.
BTW, is this patch right?
--
Yours Sincerely,
Cao jin
WARNING: multiple messages have this Message-ID (diff)
From: Cao jin <caoj.fnst@cn.fujitsu.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qdev property: cleanup
Date: Fri, 25 Mar 2016 14:06:48 +0800 [thread overview]
Message-ID: <56F4D578.5040108@cn.fujitsu.com> (raw)
In-Reply-To: <56F3CEBE.7060002@redhat.com>
On 03/24/2016 07:25 PM, Paolo Bonzini wrote:
>
>
>> A question about legacy property: I don`t see legacy property is really
>> used in the code, so, why still add legacy property to object?
>
> It's used here:
>
> static void qdev_print_props(Monitor *mon, DeviceState *dev, Property *props,
> int indent)
Thanks Paolo, I saw here, and then I thought the property is added and
just be printed out, seems for no real benefit("really used"). Now I
think I see where I was wrong. Thanks.
BTW, is this patch right?
--
Yours Sincerely,
Cao jin
next prev parent reply other threads:[~2016-03-25 6:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 10:14 [Qemu-trivial] [PATCH] qdev property: cleanup Cao jin
2016-03-24 10:14 ` [Qemu-devel] " Cao jin
2016-03-24 11:25 ` [Qemu-trivial] " Paolo Bonzini
2016-03-24 11:25 ` [Qemu-devel] " Paolo Bonzini
2016-03-25 6:06 ` Cao jin [this message]
2016-03-25 6:06 ` Cao jin
2016-04-08 11:17 ` [Qemu-trivial] " Markus Armbruster
2016-04-08 11:17 ` Markus Armbruster
2016-04-09 14:25 ` [Qemu-trivial] " Cao jin
2016-04-09 14:25 ` Cao jin
2016-04-12 8:20 ` [Qemu-trivial] " Markus Armbruster
2016-04-12 8:20 ` Markus Armbruster
2016-04-12 12:49 ` [Qemu-trivial] " Cao jin
2016-04-12 12:49 ` Cao jin
2016-04-15 10:06 ` [Qemu-trivial] " Paolo Bonzini
2016-04-15 10:06 ` Paolo Bonzini
2016-04-15 11:15 ` [Qemu-trivial] " Cao jin
2016-04-15 11:15 ` Cao jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F4D578.5040108@cn.fujitsu.com \
--to=caoj.fnst@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.