From: songjun.wu@atmel.com (Wu, Songjun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings
Date: Wed, 13 Apr 2016 17:24:37 +0800 [thread overview]
Message-ID: <570E1055.60806@atmel.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1604131047460.2969@hadrien>
Accept.
Thank you for your comments.
On 4/13/2016 16:49, Julia Lawall wrote:
> Move constants to the right of binary operators.
>
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
>
> CC: Songjun Wu <songjun.wu@atmel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Up to you. Seems a tiny bit more readable to me not to have ISC_DCTRL and
> ISC_DCTRL_IE_IS right together.
>
> atmel-isc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/media/platform/atmel/atmel-isc.c
> +++ b/drivers/media/platform/atmel/atmel-isc.c
> @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct
>
> addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0);
>
> - regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview);
> + regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS);
> regmap_write(regmap, ISC_DAD0, addr);
> regmap_update_bits(regmap, ISC_CTRLEN,
> ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE);
>
WARNING: multiple messages have this Message-ID (diff)
From: "Wu, Songjun" <songjun.wu@atmel.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: linux-arm-kernel@lists.infradead.org,
"Mauro Carvalho Chehab" <mchehab@osg.samsung.com>,
"Hans Verkuil" <hverkuil@xs4all.nl>,
"Sudip Mukherjee" <sudipm.mukherjee@gmail.com>,
"Mikhail Ulyanov" <mikhail.ulyanov@cogentembedded.com>,
"Fabien Dessenne" <fabien.dessenne@st.com>,
"Peter Griffin" <peter.griffin@linaro.org>,
"Benoit Parrot" <bparrot@ti.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Richard Röjfors" <richard@puffinpack.se>,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
kbuild@01.org, g.liakhovetski@gmx.de, nicolas.ferre@atmel.com
Subject: Re: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings
Date: Wed, 13 Apr 2016 17:24:37 +0800 [thread overview]
Message-ID: <570E1055.60806@atmel.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1604131047460.2969@hadrien>
Accept.
Thank you for your comments.
On 4/13/2016 16:49, Julia Lawall wrote:
> Move constants to the right of binary operators.
>
> Generated by: scripts/coccinelle/misc/compare_const_fl.cocci
>
> CC: Songjun Wu <songjun.wu@atmel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
>
> Up to you. Seems a tiny bit more readable to me not to have ISC_DCTRL and
> ISC_DCTRL_IE_IS right together.
>
> atmel-isc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/media/platform/atmel/atmel-isc.c
> +++ b/drivers/media/platform/atmel/atmel-isc.c
> @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct
>
> addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0);
>
> - regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview);
> + regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS);
> regmap_write(regmap, ISC_DAD0, addr);
> regmap_update_bits(regmap, ISC_CTRLEN,
> ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE);
>
next prev parent reply other threads:[~2016-04-13 9:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-13 8:49 [PATCH] atmel-isc: fix compare_const_fl.cocci warnings Julia Lawall
2016-04-13 8:49 ` Julia Lawall
2016-04-13 9:24 ` Wu, Songjun [this message]
2016-04-13 9:24 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E1055.60806@atmel.com \
--to=songjun.wu@atmel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.