* [PATCH] atmel-isc: fix compare_const_fl.cocci warnings @ 2016-04-13 8:49 ` Julia Lawall 0 siblings, 0 replies; 4+ messages in thread From: Julia Lawall @ 2016-04-13 8:49 UTC (permalink / raw) To: linux-arm-kernel Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Songjun Wu <songjun.wu@atmel.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> --- Up to you. Seems a tiny bit more readable to me not to have ISC_DCTRL and ISC_DCTRL_IE_IS right together. atmel-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/platform/atmel/atmel-isc.c +++ b/drivers/media/platform/atmel/atmel-isc.c @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0); - regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview); + regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS); regmap_write(regmap, ISC_DAD0, addr); regmap_update_bits(regmap, ISC_CTRLEN, ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE); ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] atmel-isc: fix compare_const_fl.cocci warnings @ 2016-04-13 8:49 ` Julia Lawall 0 siblings, 0 replies; 4+ messages in thread From: Julia Lawall @ 2016-04-13 8:49 UTC (permalink / raw) To: Songjun Wu Cc: linux-arm-kernel, Mauro Carvalho Chehab, Hans Verkuil, Sudip Mukherjee, Mikhail Ulyanov, Fabien Dessenne, Peter Griffin, Benoit Parrot, Laurent Pinchart, Gerd Hoffmann, Richard Röjfors, linux-kernel, linux-media, kbuild, g.liakhovetski, nicolas.ferre Move constants to the right of binary operators. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Songjun Wu <songjun.wu@atmel.com> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> --- Up to you. Seems a tiny bit more readable to me not to have ISC_DCTRL and ISC_DCTRL_IE_IS right together. atmel-isc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/platform/atmel/atmel-isc.c +++ b/drivers/media/platform/atmel/atmel-isc.c @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0); - regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview); + regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS); regmap_write(regmap, ISC_DAD0, addr); regmap_update_bits(regmap, ISC_CTRLEN, ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE); ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] atmel-isc: fix compare_const_fl.cocci warnings 2016-04-13 8:49 ` Julia Lawall @ 2016-04-13 9:24 ` Wu, Songjun -1 siblings, 0 replies; 4+ messages in thread From: Wu, Songjun @ 2016-04-13 9:24 UTC (permalink / raw) To: linux-arm-kernel Accept. Thank you for your comments. On 4/13/2016 16:49, Julia Lawall wrote: > Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > CC: Songjun Wu <songjun.wu@atmel.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > --- > > Up to you. Seems a tiny bit more readable to me not to have ISC_DCTRL and > ISC_DCTRL_IE_IS right together. > > atmel-isc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/media/platform/atmel/atmel-isc.c > +++ b/drivers/media/platform/atmel/atmel-isc.c > @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct > > addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0); > > - regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview); > + regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS); > regmap_write(regmap, ISC_DAD0, addr); > regmap_update_bits(regmap, ISC_CTRLEN, > ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE); > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] atmel-isc: fix compare_const_fl.cocci warnings @ 2016-04-13 9:24 ` Wu, Songjun 0 siblings, 0 replies; 4+ messages in thread From: Wu, Songjun @ 2016-04-13 9:24 UTC (permalink / raw) To: Julia Lawall Cc: linux-arm-kernel, Mauro Carvalho Chehab, Hans Verkuil, Sudip Mukherjee, Mikhail Ulyanov, Fabien Dessenne, Peter Griffin, Benoit Parrot, Laurent Pinchart, Gerd Hoffmann, Richard Röjfors, linux-kernel, linux-media, kbuild, g.liakhovetski, nicolas.ferre Accept. Thank you for your comments. On 4/13/2016 16:49, Julia Lawall wrote: > Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > CC: Songjun Wu <songjun.wu@atmel.com> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > --- > > Up to you. Seems a tiny bit more readable to me not to have ISC_DCTRL and > ISC_DCTRL_IE_IS right together. > > atmel-isc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/media/platform/atmel/atmel-isc.c > +++ b/drivers/media/platform/atmel/atmel-isc.c > @@ -639,7 +639,7 @@ static inline void isc_start_dma(struct > > addr = vb2_dma_contig_plane_dma_addr(&frm->vb.vb2_buf, 0); > > - regmap_write(regmap, ISC_DCTRL, ISC_DCTRL_IE_IS | dview); > + regmap_write(regmap, ISC_DCTRL, dview | ISC_DCTRL_IE_IS); > regmap_write(regmap, ISC_DAD0, addr); > regmap_update_bits(regmap, ISC_CTRLEN, > ISC_CTRLEN_CAPTURE_MASK, ISC_CTRLEN_CAPTURE); > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-04-13 9:24 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2016-04-13 8:49 [PATCH] atmel-isc: fix compare_const_fl.cocci warnings Julia Lawall 2016-04-13 8:49 ` Julia Lawall 2016-04-13 9:24 ` Wu, Songjun 2016-04-13 9:24 ` Wu, Songjun
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.