All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [uboot] [PATCH v5 5/7] net: phy: Move is_rgmii helper to phy.h
Date: Wed, 13 Apr 2016 08:37:54 -0500	[thread overview]
Message-ID: <570E4BB2.2090907@ti.com> (raw)
In-Reply-To: <1460377108-19262-5-git-send-email-dmurphy@ti.com>

Adding Joe

On 04/11/2016 07:18 AM, Dan Murphy wrote:
> Move the phy_interface_is_rgmii to the phy.h
> file for all phy's to be able to use the API.
>
> This now aligns with the Linux kernel based on
> commit e463d88c36d42211aa72ed76d32fb8bf37820ef1
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v5 - No change
>
>  drivers/net/phy/ti.c | 11 -----------
>  include/phy.h        | 11 +++++++++++
>  2 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c
> index b8f3ebd..b1f1ec8 100644
> --- a/drivers/net/phy/ti.c
> +++ b/drivers/net/phy/ti.c
> @@ -156,17 +156,6 @@ void phy_write_mmd_indirect(struct phy_device *phydev, int prtad,
>  	phy_write(phydev, addr, MII_MMD_DATA, data);
>  }
>  
> -/**
> - * phy_interface_is_rgmii - Convenience function for testing if a PHY interface
> - * is RGMII (all variants)
> - * @phydev: the phy_device struct
> - */
> -static inline bool phy_interface_is_rgmii(struct phy_device *phydev)
> -{
> -	return phydev->interface >= PHY_INTERFACE_MODE_RGMII &&
> -		phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID;
> -}
> -
>  #if defined(CONFIG_DM_ETH)
>  /**
>   * dp83867_data_init - Convenience function for setting PHY specific data
> diff --git a/include/phy.h b/include/phy.h
> index 21459a8..7b2d1ff 100644
> --- a/include/phy.h
> +++ b/include/phy.h
> @@ -277,6 +277,17 @@ int get_phy_id(struct mii_dev *bus, int addr, int devad, u32 *phy_id);
>   */
>  int phy_get_interface_by_name(const char *str);
>  
> +/**
> + * phy_interface_is_rgmii - Convenience function for testing if a PHY interface
> + * is RGMII (all variants)
> + * @phydev: the phy_device struct
> + */
> +static inline bool phy_interface_is_rgmii(struct phy_device *phydev)
> +{
> +	return phydev->interface >= PHY_INTERFACE_MODE_RGMII &&
> +		phydev->interface <= PHY_INTERFACE_MODE_RGMII_TXID;
> +}
> +
>  /* PHY UIDs for various PHYs that are referenced in external code */
>  #define PHY_UID_CS4340  0x13e51002
>  #define PHY_UID_TN2020	0x00a19410


-- 
------------------
Dan Murphy

  parent reply	other threads:[~2016-04-13 13:37 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-11 12:18 [U-Boot] [uboot] [PATCH v5 1/7] drivers: net: cpsw: Add reading of DT phy-handle node Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 2/7] net: zynq_gem: Add the passing of the " Dan Murphy
2016-04-11 13:05   ` Michal Simek
2016-04-13 13:37   ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 3/7] net: phy: dp83867: Add device tree bindings and documentation Dan Murphy
2016-04-13 13:37   ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 4/7] net: phy: ti: Allow the driver to be more configurable Dan Murphy
2016-04-11 13:06   ` Michal Simek
2016-04-13 13:37   ` Dan Murphy
2016-04-15 11:07   ` Mugunthan V N
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 5/7] net: phy: Move is_rgmii helper to phy.h Dan Murphy
2016-04-11 13:06   ` Michal Simek
2016-04-13 13:37   ` Dan Murphy [this message]
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 6/7] net: phy: Add phy_interface_is_sgmii " Dan Murphy
2016-04-13 13:38   ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 7/7] net: phy: dp83867: Add SGMII helper for configuration Dan Murphy
2016-04-13 13:38   ` Dan Murphy
2016-04-13 13:36 ` [U-Boot] [uboot] [PATCH v5 1/7] drivers: net: cpsw: Add reading of DT phy-handle node Dan Murphy
2016-04-15 10:53 ` Mugunthan V N
2016-04-15 11:03 ` Mugunthan V N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=570E4BB2.2090907@ti.com \
    --to=dmurphy@ti.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.