From: Dan Murphy <dmurphy@ti.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [uboot] [PATCH v5 7/7] net: phy: dp83867: Add SGMII helper for configuration
Date: Wed, 13 Apr 2016 08:38:26 -0500 [thread overview]
Message-ID: <570E4BD2.5070207@ti.com> (raw)
In-Reply-To: <1460377108-19262-7-git-send-email-dmurphy@ti.com>
Adding Joe
On 04/11/2016 07:18 AM, Dan Murphy wrote:
> The code assumed that if the interface is not RGMII configured
> then it must be SGMII configured. This device has the ability
> to support most of the MII interfaces. Therefore add the
> helper for SGMII and only configure the device if the interface is
> configured for SGMII.
>
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>
> v5 - No change
>
> drivers/net/phy/ti.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/ti.c b/drivers/net/phy/ti.c
> index b1f1ec8..f881914 100644
> --- a/drivers/net/phy/ti.c
> +++ b/drivers/net/phy/ti.c
> @@ -219,7 +219,7 @@ static int dp83867_config(struct phy_device *phydev)
> (dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT));
> if (ret)
> goto err_out;
> - } else {
> + } else if (phy_interface_is_sgmii(phydev)) {
> phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR,
> (BMCR_ANENABLE | BMCR_FULLDPLX | BMCR_SPEED1000));
>
--
------------------
Dan Murphy
next prev parent reply other threads:[~2016-04-13 13:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-11 12:18 [U-Boot] [uboot] [PATCH v5 1/7] drivers: net: cpsw: Add reading of DT phy-handle node Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 2/7] net: zynq_gem: Add the passing of the " Dan Murphy
2016-04-11 13:05 ` Michal Simek
2016-04-13 13:37 ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 3/7] net: phy: dp83867: Add device tree bindings and documentation Dan Murphy
2016-04-13 13:37 ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 4/7] net: phy: ti: Allow the driver to be more configurable Dan Murphy
2016-04-11 13:06 ` Michal Simek
2016-04-13 13:37 ` Dan Murphy
2016-04-15 11:07 ` Mugunthan V N
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 5/7] net: phy: Move is_rgmii helper to phy.h Dan Murphy
2016-04-11 13:06 ` Michal Simek
2016-04-13 13:37 ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 6/7] net: phy: Add phy_interface_is_sgmii " Dan Murphy
2016-04-13 13:38 ` Dan Murphy
2016-04-11 12:18 ` [U-Boot] [uboot] [PATCH v5 7/7] net: phy: dp83867: Add SGMII helper for configuration Dan Murphy
2016-04-13 13:38 ` Dan Murphy [this message]
2016-04-13 13:36 ` [U-Boot] [uboot] [PATCH v5 1/7] drivers: net: cpsw: Add reading of DT phy-handle node Dan Murphy
2016-04-15 10:53 ` Mugunthan V N
2016-04-15 11:03 ` Mugunthan V N
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=570E4BD2.5070207@ti.com \
--to=dmurphy@ti.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.