From: Laxman Dewangan <ldewangan@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: linus.walleij@linaro.org, gnurou@gmail.com,
swarren@wwwdotorg.org, linux-gpio@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce
Date: Tue, 19 Apr 2016 18:15:43 +0530 [thread overview]
Message-ID: <57162877.3010508@nvidia.com> (raw)
In-Reply-To: <20160419123754.GE8284@ulmo.ba.sec>
On Tuesday 19 April 2016 06:07 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Tue, Apr 19, 2016 at 03:13:40PM +0530, Laxman Dewangan wrote:
> [...]
>> @@ -570,7 +612,14 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = {
>> .upper_offset = 0x80,
>> };
>>
>> +static struct tegra_gpio_soc_config tegra210_gpio_config = {
>> + .bank_stride = 0x100,
>> + .upper_offset = 0x80,
>> + .debounce_supported = true,
>> +};
>> +
>> static const struct of_device_id tegra_gpio_of_match[] = {
>> + { .compatible = "nvidia,tegra210-gpio", .data = &tegra210_gpio_config },
>> { .compatible = "nvidia,tegra30-gpio", .data = &tegra30_gpio_config },
>> { .compatible = "nvidia,tegra20-gpio", .data = &tegra20_gpio_config },
>> { },
> I think I'd split this hunk off into a separate patch. Oh, and perhaps
> follow up with a patch that makes the SoC configuration data const?
>
OK, then I will do that on follow-on patch:
- Get rid of all global variables.
- Convert the soc config to the constant.
WARNING: multiple messages have this Message-ID (diff)
From: Laxman Dewangan <ldewangan@nvidia.com>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: <linus.walleij@linaro.org>, <gnurou@gmail.com>,
<swarren@wwwdotorg.org>, <linux-gpio@vger.kernel.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce
Date: Tue, 19 Apr 2016 18:15:43 +0530 [thread overview]
Message-ID: <57162877.3010508@nvidia.com> (raw)
In-Reply-To: <20160419123754.GE8284@ulmo.ba.sec>
On Tuesday 19 April 2016 06:07 PM, Thierry Reding wrote:
> * PGP Signed by an unknown key
>
> On Tue, Apr 19, 2016 at 03:13:40PM +0530, Laxman Dewangan wrote:
> [...]
>> @@ -570,7 +612,14 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = {
>> .upper_offset = 0x80,
>> };
>>
>> +static struct tegra_gpio_soc_config tegra210_gpio_config = {
>> + .bank_stride = 0x100,
>> + .upper_offset = 0x80,
>> + .debounce_supported = true,
>> +};
>> +
>> static const struct of_device_id tegra_gpio_of_match[] = {
>> + { .compatible = "nvidia,tegra210-gpio", .data = &tegra210_gpio_config },
>> { .compatible = "nvidia,tegra30-gpio", .data = &tegra30_gpio_config },
>> { .compatible = "nvidia,tegra20-gpio", .data = &tegra20_gpio_config },
>> { },
> I think I'd split this hunk off into a separate patch. Oh, and perhaps
> follow up with a patch that makes the SoC configuration data const?
>
OK, then I will do that on follow-on patch:
- Get rid of all global variables.
- Convert the soc config to the constant.
next prev parent reply other threads:[~2016-04-19 12:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 9:43 [PATCH V2 1/3] gpio: tegra: Don't open code of_device_get_match_data() Laxman Dewangan
2016-04-19 9:43 ` Laxman Dewangan
2016-04-19 9:43 ` [PATCH V2 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver Laxman Dewangan
2016-04-19 9:43 ` Laxman Dewangan
2016-04-19 12:33 ` Thierry Reding
2016-04-19 12:43 ` Laxman Dewangan
2016-04-19 12:43 ` Laxman Dewangan
[not found] ` <571627F5.7000307-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-19 16:04 ` Stephen Warren
2016-04-19 16:04 ` Stephen Warren
2016-04-19 9:43 ` [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce Laxman Dewangan
2016-04-19 9:43 ` Laxman Dewangan
[not found] ` <1461059020-25373-3-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-04-19 10:43 ` Jon Hunter
2016-04-19 10:43 ` Jon Hunter
2016-04-19 12:36 ` Thierry Reding
2016-04-19 12:37 ` Thierry Reding
2016-04-19 12:45 ` Laxman Dewangan [this message]
2016-04-19 12:45 ` Laxman Dewangan
2016-04-19 16:11 ` Stephen Warren
[not found] ` <571658CE.1040306-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2016-04-19 16:19 ` Laxman Dewangan
2016-04-19 16:19 ` Laxman Dewangan
2016-04-19 16:36 ` Stephen Warren
2016-04-19 12:06 ` [PATCH V2 1/3] gpio: tegra: Don't open code of_device_get_match_data() Thierry Reding
2016-04-29 8:56 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57162877.3010508@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.