From: Lars-Peter Clausen <lars@metafoo.de>
To: Bard Liao <bardliao@realtek.com>,
broonie@kernel.org, lgirdwood@gmail.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
john.lin@realtek.com, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5651: remove unexisting widget
Date: Thu, 28 Apr 2016 10:14:55 +0200 [thread overview]
Message-ID: <5721C67F.2080007@metafoo.de> (raw)
In-Reply-To: <1461809581-7863-1-git-send-email-bardliao@realtek.com>
On 04/28/2016 04:13 AM, Bard Liao wrote:
> IN Muxes are not existing on rt5651.
>
> Signed-off-by: Bard Liao <bardliao@realtek.com>
> ---
> sound/soc/codecs/rt5651.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
> index 7a61970..b812c06 100644
> --- a/sound/soc/codecs/rt5651.c
> +++ b/sound/soc/codecs/rt5651.c
> @@ -955,11 +955,6 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = {
> RT5651_PWR_IN2_L_BIT, 0, NULL, 0),
> SND_SOC_DAPM_PGA("INR2 VOL", RT5651_PWR_VOL,
> RT5651_PWR_IN2_R_BIT, 0, NULL, 0),
> - /* IN Mux */
> - SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl1_mux),
> - SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr1_mux),
> - SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl2_mux),
> - SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr2_mux),
What is with the rt5651_in*_mux controls, those are unused now and can be
removed as well, aren't they?
next prev parent reply other threads:[~2016-04-28 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 2:13 [PATCH] ASoC: rt5651: remove unexisting widget Bard Liao
2016-04-28 8:14 ` Lars-Peter Clausen [this message]
2016-04-28 9:08 ` Bard Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5721C67F.2080007@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=john.lin@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.