* [PATCH] ASoC: rt5651: remove unexisting widget
@ 2016-04-28 2:13 Bard Liao
2016-04-28 8:14 ` Lars-Peter Clausen
0 siblings, 1 reply; 3+ messages in thread
From: Bard Liao @ 2016-04-28 2:13 UTC (permalink / raw)
To: broonie, lgirdwood
Cc: oder_chiou, alsa-devel, lars, john.lin, Bard Liao, flove
IN Muxes are not existing on rt5651.
Signed-off-by: Bard Liao <bardliao@realtek.com>
---
sound/soc/codecs/rt5651.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
index 7a61970..b812c06 100644
--- a/sound/soc/codecs/rt5651.c
+++ b/sound/soc/codecs/rt5651.c
@@ -955,11 +955,6 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = {
RT5651_PWR_IN2_L_BIT, 0, NULL, 0),
SND_SOC_DAPM_PGA("INR2 VOL", RT5651_PWR_VOL,
RT5651_PWR_IN2_R_BIT, 0, NULL, 0),
- /* IN Mux */
- SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl1_mux),
- SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr1_mux),
- SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl2_mux),
- SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr2_mux),
/* REC Mixer */
SND_SOC_DAPM_MIXER("RECMIXL", RT5651_PWR_MIXER, RT5651_PWR_RM_L_BIT, 0,
rt5651_rec_l_mix, ARRAY_SIZE(rt5651_rec_l_mix)),
--
1.8.1.1.439.g50a6b54
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: rt5651: remove unexisting widget
2016-04-28 2:13 [PATCH] ASoC: rt5651: remove unexisting widget Bard Liao
@ 2016-04-28 8:14 ` Lars-Peter Clausen
2016-04-28 9:08 ` Bard Liao
0 siblings, 1 reply; 3+ messages in thread
From: Lars-Peter Clausen @ 2016-04-28 8:14 UTC (permalink / raw)
To: Bard Liao, broonie, lgirdwood; +Cc: oder_chiou, alsa-devel, john.lin, flove
On 04/28/2016 04:13 AM, Bard Liao wrote:
> IN Muxes are not existing on rt5651.
>
> Signed-off-by: Bard Liao <bardliao@realtek.com>
> ---
> sound/soc/codecs/rt5651.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/sound/soc/codecs/rt5651.c b/sound/soc/codecs/rt5651.c
> index 7a61970..b812c06 100644
> --- a/sound/soc/codecs/rt5651.c
> +++ b/sound/soc/codecs/rt5651.c
> @@ -955,11 +955,6 @@ static const struct snd_soc_dapm_widget rt5651_dapm_widgets[] = {
> RT5651_PWR_IN2_L_BIT, 0, NULL, 0),
> SND_SOC_DAPM_PGA("INR2 VOL", RT5651_PWR_VOL,
> RT5651_PWR_IN2_R_BIT, 0, NULL, 0),
> - /* IN Mux */
> - SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl1_mux),
> - SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr1_mux),
> - SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inl2_mux),
> - SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0, &rt5651_inr2_mux),
What is with the rt5651_in*_mux controls, those are unused now and can be
removed as well, aren't they?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: rt5651: remove unexisting widget
2016-04-28 8:14 ` Lars-Peter Clausen
@ 2016-04-28 9:08 ` Bard Liao
0 siblings, 0 replies; 3+ messages in thread
From: Bard Liao @ 2016-04-28 9:08 UTC (permalink / raw)
To: Lars-Peter Clausen, broonie@kernel.org, lgirdwood@gmail.com
Cc: Oder Chiou, alsa-devel@alsa-project.org, John Lin, Flove
> > - /* IN Mux */
> > - SND_SOC_DAPM_MUX("INL1 Mux", SND_SOC_NOPM, 0, 0,
> &rt5651_inl1_mux),
> > - SND_SOC_DAPM_MUX("INR1 Mux", SND_SOC_NOPM, 0, 0,
> &rt5651_inr1_mux),
> > - SND_SOC_DAPM_MUX("INL2 Mux", SND_SOC_NOPM, 0, 0,
> &rt5651_inl2_mux),
> > - SND_SOC_DAPM_MUX("INR2 Mux", SND_SOC_NOPM, 0, 0,
> &rt5651_inr2_mux),
>
> What is with the rt5651_in*_mux controls, those are unused now and
> can be removed as well, aren't they?
Thanks for the reminder. I will send v2 soon.
>
>
> ------Please consider the environment before printing this e-mail.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-04-28 9:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-28 2:13 [PATCH] ASoC: rt5651: remove unexisting widget Bard Liao
2016-04-28 8:14 ` Lars-Peter Clausen
2016-04-28 9:08 ` Bard Liao
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.