From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: davem@davemloft.net, netdev@vger.kernel.org,
philipp.reisner@linbit.com, drbd-dev@lists.linbit.com,
linux-kernel@vger.kernel.org
Subject: Re: [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages
Date: Tue, 10 May 2016 11:09:53 +0200 [thread overview]
Message-ID: <5731A561.6090509@6wind.com> (raw)
In-Reply-To: <20160509131547.GX16459@soda.linbit>
Le 09/05/2016 15:15, Lars Ellenberg a écrit :
> On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote:
[snip]
>> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_'
>> could be interesting so that new module won't use it. What is your
>> opinion?
>
> This was supposed to not be DRBD specific. But it might even still
> need some massaging before it was truly generic. And obviously,
> it does not meet the taste of genetlink folks, to say the least :(
Yes, this file is not generic and netlink APIs are never defined like this.
These tons of macro complexifies the code too much. It's overengineering for
what purpose?
Small examples:
- the drbd netlink API is not exported via uapi (I wonder how apps using this
API get it)
- v2 of the patch is nacked because adding a new attribute may break existing
apps (in networking code, a lot of new attributes are added in each version)
- it's not possible to grep to show the definition of an attribute ('git grep
-w T_bits_total' returns only 1 line)
Regards,
Nicolas
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Dichtel <nicolas.dichtel@6wind.com>
To: davem@davemloft.net, netdev@vger.kernel.org,
philipp.reisner@linbit.com, drbd-dev@lists.linbit.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3] block/drbd: align properly u64 in nl messages
Date: Tue, 10 May 2016 11:09:53 +0200 [thread overview]
Message-ID: <5731A561.6090509@6wind.com> (raw)
In-Reply-To: <20160509131547.GX16459@soda.linbit>
Le 09/05/2016 15:15, Lars Ellenberg a écrit :
> On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote:
[snip]
>> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_'
>> could be interesting so that new module won't use it. What is your
>> opinion?
>
> This was supposed to not be DRBD specific. But it might even still
> need some massaging before it was truly generic. And obviously,
> it does not meet the taste of genetlink folks, to say the least :(
Yes, this file is not generic and netlink APIs are never defined like this.
These tons of macro complexifies the code too much. It's overengineering for
what purpose?
Small examples:
- the drbd netlink API is not exported via uapi (I wonder how apps using this
API get it)
- v2 of the patch is nacked because adding a new attribute may break existing
apps (in networking code, a lot of new attributes are added in each version)
- it's not possible to grep to show the definition of an attribute ('git grep
-w T_bits_total' returns only 1 line)
Regards,
Nicolas
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Dichtel <nicolas.dichtel-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
philipp.reisner-63ez5xqkn6DQT0dZR+AlfA@public.gmane.org,
drbd-dev-cunTk1MwBs8qoQakbn7OcQ@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH net-next v3] block/drbd: align properly u64 in nl messages
Date: Tue, 10 May 2016 11:09:53 +0200 [thread overview]
Message-ID: <5731A561.6090509@6wind.com> (raw)
In-Reply-To: <20160509131547.GX16459-w1SgEEioFePxa46PmUWvFg@public.gmane.org>
Le 09/05/2016 15:15, Lars Ellenberg a écrit :
> On Mon, May 09, 2016 at 11:40:20AM +0200, Nicolas Dichtel wrote:
[snip]
>> Maybe prefixing genl_magic_func.h and genl_magic_struct.h by 'drbd_'
>> could be interesting so that new module won't use it. What is your
>> opinion?
>
> This was supposed to not be DRBD specific. But it might even still
> need some massaging before it was truly generic. And obviously,
> it does not meet the taste of genetlink folks, to say the least :(
Yes, this file is not generic and netlink APIs are never defined like this.
These tons of macro complexifies the code too much. It's overengineering for
what purpose?
Small examples:
- the drbd netlink API is not exported via uapi (I wonder how apps using this
API get it)
- v2 of the patch is nacked because adding a new attribute may break existing
apps (in networking code, a lot of new attributes are added in each version)
- it's not possible to grep to show the definition of an attribute ('git grep
-w T_bits_total' returns only 1 line)
Regards,
Nicolas
next prev parent reply other threads:[~2016-05-10 9:12 UTC|newest]
Thread overview: 94+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-26 8:06 [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 1/8] macsec: use nla_put_u64_64bit() Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 2/8] drivers/wireless: " Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 3/8] fs/quota: " Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 11:08 ` Jan Kara
2016-04-26 11:08 ` Jan Kara
2016-04-26 11:08 ` [Drbd-dev] " Jan Kara
2016-04-26 12:31 ` Nicolas Dichtel
2016-04-26 12:31 ` Nicolas Dichtel
2016-04-26 12:31 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 12:37 ` Jan Kara
2016-04-26 12:37 ` Jan Kara
2016-04-26 12:37 ` [Drbd-dev] " Jan Kara
2016-04-26 16:24 ` David Miller
2016-04-26 8:06 ` [PATCH net-next 4/8] sock_diag: align nlattr properly when needed Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 5/8] ovs: " Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 6/8] rtnl: " Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 7/8] neigh: " Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 8:06 ` [PATCH net-next 8/8] sched: " Nicolas Dichtel
2016-04-26 8:06 ` Nicolas Dichtel
2016-04-26 8:06 ` [Drbd-dev] " Nicolas Dichtel
2016-04-26 11:54 ` [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) Lars Ellenberg
2016-04-26 11:54 ` Lars Ellenberg
2016-04-26 11:54 ` [Drbd-dev] " Lars Ellenberg
2016-04-26 12:18 ` Lars Ellenberg
2016-04-26 12:18 ` Lars Ellenberg
2016-05-03 8:50 ` [Drbd-dev] [PATCH net-next] block/drbd: use nla_put_u64_64bit() Nicolas Dichtel
2016-05-03 8:50 ` Nicolas Dichtel
2016-05-03 9:28 ` [Drbd-dev] " Nicolas Dichtel
2016-05-03 9:28 ` Nicolas Dichtel
2016-05-03 9:39 ` [Drbd-dev] [PATCH net-next v2] " Nicolas Dichtel
2016-05-03 9:39 ` Nicolas Dichtel
2016-05-03 10:06 ` [Drbd-dev] " Lars Ellenberg
2016-05-03 10:06 ` Lars Ellenberg
2016-05-03 10:06 ` Lars Ellenberg
2016-05-03 12:07 ` [Drbd-dev] " Nicolas Dichtel
2016-05-03 12:07 ` Nicolas Dichtel
2016-05-03 16:05 ` [Drbd-dev] " David Miller
2016-05-03 16:05 ` David Miller
2016-05-04 9:05 ` [Drbd-dev] " Lars Ellenberg
2016-05-04 9:05 ` Lars Ellenberg
2016-05-04 9:05 ` Lars Ellenberg
2016-05-04 12:49 ` [Drbd-dev] " Nicolas Dichtel
2016-05-04 12:49 ` Nicolas Dichtel
2016-05-04 12:52 ` [Drbd-dev] " Lars Ellenberg
2016-05-04 12:52 ` Lars Ellenberg
2016-05-04 12:52 ` [Drbd-dev] " Lars Ellenberg
2016-05-04 14:27 ` Eric Dumazet
2016-05-04 14:27 ` Eric Dumazet
2016-05-04 16:50 ` [Drbd-dev] " David Miller
2016-05-04 16:50 ` David Miller
2016-05-04 17:13 ` [Drbd-dev] " Eric Dumazet
2016-05-04 17:13 ` Eric Dumazet
2016-05-04 16:47 ` David Miller
2016-05-03 16:06 ` [Drbd-dev] " David Miller
2016-05-03 16:06 ` David Miller
2016-05-09 9:40 ` [Drbd-dev] [PATCH net-next v3] block/drbd: align properly u64 in nl messages Nicolas Dichtel
2016-05-09 9:40 ` Nicolas Dichtel
2016-05-09 13:15 ` [Drbd-dev] " Lars Ellenberg
2016-05-09 13:15 ` Lars Ellenberg
2016-05-09 13:15 ` Lars Ellenberg
2016-05-10 9:09 ` Nicolas Dichtel [this message]
2016-05-10 9:09 ` Nicolas Dichtel
2016-05-10 9:09 ` Nicolas Dichtel
2016-05-10 9:40 ` [Drbd-dev] " Lars Ellenberg
2016-05-10 9:40 ` Lars Ellenberg
2016-05-10 9:40 ` [Drbd-dev] " Lars Ellenberg
2016-05-10 10:06 ` Nicolas Dichtel
2016-05-10 15:39 ` David Miller
2016-05-10 15:39 ` David Miller
2016-05-10 19:09 ` Lars Ellenberg
2016-05-10 19:09 ` Lars Ellenberg
2016-05-10 19:09 ` [Drbd-dev] " Lars Ellenberg
2016-05-10 19:26 ` David Miller
2016-05-10 19:26 ` David Miller
2016-04-26 16:25 ` [PATCH net-next 0/8] netlink: align attributes when needed (patchset #3) David Miller
2016-04-26 16:25 ` David Miller
2016-04-26 16:25 ` [Drbd-dev] " David Miller
2016-04-26 16:02 ` David Miller
2016-04-26 16:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5731A561.6090509@6wind.com \
--to=nicolas.dichtel@6wind.com \
--cc=davem@davemloft.net \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.