All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Foss <robert.foss@collabora.com>
To: Eric Anholt <eric@anholt.net>,
	daniel.vetter@ffwll.ch, airlied@linux.ieaniel.vetter@ffwll.ch,
	fengguang.wu@intel.com, maarten.lankhorst@linux.intel.com,
	julia.lawall@lip6.fr, alexander.deucher@amd.com,
	daniels@collabora.com, derekf@osg.samsung.com,
	varadgautam@gmail.com
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event.
Date: Tue, 10 May 2016 13:19:42 -0400	[thread overview]
Message-ID: <5732182E.6090100@collabora.com> (raw)
In-Reply-To: <87eg99yha2.fsf@eliezer.anholt.net>

Thanks Eric!

On 2016-05-10 01:06 PM, Eric Anholt wrote:
> Robert Foss <robert.foss@collabora.com> writes:
>
>> On 2016-05-03 03:22 PM, Eric Anholt wrote:
>>> robert.foss@collabora.com writes:
>>>
>>>> From: Robert Foss <robert.foss@collabora.com>
>>>>
>>>> As per the documentation in drm_crtc.h, atomic_commit should return
>>>> -EBUSY if an asycnhronous update is requested and there is an earlier
>>>> update pending.
>>>>
>>>> Note: docs cited here are drm_crtc.h, and the whole quote is:
>>>>
>>>>       *  - -EBUSY, if an asynchronous updated is requested and there is
>>>>       *    an earlier updated pending. Drivers are allowed to support a queue
>>>>       *    of outstanding updates, but currently no driver supports that.
>>>>       *    Note that drivers must wait for preceding updates to complete if a
>>>>       *    synchronous update is requested, they are not allowed to fail the
>>>>       *    commit in that case.
>>>>
>>>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>>>
>>> This looks good to me.  Let's give it a few days on the list for any
>>> other KMS folks to catch anything.
>>>
>>
>> I haven't seen any further feedback regarding this patch.
>> Does anyone have objections to it being merged?
>
> I merged it to drm-vc4-next last night, actually :)
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Robert Foss <robert.foss@collabora.com>
To: Eric Anholt <eric@anholt.net>,
	daniel.vetter@ffwll.ch, airlied@linux.ie, aniel.vetter@ffwll.ch,
	fengguang.wu@intel.com, maarten.lankhorst@linux.intel.com,
	julia.lawall@lip6.fr, alexander.deucher@amd.com,
	daniels@collabora.com, derekf@osg.samsung.com,
	varadgautam@gmail.com
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event.
Date: Tue, 10 May 2016 13:19:42 -0400	[thread overview]
Message-ID: <5732182E.6090100@collabora.com> (raw)
In-Reply-To: <87eg99yha2.fsf@eliezer.anholt.net>

Thanks Eric!

On 2016-05-10 01:06 PM, Eric Anholt wrote:
> Robert Foss <robert.foss@collabora.com> writes:
>
>> On 2016-05-03 03:22 PM, Eric Anholt wrote:
>>> robert.foss@collabora.com writes:
>>>
>>>> From: Robert Foss <robert.foss@collabora.com>
>>>>
>>>> As per the documentation in drm_crtc.h, atomic_commit should return
>>>> -EBUSY if an asycnhronous update is requested and there is an earlier
>>>> update pending.
>>>>
>>>> Note: docs cited here are drm_crtc.h, and the whole quote is:
>>>>
>>>>       *  - -EBUSY, if an asynchronous updated is requested and there is
>>>>       *    an earlier updated pending. Drivers are allowed to support a queue
>>>>       *    of outstanding updates, but currently no driver supports that.
>>>>       *    Note that drivers must wait for preceding updates to complete if a
>>>>       *    synchronous update is requested, they are not allowed to fail the
>>>>       *    commit in that case.
>>>>
>>>> Signed-off-by: Robert Foss <robert.foss@collabora.com>
>>>
>>> This looks good to me.  Let's give it a few days on the list for any
>>> other KMS folks to catch anything.
>>>
>>
>> I haven't seen any further feedback regarding this patch.
>> Does anyone have objections to it being merged?
>
> I merged it to drm-vc4-next last night, actually :)
>

  reply	other threads:[~2016-05-10 17:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-03 17:48 [PATCH v2] drm/vc4: Return -EBUSY if there's already a pending flip event robert.foss
2016-05-03 17:48 ` robert.foss
2016-05-03 19:22 ` Eric Anholt
2016-05-03 19:22   ` Eric Anholt
2016-05-10 15:35   ` Robert Foss
2016-05-10 15:35     ` Robert Foss
2016-05-10 17:06     ` Eric Anholt
2016-05-10 17:06       ` Eric Anholt
2016-05-10 17:19       ` Robert Foss [this message]
2016-05-10 17:19         ` Robert Foss

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5732182E.6090100@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=airlied@linux.ieaniel.vetter \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.