From: Thomas Huth <thuth@redhat.com>
To: Paul Mackerras <paulus@ozlabs.org>, Alexander Graf <agraf@suse.de>
Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc: Fix definition of SIAR register
Date: Thu, 12 May 2016 07:27:40 +0000 [thread overview]
Message-ID: <5734306C.7070407@redhat.com> (raw)
In-Reply-To: <20160512045756.GB1421@oak.ozlabs.ibm.com>
On 12.05.2016 06:57, Paul Mackerras wrote:
> On Mon, Apr 25, 2016 at 10:15:47AM +0200, Alexander Graf wrote:
>>
>>>> +#define SPRN_SIAR 796
>>
>> I'm sure there's a reason (iSeries?) we used the r/o version before. Better introduce a new constant that gives us rw access and use that in the kvm entry/exit code.
>
> I don't think we ever did any performance monitoring on iSeries, and
> in any case, we have removed the iSeries code. I think we should just
> use the privileged, read/write number (i.e. 796).
Ok, then I'll simply add the fix for SDAR to my patch as well, test it
and submit it again.
Thomas
WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Paul Mackerras <paulus@ozlabs.org>, Alexander Graf <agraf@suse.de>
Cc: Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
Michael Ellerman <mpe@ellerman.id.au>,
linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH] powerpc: Fix definition of SIAR register
Date: Thu, 12 May 2016 09:27:40 +0200 [thread overview]
Message-ID: <5734306C.7070407@redhat.com> (raw)
In-Reply-To: <20160512045756.GB1421@oak.ozlabs.ibm.com>
On 12.05.2016 06:57, Paul Mackerras wrote:
> On Mon, Apr 25, 2016 at 10:15:47AM +0200, Alexander Graf wrote:
>>
>>>> +#define SPRN_SIAR 796
>>
>> I'm sure there's a reason (iSeries?) we used the r/o version before. Better introduce a new constant that gives us rw access and use that in the kvm entry/exit code.
>
> I don't think we ever did any performance monitoring on iSeries, and
> in any case, we have removed the iSeries code. I think we should just
> use the privileged, read/write number (i.e. 796).
Ok, then I'll simply add the fix for SDAR to my patch as well, test it
and submit it again.
Thomas
next prev parent reply other threads:[~2016-05-12 7:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-08 15:54 [PATCH] powerpc: Fix definition of SIAR register Thomas Huth
2016-04-08 15:54 ` Thomas Huth
2016-04-25 6:50 ` Thomas Huth
2016-04-25 6:50 ` Thomas Huth
2016-04-25 8:08 ` Madhavan Srinivasan
2016-04-25 8:20 ` Madhavan Srinivasan
2016-04-25 8:15 ` Alexander Graf
2016-04-25 8:15 ` Alexander Graf
2016-04-25 9:16 ` Thomas Huth
2016-04-25 9:16 ` Thomas Huth
2016-04-25 9:31 ` Alexander Graf
2016-04-25 9:31 ` Alexander Graf
2016-04-25 11:15 ` Madhavan Srinivasan
2016-04-25 11:27 ` Madhavan Srinivasan
2016-05-12 4:57 ` Paul Mackerras
2016-05-12 4:57 ` Paul Mackerras
2016-05-12 7:27 ` Thomas Huth [this message]
2016-05-12 7:27 ` Thomas Huth
2016-05-12 10:40 ` Paul Mackerras
2016-05-12 10:40 ` Paul Mackerras
2016-05-12 4:51 ` Paul Mackerras
2016-05-12 4:51 ` Paul Mackerras
2016-05-12 11:26 ` [PATCH] powerpc: Fix definition of SIAR and SDAR registers Thomas Huth
2016-05-12 11:26 ` Thomas Huth
2016-05-13 3:35 ` Paul Mackerras
2016-05-13 3:35 ` Paul Mackerras
2016-05-30 8:04 ` Thomas Huth
2016-05-30 8:04 ` Thomas Huth
2016-05-30 23:27 ` Michael Ellerman
2016-05-30 23:27 ` Michael Ellerman
2016-05-31 10:17 ` Michael Ellerman
2016-05-31 10:17 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5734306C.7070407@redhat.com \
--to=thuth@redhat.com \
--cc=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.