All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@ozlabs.org>,
	linuxppc-dev@lists.ozlabs.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	kvm-ppc@vger.kernel.org, Alexander Graf <agraf@suse.de>,
	Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc: Fix definition of SIAR and SDAR registers
Date: Mon, 30 May 2016 08:04:47 +0000	[thread overview]
Message-ID: <574BF41F.4050305@redhat.com> (raw)
In-Reply-To: <20160513033546.GA22018@oak.ozlabs.ibm.com>

On 13.05.2016 05:35, Paul Mackerras wrote:
> On Thu, May 12, 2016 at 01:26:44PM +0200, Thomas Huth wrote:
>> The SIAR and SDAR registers are available twice, one time as SPRs
>> 780 / 781 (unprivileged, but read-only), and one time as the SPRs
>> 796 / 797 (privileged, but read and write). The Linux kernel code
>> currently uses the unprivileged  SPRs - while this is OK for reading,
>> writing to that register of course does not work.
>> Since the KVM code tries to write to this register, too (see the mtspr
>> in book3s_hv_rmhandlers.S), the contents of this register sometimes get
>> lost for the guests, e.g. during migration of a VM.
>> To fix this issue, simply switch to the privileged SPR numbers instead.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> 
> Acked-by: Paul Mackerras <paulus@ozlabs.org>

*ping*

Michael, could you please pick this patch up? I think it should rather
go through the generic powerpc tree instead of kvm-ppc, since it also
affects other parts than just KVM...

Thanks,
 Thomas


WARNING: multiple messages have this Message-ID (diff)
From: Thomas Huth <thuth@redhat.com>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: Paul Mackerras <paulus@ozlabs.org>,
	linuxppc-dev@lists.ozlabs.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	kvm-ppc@vger.kernel.org, Alexander Graf <agraf@suse.de>,
	Madhavan Srinivasan <maddy@linux.vnet.ibm.com>
Subject: Re: [PATCH] powerpc: Fix definition of SIAR and SDAR registers
Date: Mon, 30 May 2016 10:04:47 +0200	[thread overview]
Message-ID: <574BF41F.4050305@redhat.com> (raw)
In-Reply-To: <20160513033546.GA22018@oak.ozlabs.ibm.com>

On 13.05.2016 05:35, Paul Mackerras wrote:
> On Thu, May 12, 2016 at 01:26:44PM +0200, Thomas Huth wrote:
>> The SIAR and SDAR registers are available twice, one time as SPRs
>> 780 / 781 (unprivileged, but read-only), and one time as the SPRs
>> 796 / 797 (privileged, but read and write). The Linux kernel code
>> currently uses the unprivileged  SPRs - while this is OK for reading,
>> writing to that register of course does not work.
>> Since the KVM code tries to write to this register, too (see the mtspr
>> in book3s_hv_rmhandlers.S), the contents of this register sometimes get
>> lost for the guests, e.g. during migration of a VM.
>> To fix this issue, simply switch to the privileged SPR numbers instead.
>>
>> Signed-off-by: Thomas Huth <thuth@redhat.com>
> 
> Acked-by: Paul Mackerras <paulus@ozlabs.org>

*ping*

Michael, could you please pick this patch up? I think it should rather
go through the generic powerpc tree instead of kvm-ppc, since it also
affects other parts than just KVM...

Thanks,
 Thomas

  reply	other threads:[~2016-05-30  8:04 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-08 15:54 [PATCH] powerpc: Fix definition of SIAR register Thomas Huth
2016-04-08 15:54 ` Thomas Huth
2016-04-25  6:50 ` Thomas Huth
2016-04-25  6:50   ` Thomas Huth
2016-04-25  8:08 ` Madhavan Srinivasan
2016-04-25  8:20   ` Madhavan Srinivasan
2016-04-25  8:15   ` Alexander Graf
2016-04-25  8:15     ` Alexander Graf
2016-04-25  9:16     ` Thomas Huth
2016-04-25  9:16       ` Thomas Huth
2016-04-25  9:31       ` Alexander Graf
2016-04-25  9:31         ` Alexander Graf
2016-04-25 11:15     ` Madhavan Srinivasan
2016-04-25 11:27       ` Madhavan Srinivasan
2016-05-12  4:57     ` Paul Mackerras
2016-05-12  4:57       ` Paul Mackerras
2016-05-12  7:27       ` Thomas Huth
2016-05-12  7:27         ` Thomas Huth
2016-05-12 10:40         ` Paul Mackerras
2016-05-12 10:40           ` Paul Mackerras
2016-05-12  4:51 ` Paul Mackerras
2016-05-12  4:51   ` Paul Mackerras
2016-05-12 11:26 ` [PATCH] powerpc: Fix definition of SIAR and SDAR registers Thomas Huth
2016-05-12 11:26   ` Thomas Huth
2016-05-13  3:35   ` Paul Mackerras
2016-05-13  3:35     ` Paul Mackerras
2016-05-30  8:04     ` Thomas Huth [this message]
2016-05-30  8:04       ` Thomas Huth
2016-05-30 23:27       ` Michael Ellerman
2016-05-30 23:27         ` Michael Ellerman
2016-05-31 10:17   ` Michael Ellerman
2016-05-31 10:17     ` Michael Ellerman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=574BF41F.4050305@redhat.com \
    --to=thuth@redhat.com \
    --cc=agraf@suse.de \
    --cc=benh@kernel.crashing.org \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=maddy@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=paulus@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.