Re: [Qemu-trivial] [PATCH for 2.6] configure: Allow builds -Weverything

[Stefan Weil <sw@weilnetz.de>]

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]

Am 29.04.2016 um 10:51 schrieb Peter Maydell:
> On 28 April 2016 at 22:33, Stefan Weil <sw@weilnetz.de> wrote:
>> The clang compiler supports a useful compiler option -Weverything.
>>
>> As this option triggers warnings in glib header files, too, testing
>> glib with -Werror will always fail. A size mismatch is also detected
>> without -Werror, so simply remove it.
>>
>> Signed-off-by: Stefan Weil <sw@weilnetz.de>
>> ---
>>
>> With this patch, it is possible to build QEMU using this configuration:
>>
>> ./configure' --cc=clang-3.7 --cxx=clang++-3.7 --extra-cflags="-Weverything -DHAVE_FSXATTR" --disable-werror
>>
>> (HAVE_FSXATTR avoids a fatal build error because of structure redefinition)
> 
> No objection to the patch, but not for 2.6 at this stage I think.
> 
> (Does the configure patch re fsxattr that got a ping today
> avoid your need to define HAVE_FSXATTR by hand?)
> 
> thanks
> -- PMM
> 

I think this patch which was too late for 2.6.0 is a candidate for
qemu-trivial, maybe also for qemu-stable. CC both mailing lists.

Stefan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]