Re: [Qemu-trivial] [PATCH for 2.6] configure: Allow builds -Weverything

[Paolo Bonzini <pbonzini@redhat.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1074 bytes --]



On 16/05/2016 14:32, Stefan Weil wrote:
> Am 16.05.2016 um 14:22 schrieb Paolo Bonzini:
>>
>>
>> On 16/05/2016 13:27, Stefan Weil wrote:
>>> I think this patch which was too late for 2.6.0 is a candidate for
>>> qemu-trivial, maybe also for qemu-stable. CC both mailing lists.
>>
>> Yes, it is confusing to have --disable-werror compilations break because
>> of warnings becoming errors.  However, the subject is imprecise, what about:
>>
>> ----
>> configure: Allow builds with extra warnings
>>
>> The clang compiler supports a useful compiler option -Weverything,
>> and GCC also has other warnings not enabled by -Wall.
>>
>> If glib header files trigger a warning, however, testing glib with
>> -Werror will always fail. A size mismatch is also detected without
>> -Werror, so simply remove it.
>> ----
>>
>> Thanks,
>>
>> Paolo
> 
> 
> Yes, that's a better description. Maybe Michael can use it when
> applying the patch.

I'm sending a pull request with all sort of patches in a couple days, I
can include this one too.

Paolo


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]