From: Matt Redfearn <matt.redfearn@imgtec.com>
To: Paul Burton <paul.burton@imgtec.com>, <linux-mips@linux-mips.org>,
"Ralf Baechle" <ralf@linux-mips.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
<linux-kernel@vger.kernel.org>, "Joe Perches" <joe@perches.com>,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH 1/3] MIPS: Clear Status IPL field when using EIC
Date: Wed, 18 May 2016 07:53:21 +0100 [thread overview]
Message-ID: <573C1161.6060608@imgtec.com> (raw)
In-Reply-To: <1463495466-29689-2-git-send-email-paul.burton@imgtec.com>
On 17/05/16 15:31, Paul Burton wrote:
> When using an external interrupt controller (EIC) the interrupt mask
> bits in the cop0 Status register are reused for the Interrupt Priority
> Level, and any interrupts with a priority lower than the field will be
> ignored. Clear the field to 0 by default such that all interrupts are
> serviced. Without doing so we default to arbitrarily ignoring all or
> some subset of interrupts.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> ---
>
> arch/mips/kernel/irq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
> index 8eb5af8..f25f7ea 100644
> --- a/arch/mips/kernel/irq.c
> +++ b/arch/mips/kernel/irq.c
> @@ -54,6 +54,9 @@ void __init init_IRQ(void)
> for (i = 0; i < NR_IRQS; i++)
> irq_set_noprobe(i);
>
> + if (cpu_has_veic)
> + clear_c0_status(ST0_IM);
> +
> arch_init_irq();
> }
>
Hi Paul
Reviewed-by: Matt Redfearn <matt.redfearn@imgtec.com>
Tested-by: Matt Redfearn <matt.redfearn@imgtec.com>
WARNING: multiple messages have this Message-ID (diff)
From: Matt Redfearn <matt.redfearn@imgtec.com>
To: Paul Burton <paul.burton@imgtec.com>,
linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
James Hogan <james.hogan@imgtec.com>
Subject: Re: [PATCH 1/3] MIPS: Clear Status IPL field when using EIC
Date: Wed, 18 May 2016 07:53:21 +0100 [thread overview]
Message-ID: <573C1161.6060608@imgtec.com> (raw)
Message-ID: <20160518065321.M2SP17OYZwQ27blMAoMm3Fg-Z7V6h9Nba8YMG-opJqo@z> (raw)
In-Reply-To: <1463495466-29689-2-git-send-email-paul.burton@imgtec.com>
On 17/05/16 15:31, Paul Burton wrote:
> When using an external interrupt controller (EIC) the interrupt mask
> bits in the cop0 Status register are reused for the Interrupt Priority
> Level, and any interrupts with a priority lower than the field will be
> ignored. Clear the field to 0 by default such that all interrupts are
> serviced. Without doing so we default to arbitrarily ignoring all or
> some subset of interrupts.
>
> Signed-off-by: Paul Burton <paul.burton@imgtec.com>
> ---
>
> arch/mips/kernel/irq.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
> index 8eb5af8..f25f7ea 100644
> --- a/arch/mips/kernel/irq.c
> +++ b/arch/mips/kernel/irq.c
> @@ -54,6 +54,9 @@ void __init init_IRQ(void)
> for (i = 0; i < NR_IRQS; i++)
> irq_set_noprobe(i);
>
> + if (cpu_has_veic)
> + clear_c0_status(ST0_IM);
> +
> arch_init_irq();
> }
>
Hi Paul
Reviewed-by: Matt Redfearn <matt.redfearn@imgtec.com>
Tested-by: Matt Redfearn <matt.redfearn@imgtec.com>
next prev parent reply other threads:[~2016-05-18 6:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 14:31 [PATCH 0/3] External Interrupt Controller (EIC) fixes Paul Burton
2016-05-17 14:31 ` Paul Burton
2016-05-17 14:31 ` [PATCH 1/3] MIPS: Clear Status IPL field when using EIC Paul Burton
2016-05-17 14:31 ` Paul Burton
2016-05-18 6:53 ` Matt Redfearn [this message]
2016-05-18 6:53 ` Matt Redfearn
2016-05-17 14:31 ` [PATCH 2/3] MIPS: smp-cps: " Paul Burton
2016-05-17 14:31 ` Paul Burton
2016-05-18 6:53 ` Matt Redfearn
2016-05-18 6:53 ` Matt Redfearn
2016-05-17 14:31 ` [PATCH 3/3] irqchip: mips-gic: Setup EIC mode on each CPU if it's in use Paul Burton
2016-05-17 14:31 ` Paul Burton
2016-05-18 6:54 ` Matt Redfearn
2016-05-18 6:54 ` Matt Redfearn
2016-05-19 9:21 ` [PATCH 0/3] External Interrupt Controller (EIC) fixes Thomas Gleixner
2016-05-19 12:32 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573C1161.6060608@imgtec.com \
--to=matt.redfearn@imgtec.com \
--cc=james.hogan@imgtec.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux@roeck-us.net \
--cc=paul.burton@imgtec.com \
--cc=ralf@linux-mips.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.