* [Qemu-trivial] [PATCH] fw_cfg: follow CODING_STYLE
@ 2016-05-18 10:59 ` Cao jin
0 siblings, 0 replies; 8+ messages in thread
From: Cao jin @ 2016-05-18 10:59 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, kraxel, mst, cminyard
Replace tab with 4 spaces; brace the indented statement.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
hw/nvram/fw_cfg.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 999f480..826181a 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -728,15 +728,20 @@ static int get_fw_cfg_order(FWCfgState *s, const char *name)
{
int i;
- if (s->fw_cfg_order_override > 0)
- return s->fw_cfg_order_override;
+ if (s->fw_cfg_order_override > 0) {
+ return s->fw_cfg_order_override;
+ }
for (i = 0; i < ARRAY_SIZE(fw_cfg_order); i++) {
- if (fw_cfg_order[i].name == NULL)
- continue;
- if (strcmp(name, fw_cfg_order[i].name) == 0)
- return fw_cfg_order[i].order;
+ if (fw_cfg_order[i].name == NULL) {
+ continue;
+ }
+
+ if (strcmp(name, fw_cfg_order[i].name) == 0) {
+ return fw_cfg_order[i].order;
+ }
}
+
/* Stick unknown stuff at the end. */
error_report("warning: Unknown firmware file in legacy mode: %s\n", name);
return FW_CFG_ORDER_OVERRIDE_LAST;
--
2.1.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Qemu-devel] [PATCH] fw_cfg: follow CODING_STYLE
@ 2016-05-18 10:59 ` Cao jin
0 siblings, 0 replies; 8+ messages in thread
From: Cao jin @ 2016-05-18 10:59 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, kraxel, mst, cminyard
Replace tab with 4 spaces; brace the indented statement.
Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
---
hw/nvram/fw_cfg.c | 17 +++++++++++------
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index 999f480..826181a 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -728,15 +728,20 @@ static int get_fw_cfg_order(FWCfgState *s, const char *name)
{
int i;
- if (s->fw_cfg_order_override > 0)
- return s->fw_cfg_order_override;
+ if (s->fw_cfg_order_override > 0) {
+ return s->fw_cfg_order_override;
+ }
for (i = 0; i < ARRAY_SIZE(fw_cfg_order); i++) {
- if (fw_cfg_order[i].name == NULL)
- continue;
- if (strcmp(name, fw_cfg_order[i].name) == 0)
- return fw_cfg_order[i].order;
+ if (fw_cfg_order[i].name == NULL) {
+ continue;
+ }
+
+ if (strcmp(name, fw_cfg_order[i].name) == 0) {
+ return fw_cfg_order[i].order;
+ }
}
+
/* Stick unknown stuff at the end. */
error_report("warning: Unknown firmware file in legacy mode: %s\n", name);
return FW_CFG_ORDER_OVERRIDE_LAST;
--
2.1.0
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [PATCH] fw_cfg: follow CODING_STYLE
2016-05-18 10:59 ` [Qemu-devel] " Cao jin
@ 2016-05-18 14:36 ` Corey Minyard
-1 siblings, 0 replies; 8+ messages in thread
From: Corey Minyard @ 2016-05-18 14:36 UTC (permalink / raw)
To: Cao jin, qemu-devel; +Cc: qemu-trivial, kraxel, mst
On 05/18/2016 05:59 AM, Cao jin wrote:
> Replace tab with 4 spaces; brace the indented statement.
Thanks, I think I have my editor set up to avoid the tab/space issue from
now on. I'm going to have to handle kernel/qemu switching in my brain
for the brace issue.
Acked-by: Corey Minyard <cminyard@mvista.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/nvram/fw_cfg.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 999f480..826181a 100644
> --- a/hw/nvram/fw_cfg.c
> +++ b/hw/nvram/fw_cfg.c
> @@ -728,15 +728,20 @@ static int get_fw_cfg_order(FWCfgState *s, const char *name)
> {
> int i;
>
> - if (s->fw_cfg_order_override > 0)
> - return s->fw_cfg_order_override;
> + if (s->fw_cfg_order_override > 0) {
> + return s->fw_cfg_order_override;
> + }
>
> for (i = 0; i < ARRAY_SIZE(fw_cfg_order); i++) {
> - if (fw_cfg_order[i].name == NULL)
> - continue;
> - if (strcmp(name, fw_cfg_order[i].name) == 0)
> - return fw_cfg_order[i].order;
> + if (fw_cfg_order[i].name == NULL) {
> + continue;
> + }
> +
> + if (strcmp(name, fw_cfg_order[i].name) == 0) {
> + return fw_cfg_order[i].order;
> + }
> }
> +
> /* Stick unknown stuff at the end. */
> error_report("warning: Unknown firmware file in legacy mode: %s\n", name);
> return FW_CFG_ORDER_OVERRIDE_LAST;
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-devel] [PATCH] fw_cfg: follow CODING_STYLE
@ 2016-05-18 14:36 ` Corey Minyard
0 siblings, 0 replies; 8+ messages in thread
From: Corey Minyard @ 2016-05-18 14:36 UTC (permalink / raw)
To: Cao jin, qemu-devel; +Cc: qemu-trivial, kraxel, mst
On 05/18/2016 05:59 AM, Cao jin wrote:
> Replace tab with 4 spaces; brace the indented statement.
Thanks, I think I have my editor set up to avoid the tab/space issue from
now on. I'm going to have to handle kernel/qemu switching in my brain
for the brace issue.
Acked-by: Corey Minyard <cminyard@mvista.com>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
> ---
> hw/nvram/fw_cfg.c | 17 +++++++++++------
> 1 file changed, 11 insertions(+), 6 deletions(-)
>
> diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
> index 999f480..826181a 100644
> --- a/hw/nvram/fw_cfg.c
> +++ b/hw/nvram/fw_cfg.c
> @@ -728,15 +728,20 @@ static int get_fw_cfg_order(FWCfgState *s, const char *name)
> {
> int i;
>
> - if (s->fw_cfg_order_override > 0)
> - return s->fw_cfg_order_override;
> + if (s->fw_cfg_order_override > 0) {
> + return s->fw_cfg_order_override;
> + }
>
> for (i = 0; i < ARRAY_SIZE(fw_cfg_order); i++) {
> - if (fw_cfg_order[i].name == NULL)
> - continue;
> - if (strcmp(name, fw_cfg_order[i].name) == 0)
> - return fw_cfg_order[i].order;
> + if (fw_cfg_order[i].name == NULL) {
> + continue;
> + }
> +
> + if (strcmp(name, fw_cfg_order[i].name) == 0) {
> + return fw_cfg_order[i].order;
> + }
> }
> +
> /* Stick unknown stuff at the end. */
> error_report("warning: Unknown firmware file in legacy mode: %s\n", name);
> return FW_CFG_ORDER_OVERRIDE_LAST;
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] fw_cfg: follow CODING_STYLE
2016-05-18 14:36 ` [Qemu-devel] " Corey Minyard
@ 2016-05-19 12:40 ` Markus Armbruster
-1 siblings, 0 replies; 8+ messages in thread
From: Markus Armbruster @ 2016-05-19 12:40 UTC (permalink / raw)
To: Corey Minyard; +Cc: Cao jin, qemu-devel, qemu-trivial, kraxel, mst
Corey Minyard <cminyard@mvista.com> writes:
> On 05/18/2016 05:59 AM, Cao jin wrote:
>> Replace tab with 4 spaces; brace the indented statement.
>
> Thanks, I think I have my editor set up to avoid the tab/space issue from
> now on. I'm going to have to handle kernel/qemu switching in my brain
> for the brace issue.
You can outsource some of it to scripts/checkpatch.pl :)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-devel] [PATCH] fw_cfg: follow CODING_STYLE
@ 2016-05-19 12:40 ` Markus Armbruster
0 siblings, 0 replies; 8+ messages in thread
From: Markus Armbruster @ 2016-05-19 12:40 UTC (permalink / raw)
To: Corey Minyard; +Cc: Cao jin, qemu-devel, qemu-trivial, kraxel, mst
Corey Minyard <cminyard@mvista.com> writes:
> On 05/18/2016 05:59 AM, Cao jin wrote:
>> Replace tab with 4 spaces; brace the indented statement.
>
> Thanks, I think I have my editor set up to avoid the tab/space issue from
> now on. I'm going to have to handle kernel/qemu switching in my brain
> for the brace issue.
You can outsource some of it to scripts/checkpatch.pl :)
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [Qemu-trivial] [PATCH] fw_cfg: follow CODING_STYLE
2016-05-18 10:59 ` [Qemu-devel] " Cao jin
@ 2016-05-29 8:35 ` Michael Tokarev
-1 siblings, 0 replies; 8+ messages in thread
From: Michael Tokarev @ 2016-05-29 8:35 UTC (permalink / raw)
To: Cao jin, qemu-devel; +Cc: qemu-trivial, cminyard, kraxel, mst
18.05.2016 13:59, Cao jin wrote:
> Replace tab with 4 spaces; brace the indented statement.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-05-29 8:35 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-18 10:59 [Qemu-trivial] [PATCH] fw_cfg: follow CODING_STYLE Cao jin
2016-05-18 10:59 ` [Qemu-devel] " Cao jin
2016-05-18 14:36 ` [Qemu-trivial] " Corey Minyard
2016-05-18 14:36 ` [Qemu-devel] " Corey Minyard
2016-05-19 12:40 ` [Qemu-trivial] " Markus Armbruster
2016-05-19 12:40 ` Markus Armbruster
2016-05-29 8:35 ` [Qemu-trivial] " Michael Tokarev
2016-05-29 8:35 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.