All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Foss <robert.foss@collabora.com>
To: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Fwd: Re: [RFC i-g-t 1/7] configure.ac: Test for libdrm_intel and build for it if present.
Date: Wed, 25 May 2016 18:09:03 -0400	[thread overview]
Message-ID: <5746227F.9000800@collabora.com> (raw)
In-Reply-To: <2415-57460c00-45-6216b000@184043486>

Forward to ML.

On Wednesday, May 25, 2016 19:18 BST, robert.foss@collabora.com wrote:

> +if test "x$INTEL" = xyes; then
> +	PKG_CHECK_MODULES(DRM_INTEL, [libdrm_intel >= 2.4.64])
> +	AC_DEFINE(HAVE_LIBDRM_INTEL, 1, [Have intel support])
> +fi
> +AM_CONDITIONAL(HAVE_LIBDRM_INTEL, [test "x$INTEL" = xyes])
> +
Strictly speaking we could add the DRM_INTEL_CFLAGS to pretty much every 
Makefile.am (in AM_CFLAGS) and LIBDRM_INTEL_LIBS (*LDADD and/or *LIBADD) 
only within the HAVE_LIBDRM_INTEL conditional.

Although to make things a bit easier, we can/should move the CFLAGS out 
of the conditional. This way:
  - building with intel gets the correct cflags (and link)
  - building without intel - gets the local cflags (include) and no link 
(in case the variable is already set to something funny).

-Emil



_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

       reply	other threads:[~2016-05-25 22:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <2415-57460c00-45-6216b000@184043486>
2016-05-25 22:09 ` Robert Foss [this message]
2016-05-25 22:18   ` Fwd: Re: [RFC i-g-t 1/7] configure.ac: Test for libdrm_intel and build for it if present Emil Velikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5746227F.9000800@collabora.com \
    --to=robert.foss@collabora.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.