Fwd: Re: [RFC i-g-t 1/7] configure.ac: Test for libdrm_intel and build for it if present.

Fwd: Re: [RFC i-g-t 1/7] configure.ac: Test for libdrm_intel and build for it if present.

[Robert Foss]

Forward to ML.

On Wednesday, May 25, 2016 19:18 BST, robert.foss@collabora.com wrote:

> +if test "x$INTEL" = xyes; then
> +	PKG_CHECK_MODULES(DRM_INTEL, [libdrm_intel >= 2.4.64])
> +	AC_DEFINE(HAVE_LIBDRM_INTEL, 1, [Have intel support])
> +fi
> +AM_CONDITIONAL(HAVE_LIBDRM_INTEL, [test "x$INTEL" = xyes])
> +
Strictly speaking we could add the DRM_INTEL_CFLAGS to pretty much every 
Makefile.am (in AM_CFLAGS) and LIBDRM_INTEL_LIBS (*LDADD and/or *LIBADD) 
only within the HAVE_LIBDRM_INTEL conditional.

Although to make things a bit easier, we can/should move the CFLAGS out 
of the conditional. This way:
  - building with intel gets the correct cflags (and link)
  - building without intel - gets the local cflags (include) and no link 
(in case the variable is already set to something funny).

-Emil



_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: Fwd: Re: [RFC i-g-t 1/7] configure.ac: Test for libdrm_intel and build for it if present.

[Emil Velikov]

On 25 May 2016 at 23:09, Robert Foss <robert.foss@collabora.com> wrote:
> Forward to ML.
>
> On Wednesday, May 25, 2016 19:18 BST, robert.foss@collabora.com wrote:
>
>> +if test "x$INTEL" = xyes; then
>> +       PKG_CHECK_MODULES(DRM_INTEL, [libdrm_intel >= 2.4.64])
>> +       AC_DEFINE(HAVE_LIBDRM_INTEL, 1, [Have intel support])
>> +fi
>> +AM_CONDITIONAL(HAVE_LIBDRM_INTEL, [test "x$INTEL" = xyes])
>> +
>
> Strictly speaking we could add the DRM_INTEL_CFLAGS to pretty much every
> Makefile.am (in AM_CFLAGS) and LIBDRM_INTEL_LIBS (*LDADD and/or *LIBADD)
> only within the HAVE_LIBDRM_INTEL conditional.
>
> Although to make things a bit easier, we can/should move the CFLAGS out of
> the conditional. This way:
>  - building with intel gets the correct cflags (and link)
>  - building without intel - gets the local cflags (include) and no link (in
> case the variable is already set to something funny).
>
Thanks for forwarding these Rob. Seems like company email client and
me did not fair well :-\

I'll make a note to double-check the to/cc list for the future.
Emil
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx