* Fwd: Re: [RFC i-g-t 1/7] configure.ac: Test for libdrm_intel and build for it if present. [not found] <2415-57460c00-45-6216b000@184043486> @ 2016-05-25 22:09 ` Robert Foss 2016-05-25 22:18 ` Emil Velikov 0 siblings, 1 reply; 2+ messages in thread From: Robert Foss @ 2016-05-25 22:09 UTC (permalink / raw) To: Intel Graphics Development Forward to ML. On Wednesday, May 25, 2016 19:18 BST, robert.foss@collabora.com wrote: > +if test "x$INTEL" = xyes; then > + PKG_CHECK_MODULES(DRM_INTEL, [libdrm_intel >= 2.4.64]) > + AC_DEFINE(HAVE_LIBDRM_INTEL, 1, [Have intel support]) > +fi > +AM_CONDITIONAL(HAVE_LIBDRM_INTEL, [test "x$INTEL" = xyes]) > + Strictly speaking we could add the DRM_INTEL_CFLAGS to pretty much every Makefile.am (in AM_CFLAGS) and LIBDRM_INTEL_LIBS (*LDADD and/or *LIBADD) only within the HAVE_LIBDRM_INTEL conditional. Although to make things a bit easier, we can/should move the CFLAGS out of the conditional. This way: - building with intel gets the correct cflags (and link) - building without intel - gets the local cflags (include) and no link (in case the variable is already set to something funny). -Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Fwd: Re: [RFC i-g-t 1/7] configure.ac: Test for libdrm_intel and build for it if present. 2016-05-25 22:09 ` Fwd: Re: [RFC i-g-t 1/7] configure.ac: Test for libdrm_intel and build for it if present Robert Foss @ 2016-05-25 22:18 ` Emil Velikov 0 siblings, 0 replies; 2+ messages in thread From: Emil Velikov @ 2016-05-25 22:18 UTC (permalink / raw) To: Robert Foss; +Cc: Intel Graphics Development On 25 May 2016 at 23:09, Robert Foss <robert.foss@collabora.com> wrote: > Forward to ML. > > On Wednesday, May 25, 2016 19:18 BST, robert.foss@collabora.com wrote: > >> +if test "x$INTEL" = xyes; then >> + PKG_CHECK_MODULES(DRM_INTEL, [libdrm_intel >= 2.4.64]) >> + AC_DEFINE(HAVE_LIBDRM_INTEL, 1, [Have intel support]) >> +fi >> +AM_CONDITIONAL(HAVE_LIBDRM_INTEL, [test "x$INTEL" = xyes]) >> + > > Strictly speaking we could add the DRM_INTEL_CFLAGS to pretty much every > Makefile.am (in AM_CFLAGS) and LIBDRM_INTEL_LIBS (*LDADD and/or *LIBADD) > only within the HAVE_LIBDRM_INTEL conditional. > > Although to make things a bit easier, we can/should move the CFLAGS out of > the conditional. This way: > - building with intel gets the correct cflags (and link) > - building without intel - gets the local cflags (include) and no link (in > case the variable is already set to something funny). > Thanks for forwarding these Rob. Seems like company email client and me did not fair well :-\ I'll make a note to double-check the to/cc list for the future. Emil _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-25 22:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2415-57460c00-45-6216b000@184043486>
2016-05-25 22:09 ` Fwd: Re: [RFC i-g-t 1/7] configure.ac: Test for libdrm_intel and build for it if present Robert Foss
2016-05-25 22:18 ` Emil Velikov
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.