From: Lokesh Vutla <lokeshvutla-l0cyMroinI0@public.gmane.org>
To: Ravikumar Kattekola <rk-l0cyMroinI0@public.gmane.org>,
paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org,
tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org,
linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
Date: Thu, 26 May 2016 09:25:24 +0530 [thread overview]
Message-ID: <574673AC.2030209@ti.com> (raw)
In-Reply-To: <20160525125341.10044-2-rk-l0cyMroinI0@public.gmane.org>
On Wednesday 25 May 2016 06:23 PM, Ravikumar Kattekola wrote:
> dra72x device has i2c6 controller.
> Adding hwmod definition for the same.
>
> Reference DRA72x TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk-l0cyMroinI0@public.gmane.org>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index d0e7e525..b84c0f7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
> .dev_attr = &i2c_dev_attr,
> };
>
> +/* i2c6 */
> +static struct omap_hwmod dra7xx_i2c6_hwmod = {
> + .name = "i2c6",
> + .class = &dra7xx_i2c_hwmod_class,
> + .clkdm_name = "l4per2_clkdm",
> + .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
> + .main_clk = "func_96m_fclk",
> + .prcm = {
> + .omap4 = {
> + },
> + },
> + .dev_attr = &i2c_dev_attr,
> +};
> +
> /*
> * 'mailbox' class
> *
> @@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_per2 -> i2c6 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
> + .master = &dra7xx_l4_per2_hwmod,
> + .slave = &dra7xx_i2c6_hwmod,
> + .clk = "l3_iclk_div",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_cfg -> mailbox1 */
> static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
> .master = &dra7xx_l4_cfg_hwmod,
> @@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per1__i2c3,
> &dra7xx_l4_per1__i2c4,
> &dra7xx_l4_per1__i2c5,
> + &dra7xx_l4_per2__i2c6,
If it is available only on dra72x, register the hwmod under
dra72x_hwmod_ocp_ifs. Also in $subject use dra72x to make things clear.
Thanks and regards,
Lokesh
> &dra7xx_l4_cfg__mailbox1,
> &dra7xx_l4_per3__mailbox2,
> &dra7xx_l4_per3__mailbox3,
>
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: lokeshvutla@ti.com (Lokesh Vutla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
Date: Thu, 26 May 2016 09:25:24 +0530 [thread overview]
Message-ID: <574673AC.2030209@ti.com> (raw)
In-Reply-To: <20160525125341.10044-2-rk@ti.com>
On Wednesday 25 May 2016 06:23 PM, Ravikumar Kattekola wrote:
> dra72x device has i2c6 controller.
> Adding hwmod definition for the same.
>
> Reference DRA72x TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index d0e7e525..b84c0f7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
> .dev_attr = &i2c_dev_attr,
> };
>
> +/* i2c6 */
> +static struct omap_hwmod dra7xx_i2c6_hwmod = {
> + .name = "i2c6",
> + .class = &dra7xx_i2c_hwmod_class,
> + .clkdm_name = "l4per2_clkdm",
> + .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
> + .main_clk = "func_96m_fclk",
> + .prcm = {
> + .omap4 = {
> + },
> + },
> + .dev_attr = &i2c_dev_attr,
> +};
> +
> /*
> * 'mailbox' class
> *
> @@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_per2 -> i2c6 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
> + .master = &dra7xx_l4_per2_hwmod,
> + .slave = &dra7xx_i2c6_hwmod,
> + .clk = "l3_iclk_div",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_cfg -> mailbox1 */
> static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
> .master = &dra7xx_l4_cfg_hwmod,
> @@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per1__i2c3,
> &dra7xx_l4_per1__i2c4,
> &dra7xx_l4_per1__i2c5,
> + &dra7xx_l4_per2__i2c6,
If it is available only on dra72x, register the hwmod under
dra72x_hwmod_ocp_ifs. Also in $subject use dra72x to make things clear.
Thanks and regards,
Lokesh
> &dra7xx_l4_cfg__mailbox1,
> &dra7xx_l4_per3__mailbox2,
> &dra7xx_l4_per3__mailbox3,
>
WARNING: multiple messages have this Message-ID (diff)
From: Lokesh Vutla <lokeshvutla@ti.com>
To: Ravikumar Kattekola <rk@ti.com>, <paul@pwsan.com>,
<tony@atomide.com>, <linux@armlinux.org.uk>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <galak@codeaurora.org>,
<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6
Date: Thu, 26 May 2016 09:25:24 +0530 [thread overview]
Message-ID: <574673AC.2030209@ti.com> (raw)
In-Reply-To: <20160525125341.10044-2-rk@ti.com>
On Wednesday 25 May 2016 06:23 PM, Ravikumar Kattekola wrote:
> dra72x device has i2c6 controller.
> Adding hwmod definition for the same.
>
> Reference DRA72x TRM [ SPRUHP2Q ]
>
> Signed-off-by: Ravikumar Kattekola <rk@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index d0e7e525..b84c0f7 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -1127,6 +1127,20 @@ static struct omap_hwmod dra7xx_i2c5_hwmod = {
> .dev_attr = &i2c_dev_attr,
> };
>
> +/* i2c6 */
> +static struct omap_hwmod dra7xx_i2c6_hwmod = {
> + .name = "i2c6",
> + .class = &dra7xx_i2c_hwmod_class,
> + .clkdm_name = "l4per2_clkdm",
> + .flags = HWMOD_16BIT_REG | HWMOD_SET_DEFAULT_CLOCKACT,
> + .main_clk = "func_96m_fclk",
> + .prcm = {
> + .omap4 = {
> + },
> + },
> + .dev_attr = &i2c_dev_attr,
> +};
> +
> /*
> * 'mailbox' class
> *
> @@ -3186,6 +3200,14 @@ static struct omap_hwmod_ocp_if dra7xx_l4_per1__i2c5 = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> +/* l4_per2 -> i2c6 */
> +static struct omap_hwmod_ocp_if dra7xx_l4_per2__i2c6 = {
> + .master = &dra7xx_l4_per2_hwmod,
> + .slave = &dra7xx_i2c6_hwmod,
> + .clk = "l3_iclk_div",
> + .user = OCP_USER_MPU | OCP_USER_SDMA,
> +};
> +
> /* l4_cfg -> mailbox1 */
> static struct omap_hwmod_ocp_if dra7xx_l4_cfg__mailbox1 = {
> .master = &dra7xx_l4_cfg_hwmod,
> @@ -3857,6 +3879,7 @@ static struct omap_hwmod_ocp_if *dra7xx_hwmod_ocp_ifs[] __initdata = {
> &dra7xx_l4_per1__i2c3,
> &dra7xx_l4_per1__i2c4,
> &dra7xx_l4_per1__i2c5,
> + &dra7xx_l4_per2__i2c6,
If it is available only on dra72x, register the hwmod under
dra72x_hwmod_ocp_ifs. Also in $subject use dra72x to make things clear.
Thanks and regards,
Lokesh
> &dra7xx_l4_cfg__mailbox1,
> &dra7xx_l4_per3__mailbox2,
> &dra7xx_l4_per3__mailbox3,
>
next prev parent reply other threads:[~2016-05-26 3:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 12:53 [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 12:53 ` [PATCH 1/2] arm: dra7: Add hwmod entry for i2c6 Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 16:10 ` Nishanth Menon
2016-05-25 16:10 ` Nishanth Menon
2016-05-25 16:10 ` Nishanth Menon
[not found] ` <20160525125341.10044-2-rk-l0cyMroinI0@public.gmane.org>
2016-05-26 3:55 ` Lokesh Vutla [this message]
2016-05-26 3:55 ` Lokesh Vutla
2016-05-26 3:55 ` Lokesh Vutla
2016-05-25 12:53 ` [PATCH 2/2] dts: dra7: Add device tree node " Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 12:53 ` Ravikumar Kattekola
2016-05-25 16:11 ` Nishanth Menon
2016-05-25 16:11 ` Nishanth Menon
2016-05-25 16:11 ` Nishanth Menon
2016-05-25 16:09 ` [PATCH 0/2] arm: dra7: Add i2c6 instance hwmod and dt entries Nishanth Menon
2016-05-25 16:09 ` Nishanth Menon
2016-05-25 16:09 ` Nishanth Menon
2016-05-26 5:47 ` Tero Kristo
2016-05-26 5:47 ` Tero Kristo
2016-05-26 5:47 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=574673AC.2030209@ti.com \
--to=lokeshvutla-l0cymroini0@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=paul-DWxLp4Yu+b8AvxtiuMwx3w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rk-l0cyMroinI0@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.