* [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit @ 2016-05-26 3:07 ` Shawn Lin 2016-05-27 0:53 ` Jaehoon Chung 0 siblings, 1 reply; 3+ messages in thread From: Shawn Lin @ 2016-05-26 3:07 UTC (permalink / raw) To: Jaehoon Chung, Ulf Hansson Cc: linux-mmc, linux-kernel, Doug Anderson, linux-rockchip, Shawn Lin dw_mci_get_cd have already dealed with these for both of internal card-detect and gpio card-detect. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- drivers/mmc/host/dw_mmc.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c index 829a6ee..cb30e91 100644 --- a/drivers/mmc/host/dw_mmc.c +++ b/drivers/mmc/host/dw_mmc.c @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) mmc->max_seg_size = mmc->max_req_size; } - if (dw_mci_get_cd(mmc)) - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); - else - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); + dw_mci_get_cd(mmc); ret = mmc_add_host(mmc); if (ret) -- 2.3.7 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit 2016-05-26 3:07 ` [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit Shawn Lin @ 2016-05-27 0:53 ` Jaehoon Chung 2016-05-27 2:24 ` Shawn Lin 0 siblings, 1 reply; 3+ messages in thread From: Jaehoon Chung @ 2016-05-27 0:53 UTC (permalink / raw) To: Shawn Lin, Ulf Hansson Cc: linux-mmc, linux-kernel, Doug Anderson, linux-rockchip Hi Shawn, On 05/26/2016 12:07 PM, Shawn Lin wrote: > dw_mci_get_cd have already dealed with these for > both of internal card-detect and gpio card-detect. s/dealed/dealt This patch looks good to me. Could you resend the patch? not RFC. Best Regards, Jaehoon Chung > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > > --- > > drivers/mmc/host/dw_mmc.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > index 829a6ee..cb30e91 100644 > --- a/drivers/mmc/host/dw_mmc.c > +++ b/drivers/mmc/host/dw_mmc.c > @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) > mmc->max_seg_size = mmc->max_req_size; > } > > - if (dw_mci_get_cd(mmc)) > - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); > - else > - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); > + dw_mci_get_cd(mmc); > > ret = mmc_add_host(mmc); > if (ret) > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit 2016-05-27 0:53 ` Jaehoon Chung @ 2016-05-27 2:24 ` Shawn Lin 0 siblings, 0 replies; 3+ messages in thread From: Shawn Lin @ 2016-05-27 2:24 UTC (permalink / raw) To: Jaehoon Chung, Ulf Hansson Cc: shawn.lin, linux-mmc, linux-kernel, Doug Anderson, linux-rockchip 在 2016/5/27 8:53, Jaehoon Chung 写道: > Hi Shawn, > > On 05/26/2016 12:07 PM, Shawn Lin wrote: >> dw_mci_get_cd have already dealed with these for >> both of internal card-detect and gpio card-detect. > > s/dealed/dealt > > This patch looks good to me. Could you resend the patch? not RFC. > Ok. > Best Regards, > Jaehoon Chung > >> >> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> >> >> --- >> >> drivers/mmc/host/dw_mmc.c | 5 +---- >> 1 file changed, 1 insertion(+), 4 deletions(-) >> >> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c >> index 829a6ee..cb30e91 100644 >> --- a/drivers/mmc/host/dw_mmc.c >> +++ b/drivers/mmc/host/dw_mmc.c >> @@ -2616,10 +2616,7 @@ static int dw_mci_init_slot(struct dw_mci *host, unsigned int id) >> mmc->max_seg_size = mmc->max_req_size; >> } >> >> - if (dw_mci_get_cd(mmc)) >> - set_bit(DW_MMC_CARD_PRESENT, &slot->flags); >> - else >> - clear_bit(DW_MMC_CARD_PRESENT, &slot->flags); >> + dw_mci_get_cd(mmc); >> >> ret = mmc_add_host(mmc); >> if (ret) >> > > > > -- Best Regards Shawn Lin ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-27 2:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20160526030828epcas1p16b97a230c35c2599a2b8fcada376c9de@epcas1p1.samsung.com>
2016-05-26 3:07 ` [RFC PATCH 1/2] mmc: dw_mmc: remove redundant of set_bit and clear_bit Shawn Lin
2016-05-27 0:53 ` Jaehoon Chung
2016-05-27 2:24 ` Shawn Lin
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.